Re: shell32: Fix tests to apply to Vista+

2010-04-24 Thread Nikolay Sivov
On 4/23/2010 20:46, Paul Vriens wrote: On 04/23/2010 06:30 PM, André Hentschel wrote: Juan Lang schrieb: My point of view is that its not an error on windows, with this patch it passes in windows and gets a todo_wine, which it actually is (like you say). Any test that allows all possibilitie

Re: shell32: Fix tests to apply to Vista+

2010-04-23 Thread Paul Vriens
On 04/23/2010 06:30 PM, André Hentschel wrote: Juan Lang schrieb: My point of view is that its not an error on windows, with this patch it passes in windows and gets a todo_wine, which it actually is (like you say). Any test that allows all possibilities, as your patch does on Windows, is wor

Re: shell32: Fix tests to apply to Vista+

2010-04-23 Thread Nikolay Sivov
On 4/23/2010 20:30, André Hentschel wrote: Juan Lang schrieb: My point of view is that its not an error on windows, with this patch it passes in windows and gets a todo_wine, which it actually is (like you say). Any test that allows all possibilities, as your patch does on Windows,

Re: shell32: Fix tests to apply to Vista+

2010-04-23 Thread André Hentschel
Juan Lang schrieb: >> My point of view is that its not an error on windows, with this patch it >> passes in windows and gets a todo_wine, which it actually is (like you say). > > Any test that allows all possibilities, as your patch does on Windows, > is worthless. That implies that it should be

Re: shell32: Fix tests to apply to Vista+

2010-04-23 Thread Juan Lang
> My point of view is that its not an error on windows, with this patch it > passes in windows and gets a todo_wine, which it actually is (like you say). Any test that allows all possibilities, as your patch does on Windows, is worthless. That implies that it should be investigated, and, if it's

Re: shell32: Fix tests to apply to Vista+

2010-04-23 Thread André Hentschel
Nikolay Sivov schrieb: > On 4/23/2010 16:56, André Hentschel wrote: >> --- >> dlls/shell32/tests/shlfolder.c |5 - >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/dlls/shell32/tests/shlfolder.c >> b/dlls/shell32/tests/shlfolder.c >> index f63bf6e..634c3d3 100644 >>

Re: shell32: Fix tests to apply to Vista+

2010-04-23 Thread Nikolay Sivov
On 4/23/2010 16:56, André Hentschel wrote: --- dlls/shell32/tests/shlfolder.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c index f63bf6e..634c3d3 100644 --- a/dlls/shell32/tests/shlfolder.c +++ b/dl