Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]

2010-04-24 Thread Nikolay Sivov
On 4/24/2010 12:53, Ilya Basin wrote: 1) removes the block of code that splits lpFile into filename and parameters and removes ''s from filename . Even without this block ShellExecute not fails with quoted lpFile. 2) removes 2 corresponding todo_wine's from tests. The real application affected

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]

2010-04-24 Thread Paul Vriens
On 04/24/2010 10:53 AM, Ilya Basin wrote: 1) removes the block of code that splits lpFile into filename and parameters and removes ''s from filename . Even without this block ShellExecute not fails with quoted lpFile. 2) removes 2 corresponding todo_wine's from tests. The real application

Re[2]: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]

2010-04-24 Thread Ilya Basin
PV Hi Ilya, PV In your last email on wine-devel about this subject you mentioned adding PV some extra tests. There was at least some communication with you and the PV author of that piece you are now removing. The reason for that piece was PV shown in a code-snippet he gave and adding tests

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]

2010-04-24 Thread Greg Geldorp
From: Ilya Basin basini...@gmail.com Then postponing till my next slack period, the more so I got another e-mail: === W7PROX64 (32 bit shlexec) === No test failures found === W7PROX64 (64 bit shlexec) === shell32: shlexec.c:1609: Test failed: ShellExecuteEx(null,