Re: shell32 patch 20

2004-01-25 Thread Dmitry Timoshkov
Jakob Eriksson [EMAIL PROTECTED] wrote: Depending on how you define break, that argument can be used to stop almost any patch to Wine, if the goal happens to be cross compilation. What way will you decide to go, if in the next Platform SDK release Microsoft will remove some of the existing

Re: shell32 patch 20

2004-01-25 Thread Jakob Eriksson
Dmitry Timoshkov wrote: Rolf Kalbermatter [EMAIL PROTECTED] wrote: I was under the impression that it was desirable to cross compile as many dlls as possible in different environments. Yes, that's a desirable task, but only if does not require to break Wine source accomplishing it.

Re: shell32 patch 20

2004-01-25 Thread Jakob Eriksson
Dmitry Timoshkov wrote: Jakob Eriksson [EMAIL PROTECTED] wrote: Depending on how you define break, that argument can be used to stop almost any patch to Wine, if the goal happens to be cross compilation. What way will you decide to go, if in the next Platform SDK release Microsoft will

Re: shell32 patch 20

2004-01-24 Thread Martin Fuchs
Changelog: - don't link directly to NTDLL; use MultiByteToWideChar() instead of RtlCreateUnicodeStringFromAsciiz() Why do you need that? RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in PSDK. Regards, Martin

Re: shell32 patch 20

2004-01-24 Thread Dmitry Timoshkov
Martin Fuchs [EMAIL PROTECTED] wrote: Changelog: - don't link directly to NTDLL; use MultiByteToWideChar() instead of RtlCreateUnicodeStringFromAsciiz() Why do you need that? RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in PSDK. That doesn't justify the

Re: shell32 patch 20

2004-01-24 Thread Steven Edwards
Hi Dmitry, --- Dmitry Timoshkov [EMAIL PROTECTED] wrote: RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in PSDK. That doesn't justify the change IMO. There are lots of places in Wine using that construct, and it's much more convenient and avoids code duplication (with a

Re: shell32 patch 20

2004-01-24 Thread Rolf Kalbermatter
Dmitry Timoshkov [EMAIL PROTECTED] Martin Fuchs [EMAIL PROTECTED] wrote: Changelog: - don't link directly to NTDLL; use MultiByteToWideChar() instead of RtlCreateUnicodeStringFromAsciiz() Why do you need that? RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in

Re: shell32 patch 20

2004-01-24 Thread Dmitry Timoshkov
Steven Edwards [EMAIL PROTECTED] wrote: Well I would agree with you if it was just not defined in Mingw but there is nothing we can do about getting Microsoft to add it to the PSDK. If we want to build/test on MS_VC what are we to do? Microsoft provided headers and libraries usually miss a

Re: shell32 patch 20

2004-01-24 Thread Dmitry Timoshkov
Rolf Kalbermatter [EMAIL PROTECTED] wrote: I was under the impression that it was desirable to cross compile as many dlls as possible in different environments. Yes, that's a desirable task, but only if does not require to break Wine source accomplishing it. shell32 has currently only a few

Re: shell32 patch 20

2004-01-23 Thread Dmitry Timoshkov
Martin Fuchs [EMAIL PROTECTED] wrote: Changelog: - don't link directly to NTDLL; use MultiByteToWideChar() instead of RtlCreateUnicodeStringFromAsciiz() Why do you need that? -- Dmitry.