Re: stubbed powrprof.dll

2005-04-11 Thread Francois Gouget
On Sat, 9 Apr 2005, Benjamin Cutler wrote: [...] Don't include other headers in your header unless the Windows Platform SDK does it (it doesn't in this case). We would like the header dependencies to be the same as the Platform SDK, so programs can compile the same way. Hmm, ok. I'll have to make

Re: stubbed powrprof.dll

2005-04-09 Thread Mike McCormack
Benjamin Cutler wrote: Hmm, I glanced through it, and it looked to me like sticking it at the end was as good as anywhere else, and I didn't have to worry about falling into some #ifdef block I hadn't noticed, so that's where I put it. Actually, there's already a power management section in there,

Re: stubbed powrprof.dll

2005-04-09 Thread Benjamin Cutler
Mike McCormack wrote: > > Function calls are at the end. Groups of enums and defines that relate > to the same kind of stuff are together, more or less... > > Just add it somewhere where it looks good to you ... probably in the > middle somewhere after other groups of enums. > > Mike > > > H

Re: stubbed powrprof.dll

2005-04-09 Thread Mike McCormack
Benjamin Cutler wrote: Is there some way that winnt.h is organized, or can I just throw them in at the end? That header file is gigantic so I can't tell if it's supposed to be organized in some particular way. Function calls are at the end. Groups of enums and defines that relate to the same kind

Re: stubbed powrprof.dll

2005-04-09 Thread Benjamin Cutler
Mike McCormack wrote: > > You don't need to diff configure, only configure.ac > > You can probably omit dlls/Makefile.in too, as it is also automatically > generated (by make_dlls). > Alright, I'll take these out of the next diff. > > Most of the Wine headers use the prefix __WINE_ -> __WINE_

Re: stubbed powrprof.dll

2005-04-09 Thread Mike McCormack
Hi Benjamin, Benjamin Cutler wrote: Better patch, plus I messed up one function name (leave it to MS to break their own convention in their own library). Generally looks good. I'd advise you to try get the header modifications in first in a seperate patch, then send a different patch for the imp

Re: stubbed powrprof.dll

2005-04-09 Thread Benjamin Cutler
Better patch, plus I messed up one function name (leave it to MS to break their own convention in their own library). diff -urN wine/configure wine.new/configure --- wine/configure 2005-04-09 21:33:30.0 -0600 +++ wine.new/configure 2005-04-09 21:32:53.0 -0600 @@ -20054,7 +20054,7 @

stubbed powrprof.dll

2005-04-09 Thread Benjamin Cutler
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This is my first attempt at contributing anything to the Wine tree, so if I've made any common 'newbie' mistakes, that's probably why. I've been experimenting with dx9wine to see if I can get Planetside working (that game is the only reason I'd even c