Re: urlmon: Fix incorrect pointer arithmetic (too conversative) in map_url_to_zone. (RESEND^2)

2011-06-16 Thread Gerald Pfeifer
A friendly soul pointed out to me that I had missed three(!) responses to my patch which went to wine-devel@. Sorry about that, I'll see to set up some mail filters to prevent that from happening. For the record, somehow I got mislead re the semantics of sizeof, and that after some 25 years of pr

Re: urlmon: Fix incorrect pointer arithmetic (too conversative) in map_url_to_zone. (RESEND)

2011-06-05 Thread Joris Huizer
On 06/04/2011 03:02 PM, Gerald Pfeifer wrote: Resending: This really looks like a straightforward bug fix and the current code definitely wrong??? The difference between two pointers (of the same type) is the number of elements, not the number of bytes. Thus the code below was way incorrect,

Re: urlmon: Fix incorrect pointer arithmetic (too conversative) in map_url_to_zone. (RESEND)

2011-06-04 Thread Ken Thomases
On Jun 4, 2011, at 8:02 AM, Gerald Pfeifer wrote: > Resending: This really looks like a straightforward bug fix and the > current code definitely wrong??? No. As others have pointed out, your logic is wrong. The existing code is correct. > The difference between two pointers (of the same typ