Alexandre Julliard wrote:
> > This test is supposed to show the root of the problem with the test
> > application attached to the bug 13951. It appears that the check performed
> > by server/window.c,is_top_level_window() is not correct (which leads to
> > a SetWindowPos() failure to set foregrou
Dmitry Timoshkov writes:
> This test is supposed to show the root of the problem with the test
> application attached to the bug 13951. It appears that the check performed
> by server/window.c,is_top_level_window() is not correct (which leads to
> a SetWindowPos() failure to set foreground window
Marvin wrote:
> === W7PROX64 (64 bit win) ===
> win.c:3480: Test failed: SetForegroundWindow() failed
That's pretty strange, a standalone test I sent to testbot passed
without any failures.
--
Dmitry.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=9039
Your paranoid android.
Dmitry Timoshkov writes:
> +SetLastError(0xdeadbeef);
> +todo_wine
> +ok(SetForegroundWindow(popup), "SetForegroundWindow() error %d\n",
> GetLastError());
It would be interesting to test what the foreground window is actually
set to.
> +SetLastError(0xdeadbeef);
> +ok(DestroyW
Joris Huizer wrote:
> > - ret = DestroyWindow(parent);
> > - ok( ret, "DestroyWindow() error %d\n",
> > GetLastError());
> > + ok(DestroyWindow(parent), "DestroyWindow()
> > error %d\n", GetLastError());
>
> Please don't merge the call with the ok() statement; the GetLastError() call
>
Hello Dmitry Timoshkov,
I noticed a small issue in your patch:
>
> - ret = DestroyWindow(parent);
> - ok( ret, "DestroyWindow() error %d\n",
> GetLastError());
> + ok(DestroyWindow(parent), "DestroyWindow()
> error %d\n", GetLastError());
Please don't merge the call with the ok() stat
