:46:55 +0300
Subject: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without
an IDOK
This fixes #23453 (both the app and attached MFC test case), #21295
(but not #22544), and #23936. A test is included.
---
dlls/user32/dialog.c |6 ++
dlls/user32/tests/dialog.c | 24
--
Best regards,
Vladimirmailto:thecybersha...@gmail.com
From a549da33e3dc5020558e8c2f62f706974d40a78b Mon Sep 17 00:00:00 2001
From: Vladimir Panteleev
Date: Tue, 14 Sep 2010 16:46:55 +0300
Subject: user32: Fix VK_RETURN handling in IsDialogMessage for dialogs without
an
Vladimir Panteleev wrote:
> I reduced the patch to two lines (it's not visible from the context,
> but there's a "return TRUE" lower to make up for the removed one).
> Hopefully it's not too cryptic now. Thanks for the feedback.
Looks good to me.
--
Dmitry.
Vladimir Panteleev wrote:
> How does this look? I took the opportunity to remove the duplicate
> "GetDlgItem(hwndDlg, LOWORD(dw))".
It's better, but since BN_CLICKED is 0, there is no need to introduce wParam.
--
Dmitry.
Vladimir Panteleev wrote:
> diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c
> index aac8a4d..ee99710 100644
> --- a/dlls/user32/dialog.c
> +++ b/dlls/user32/dialog.c
> @@ -1221,6 +1221,11 @@ BOOL WINAPI IsDialogMessageW( HWND hwndDlg, LPMSG msg )
> else if (DC_HASDEFID =