Re: user32: Partially implement FlashWindowEx with tests (try 2)

2011-05-23 Thread Alexandre Julliard
André Hentschel writes: > +for (i=0; iuCount + 1; i++) > +{ > +FlashWindow(pfwi->hwnd, TRUE); > +Sleep(msecs); > +FlashWindow(pfwi->hwnd, FALSE); > +Sleep(msecs); > +} I don't think you want to hang the app that way. -- Alexandre Julliard julli...@wi

Re: user32: Partially implement FlashWindowEx with tests

2011-05-22 Thread Detlef Riekenberg
On So, 2011-05-22, André Hentschel wrote > Thanks, will get into try 2 > pfwi->cbSize < sizeof(FLASHWINFO) || pfwi->cbSize > sizeof(FLASHWINFO) That code can be reduced to: pfwi->cbSize != sizeof(FLASHWINFO) -- By by ... Detlef

Re: user32: Partially implement FlashWindowEx with tests

2011-05-22 Thread André Hentschel
Am 22.05.2011 09:58, schrieb Dmitry Timoshkov: > André Hentschel wrote: > >> +if (!pfwi->hwnd || pfwi->cbSize < sizeof(FLASHWINFO)) >> +{ >> +SetLastError(ERROR_INVALID_PARAMETER); >> +return FALSE; >> +} > > I don't see in your tests the case for 'cbSize > sizeof(FLA

Re: user32: Partially implement FlashWindowEx with tests

2011-05-22 Thread Dmitry Timoshkov
André Hentschel wrote: > +if (!pfwi->hwnd || pfwi->cbSize < sizeof(FLASHWINFO)) > +{ > +SetLastError(ERROR_INVALID_PARAMETER); > +return FALSE; > +} I don't see in your tests the case for 'cbSize > sizeof(FLASHWINFO)'. Also using !IsWindow() instead of !hwnd would fix