Re: user32: combine horizontal and vertical window scroll bar info in a single structure.

2009-05-03 Thread Rein Klazes
On Fri, 01 May 2009 22:15:16 +0200, you wrote: >Rein Klazes writes: > >> What is already in the tests: >> >> 1) You need the alloc flag for instance when SetScrollInfo or >> SetScrollRange is called on a window without the WS_[HV]SCROLL styles. I >> can add a test that shows that the window style

Re: user32: combine horizontal and vertical window scroll bar info in a single structure.

2009-05-01 Thread Alexandre Julliard
Rein Klazes writes: > What is already in the tests: > > 1) You need the alloc flag for instance when SetScrollInfo or > SetScrollRange is called on a window without the WS_[HV]SCROLL styles. I > can add a test that shows that the window styles remain unchanged when > eg. SetScrollInfo creates the

Re: user32: combine horizontal and vertical window scroll bar info in a single structure.

2009-05-01 Thread Rein Klazes
On Fri, 01 May 2009 13:13:05 +0200, you wrote: >Rein Klazes writes: > >> -if (!infoPtr && alloc) >> +if (!infoPtr && ( alloc || (wndPtr->dwStyle & (WS_VSCROLL | >> WS_HSCROLL >> { > >This bit doesn't look right, and defeats the purpose of the alloc >flag. It would need some more

Re: user32: combine horizontal and vertical window scroll bar info in a single structure.

2009-05-01 Thread Alexandre Julliard
Rein Klazes writes: > -if (!infoPtr && alloc) > +if (!infoPtr && ( alloc || (wndPtr->dwStyle & (WS_VSCROLL | > WS_HSCROLL > { This bit doesn't look right, and defeats the purpose of the alloc flag. It would need some more test cases. -- Alexandre Julliard julli...@winehq.org