Re: widl [3/4]: Remove printf format strings that aren't really format strings.

2007-10-23 Thread David Laight
On Thu, Oct 18, 2007 at 11:12:23AM +0200, Michael Stefaniuc wrote: > > -fprintf(file, varname); > > +fprintf(file, "%s", varname); > fputs() would be a faster alternative to that. Though i doubt that > matters in this case. FWIW gcc tends to convert fprintf(file, "%s", arg) into

Re: widl [3/4]: Remove printf format strings that aren't really format strings.

2007-10-18 Thread Michael Stefaniuc
Dan Hipschman wrote: > On Thu, Oct 18, 2007 at 11:12:23AM +0200, Michael Stefaniuc wrote: >> Dan Hipschman wrote: >>> This is just a minor cleanup patch. Even if we're definitely sure a >>> string doesn't contain any % signs, it's still better not to use it as a >>> printf format string. >> fputs(

Re: widl [3/4]: Remove printf format strings that aren't really format strings.

2007-10-18 Thread Dan Hipschman
On Thu, Oct 18, 2007 at 11:12:23AM +0200, Michael Stefaniuc wrote: > Dan Hipschman wrote: > > This is just a minor cleanup patch. Even if we're definitely sure a > > string doesn't contain any % signs, it's still better not to use it as a > > printf format string. > fputs() would be a faster alter

Re: widl [3/4]: Remove printf format strings that aren't really format strings.

2007-10-18 Thread Michael Stefaniuc
Dan Hipschman wrote: > This is just a minor cleanup patch. Even if we're definitely sure a > string doesn't contain any % signs, it's still better not to use it as a > printf format string. fputs() would be a faster alternative to that. Though i doubt that matters in this case. bye michae