Re: wined3d: Avoid sizeof on structs with variable length arrays.

2012-06-13 Thread Henri Verbeet
On 13 June 2012 10:41, Michael Stefaniuc mstef...@redhat.de wrote: -    object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); +    object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1])); That's not really a VLA, just a somewhat

Re: wined3d: Avoid sizeof on structs with variable length arrays.

2012-06-13 Thread Michael Stefaniuc
On 06/13/2012 12:56 PM, Henri Verbeet wrote: On 13 June 2012 10:41, Michael Stefaniuc mstef...@redhat.de wrote: -object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); +object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1]));

Re: wined3d: Avoid sizeof on structs with variable length arrays.

2012-06-13 Thread Henri Verbeet
On 13 June 2012 13:27, Michael Stefaniuc mstef...@redhat.com wrote: Uh... Any reason that field cannot be just  struct wined3d_adapter adapter; ? Not really, but if we actually supported multihead we'd have multiple adapters and would need to change it back again.