Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-21 Thread Henri Verbeet
2011/3/21 Roderick Colenbrander : > Good :) I guess I should submit the patch as it is now, I hope Henri > would be fine with doing it this way for the time being (the FBO code > is doing something equivalent). Should be ok for the time being.

Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-21 Thread Roderick Colenbrander
On Mon, Mar 21, 2011 at 5:12 PM, Konrad Rzepecki wrote: > Dnia poniedziałek, 21 marca 2011, Roderick Colenbrander napisał(a): >> Okay, as I expected no ARB_fragment_program support. Give the attached >> patch a try. For the time being (hope to get a little bit of time to >> finish what I started..

Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-21 Thread Konrad Rzepecki
Dnia poniedziałek, 21 marca 2011, Roderick Colenbrander napisał(a): > Okay, as I expected no ARB_fragment_program support. Give the attached > patch a try. For the time being (hope to get a little bit of time to > finish what I started..) this patch may be acceptable. No crash with your patch, so

Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-21 Thread Roderick Colenbrander
Okay, as I expected no ARB_fragment_program support. Give the attached patch a try. For the time being (hope to get a little bit of time to finish what I started..) this patch may be acceptable. Roderick On Mon, Mar 21, 2011 at 8:36 AM, Konrad Rzepecki wrote: > Dnia poniedziałek, 21 marca 2011,

Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-21 Thread Konrad Rzepecki
Dnia poniedziałek, 21 marca 2011, napisałeś(aś): > You should try to figure out why blit_priv is NULL. That's the real > issue. I wish to know, where to search. But my patch prevent crash if blit_priv is NULL form some reason. This is best place I found to fallback to software. > What drivers a

Re: wined3d: Prevent crash when blit_priv is NULL.

2011-03-20 Thread Roderick Colenbrander
Hi Konrad, You should try to figure out why blit_priv is NULL. That's the real issue. What drivers are you using? Do they support arb fragment program? Right now we may still call arbfp_blit_surface when the extension isn't around (was working on this a year ago, haven't had time since then :( ),