Re: wined3d: fix a compiler warning

2009-06-25 Thread Michael Stefaniuc
Ben Klein wrote: > 2009/6/24 Michael Stefaniuc : >> Pierre Bourdon wrote: >>> I think what Michael meant is that >>> sprintf(a, "%s", b); >>> >>> is doing exactly the same thing as >>> strcpy(a, b); >> Right, that's what I meant. >> >>> in a less efficient way. >> I'm not that much concerne

Re: wined3d: fix a compiler warning

2009-06-24 Thread Ben Klein
2009/6/24 Michael Stefaniuc : > Pierre Bourdon wrote: >> >> I think what Michael meant is that >>     sprintf(a, "%s", b); >> >> is doing exactly the same thing as >>     strcpy(a, b); > Right, that's what I meant. > >> in a less efficient way. > I'm not that much concerned about efficiency as the

Re: wined3d: fix a compiler warning

2009-06-24 Thread Michael Stefaniuc
Pierre Bourdon wrote: > On Wed, Jun 24, 2009 at 03:43, Austin English wrote: >> On Tue, Jun 23, 2009 at 3:58 AM, Michael Stefaniuc wrote: >>> Hello Austin, >>> >>> are you reinventing strcpy? >> We do this elsewhere throughout the source. It prevents possible >> crashes/security vulnerabilities, as

Re: wined3d: fix a compiler warning

2009-06-23 Thread Austin English
On Tue, Jun 23, 2009 at 9:45 PM, Pierre Bourdon wrote: > On Wed, Jun 24, 2009 at 03:43, Austin English wrote: >> On Tue, Jun 23, 2009 at 3:58 AM, Michael Stefaniuc wrote: >>> Hello Austin, >>> >>> are you reinventing strcpy? >> >> We do this elsewhere throughout the source. It prevents possible >>

Re: wined3d: fix a compiler warning

2009-06-23 Thread Pierre Bourdon
On Wed, Jun 24, 2009 at 03:43, Austin English wrote: > On Tue, Jun 23, 2009 at 3:58 AM, Michael Stefaniuc wrote: >> Hello Austin, >> >> are you reinventing strcpy? > > We do this elsewhere throughout the source. It prevents possible > crashes/security vulnerabilities, as well as this warning: > arb

Re: wined3d: fix a compiler warning

2009-06-23 Thread Austin English
On Tue, Jun 23, 2009 at 3:58 AM, Michael Stefaniuc wrote: > Hello Austin, > > are you reinventing strcpy? We do this elsewhere throughout the source. It prevents possible crashes/security vulnerabilities, as well as this warning: arb_program_shader.c: In function ‘shader_arb_get_register_name’: ar

Re: wined3d: fix a compiler warning

2009-06-23 Thread Michael Stefaniuc
Hello Austin, On Tue, Jun 23, 2009 at 12:47:18AM -0500, Austin English wrote: > Okay'ed by Henri > are you reinventing strcpy? > diff --git a/dlls/wined3d/arb_program_shader.c > b/dlls/wined3d/arb_program_shader.c > index 44b4fce..f759372 100644 > --- a/dlls/wined3d/arb_program_shader.c > +++ b

Re: wined3d: fix a compiler warning (2/10)

2008-11-12 Thread Henri Verbeet
The fix is mostly correct (although obviously there's more wrong with that code), but please use a slightly more descriptive subject. "Fix a compiler warning" doesn't say a whole lot.