Re: winedump: code cleanup

2010-04-02 Thread Mikhail Maroukhine
oops. Absolutely agree. Thanks for the comment. Will fix it. Thanks, Mikhail On Fri, 02 Apr 2010 00:29:16 +0700, Alexandre Julliard wrote: "Mikhail Maroukhine" writes: Hello, Could you clear a little what do you mean under "stop abusing"? I've removed incorrect usage of constness in de

Re: winedump: code cleanup

2010-04-01 Thread Alexandre Julliard
"Mikhail Maroukhine" writes: > Hello, > > Could you clear a little what do you mean under "stop abusing"? > I've removed incorrect usage of constness in declaration for the > variable that is changed for sure. > I've send "try 2" patch with additional correction and extended log > message. I mea

Re: winedump: code cleanup

2010-04-01 Thread Mikhail Maroukhine
On Tue, 30 Mar 2010 22:36:21 +0700, Alexandre Julliard wrote: "Mikhail Maroukhine" writes: - winedump/search.c::get_type - cleanup variable usage That's not much better. It would be cleaner to stop abusing the passed argument as a local variable. Hello, Could you clear a little what

Re: winedump: code cleanup

2010-03-30 Thread Alexandre Julliard
"Mikhail Maroukhine" writes: > - winedump/search.c::get_type - cleanup variable usage That's not much better. It would be cleaner to stop abusing the passed argument as a local variable. -- Alexandre Julliard julli...@winehq.org