Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-24 Thread Vitaliy Margolen
On 01/22/2010 03:42 PM, Lauri Kenttä wrote: The SetCursorPos() calls hooks on Wine because Wine has big issue - it doesn't filter pointer move messages that were caused by Wine itself. The first patch (http://source.winehq.org/patches/data/57569) tries to address exactly this. I think

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-23 Thread Ricardo Filipe
2010/1/22 Lauri Kenttä lauri.ken...@gmail.com: hi lauri. i'm glad you take people's comments with a grain of salt. vitaliy was a bit condescending but he said please :D it's unfortunate but we have to get used to it. i know it's not the best to entice developers but it's what we have, and it's

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-23 Thread Lauri Kenttä
James McKenzie wrote: Programming can and is brutal. Yes, I know. But programming can also be nice and fun. It will be exactly what the community makes it. I've seen both kinds, and guess which ones have had more active users. This was my point, so do not misunderstand: I'm certainly not saying

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-23 Thread Lauri Kenttä
Ricardo Filipe wrote: see: http://bugs.winehq.org/show_bug.cgi?id=6971 Ok, that really explains something. Thanks a lot, I'll find a game to test. -- Lauri Kenttä

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-23 Thread James McKenzie
Lauri Kenttä wrote: James McKenzie wrote: Programming can and is brutal. Yes, I know. But programming can also be nice and fun. It will be exactly what the community makes it. I've seen both kinds, and guess which ones have had more active users. This was my point, so do not

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-22 Thread Lauri Kenttä
The SetCursorPos() calls hooks on Wine because Wine has big issue - it doesn't filter pointer move messages that were caused by Wine itself. The first patch (http://source.winehq.org/patches/data/57569) tries to address exactly this. I think XWarpCursor is not a problem, as the event comes

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-22 Thread James McKenzie
Lauri Kenttä wrote: My apologies for bringing up something that is actually none of my business, but I think you should pay more attention to the way you write your comments. First, even small positive comments are considered psychologically very important, but you have given none. Second,

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-21 Thread Lauri Kenttä
Thanks for your comments, Vitaliy. At first, I must point out that you're commenting on a patch that has already been superseded. Not that there's much difference, but the new series of patches has some related changes (including a new test) applied before this one. Vitaliy Margolen wrote: Lots

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-21 Thread Vitaliy Margolen
Lauri Kenttä wrote: The new series of patches has some related changes (including a new test) applied before this one. You have some issues in your test as well. The SetCursorPos() calls hooks on Wine because Wine has big issue - it doesn't filter pointer move messages that were caused by Wine

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-20 Thread Vitaliy Margolen
Lauri Kenttä wrote: When the cursor position is clipped with ClipCursor, the cursor should be confined to that area. This patch fixes cursor position clipping in X11DRV_ClipCursor, X11DRV_GetCursorPos, X11DRV_SetCursorPos and X11DRV_send_mouse_input and makes the mouse warp to the new position