Re: winscard: add pcsc-lite helpers for upcoming(?) implementation

2009-11-15 Thread Heiko Nardmann
To my knowledge the integration of the patches by Mounir IDRASSI has been rejected due to missing automated tests. This is a problem since for a full test someone has to write/provide an IFD handler which emulates some stuff. So far I haven't found some kind of virtual card reader - maybe

Re: winscard: add pcsc-lite helpers for upcoming(?) implementation

2009-11-15 Thread Juan Lang
To my knowledge the integration of the patches by Mounir IDRASSI has been rejected due to missing automated tests. This is a problem since for a full test someone has to write/provide an IFD handler which emulates some stuff. IIRC, there was also a problem with the way it integration was done.

Re: winscard: add pcsc-lite helpers for upcoming(?) implementation

2009-11-13 Thread viny
joerg-cyril.hoe...@t-systems.com a écrit : Hi, looking for PCSC-card-reader support in Wine, I came across old mails from 2007. http://www.winehq.org/pipermail/wine-devel/2007-May/057052.html What's the current state of PCSC support in Wine? When I recently looked, winscard seemed full of

winscard: add pcsc-lite helpers for upcoming(?) implementation

2009-11-12 Thread Joerg-Cyril.Hoehle
Hi, looking for PCSC-card-reader support in Wine, I came across old mails from 2007. http://www.winehq.org/pipermail/wine-devel/2007-May/057052.html What's the current state of PCSC support in Wine? When I recently looked, winscard seemed full of stubs. OTOH, there's a company

Re: winscard: add pcsc-lite helpers for upcoming implementation (try 2)

2007-05-24 Thread Alexandre Julliard
Mounir IDRASSI [EMAIL PROTECTED] writes: +/* + * pcsc-lite functions pointers + */ +typedef LONG (*SCardEstablishContextPtr)(DWORD dwScope,LPCVOID pvReserved1, +LPCVOID pvReserved2, LPSCARDCONTEXT phContext); +typedef LONG (*SCardReleaseContextPtr)(SCARDCONTEXT hContext); +typedef

Re: winscard: add pcsc-lite helpers for upcoming implementation (try 2)

2007-05-24 Thread Mounir IDRASSI
Actually, pcsc-lite defines the same headers from PSDK with the same types for 32bit architecture. Including pcsclite headers will clash with wine's headers. The only possible modification is to redefine pcsclite types with different names but this is useless as they are the same as the ones in

Re: winscard: add pcsc-lite helpers for upcoming implementation (try 2)

2007-05-24 Thread Alexandre Julliard
Mounir IDRASSI [EMAIL PROTECTED] writes: Actually, pcsc-lite defines the same headers from PSDK with the same types for 32bit architecture. Including pcsclite headers will clash with wine's headers. The only possible modification is to redefine pcsclite types with different names but this is

Re: winscard: add pcsc-lite helpers for upcoming implementation

2007-05-23 Thread James Hawkins
On 5/23/07, Mounir IDRASSI [EMAIL PROTECTED] wrote: Hi, This patch adds helper variables and functions that exposes pcsc-lite functionalities for the use of the upcoming implementation. +/* loading entry points*/ +bSuccess = TRUE; +if (bSuccess +

re: winscard: add pcsc-lite helpers for upcoming implementation

2007-05-23 Thread Dan Kegel
James wrote: This would be a lot cleaner as: if (!(liteSCardEstablishContext = (SCardEstablishContextPtr) wine_dlsym(g_pcscliteHandle,SCardEstablishContext,szErr,sizeof(szErr))) { ERR(Failed to get SCardEstablishContext from pcsclite library. Error = %s\n,szErr); goto error; } I think

Re: winscard: add pcsc-lite helpers for upcoming implementation

2007-05-23 Thread Juan Lang
+BOOL InitializePCSCLite(void) You don't use the return value: @@ -42,9 +43,11 @@ BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { DisableThreadLibraryCalls(hinstDLL); WINSCARD_hModule = hinstDLL; +

Re: winscard: add pcsc-lite helpers for upcoming implementation

2007-05-23 Thread Mounir IDRASSI
Thanks for your comments Juan. Actually, the upcoming implementation checks the used function pointer at each call and returns an error if not assigned. Also in it, winscard always succeed to load even if pcsc-lite is not running. FYI, my first winscard patch contains an advanced stage of the

re: winscard: add pcsc-lite helpers for upcoming implementation

2007-05-23 Thread Mounir IDRASSI
The code is definitely cleaner with all your suggestions. I'm applying them now. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr James wrote: This would be a lot cleaner as: if (!(liteSCardEstablishContext = (SCardEstablishContextPtr)