Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread Detlef Riekenberg
Am Dienstag, den 17.01.2006, 14:18 -0600 schrieb James Hawkins: We generally have a policy of silence for the test suite unless a failure occurrs. Then we need to update many Tests, which do not respect this. Why do you need to output the version tested? I have a partial implemented

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread Jakob Eriksson
Detlef Riekenberg wrote: Am Dienstag, den 17.01.2006, 14:18 -0600 schrieb James Hawkins: We generally have a policy of silence for the test suite unless a failure occurrs. Then we need to update many Tests, which do not respect this. +1.

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread James Hawkins
On 1/18/06, Detlef Riekenberg [EMAIL PROTECTED] wrote: Am Dienstag, den 17.01.2006, 14:18 -0600 schrieb James Hawkins: We generally have a policy of silence for the test suite unless a failure occurrs. Then we need to update many Tests, which do not respect this. I agree, but that

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread Detlef Riekenberg
Am Mittwoch, den 18.01.2006, 13:28 -0600 schrieb James Hawkins: There is one case where I think it's leaning towards the OK side, though it still bugs me, and that is the advpack:GetVersionFromFile tests. This test is in the wrong File (file.c and tests/advpack.c). There's really no way

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread James Hawkins
On 1/18/06, Detlef Riekenberg [EMAIL PROTECTED] wrote: Am Mittwoch, den 18.01.2006, 13:28 -0600 schrieb James Hawkins: There is one case where I think it's leaning towards the OK side, though it still bugs me, and that is the advpack:GetVersionFromFile tests. This test is in the wrong

Re: winspool/tests: dump filename and version of the tested file

2006-01-17 Thread James Hawkins
On 1/17/06, Detlef Riekenberg [EMAIL PROTECTED] wrote: Changelog: - winspool/tests: dump filename and version of the tested file - use name for all includes We generally have a policy of silence for the test suite unless a failure occurrs. Why do you need to output the version tested