Re: [PATCH] remove CONFIG_ANDROID

2022-06-30 Thread Jason A. Donenfeld
Hi Kalesh, On Wed, Jun 29, 2022 at 09:25:32PM -0700, Kalesh Singh wrote: > On Wed, Jun 29, 2022 at 5:30 PM Jason A. Donenfeld wrote: > > > > Hey again, > > > > On Thu, Jun 30, 2022 at 2:24 AM Jason A. Donenfeld wrote: > > > 1) Introduce a simple CONFIG_PM_CONTINUOUS_AUTOSLEEPING Kconfig thing >

CONFIG_ANDROID

2022-06-30 Thread tlhackque
FWIW: Having watched the discussion about CONFIG_ANDROID, it occurs to me that there's an alternative for WireGuard that sidesteps the issue. From the last patcheset, it seems that the only use in WireGuard is to avoid clearing keys on every wake-up. So: Why not timestamp key-clear events, an

Re: CONFIG_ANDROID

2022-06-30 Thread Jason A. Donenfeld
On Thu, Jun 30, 2022 at 06:47:38AM -0400, tlhackque wrote: > FWIW: Having watched the discussion about CONFIG_ANDROID, it occurs to > me that there's an alternative for WireGuard that sidesteps the issue. > > From the last patcheset, it seems that the only use in WireGuard is to > avoid clearin

Re: CONFIG_ANDROID

2022-06-30 Thread tlhackque
On 30-Jun-22 07:41, Jason A. Donenfeld wrote: On Thu, Jun 30, 2022 at 06:47:38AM -0400, tlhackque wrote: FWIW: Having watched the discussion about CONFIG_ANDROID, it occurs to me that there's an alternative for WireGuard that sidesteps the issue. From the last patcheset, it seems that the onl

Re: CONFIG_ANDROID

2022-06-30 Thread Jason A. Donenfeld
On Thu, Jun 30, 2022 at 5:53 PM tlhackque wrote: > If you also want to make sure that the key isn't in memory longer than > that time (e.g. to avoid capture on a dump or device loss), you could > also set a timer (of the sort that wakes the CPU from sleep) that clears > the key at that time. Waki

Re: [PATCH] remove CONFIG_ANDROID

2022-06-30 Thread John Stultz
On Thu, Jun 30, 2022 at 3:06 AM Jason A. Donenfeld wrote: > On Wed, Jun 29, 2022 at 09:25:32PM -0700, Kalesh Singh wrote: > > Two concerns John raised: > > 1) Adding new ABI we need to maintain > > 2) Having unclear config options > > > > Another idea, I think, is to add the Kconfig option as

Re: [PATCH] remove CONFIG_ANDROID

2022-06-30 Thread Jason A. Donenfeld
Hi John, On Thu, Jun 30, 2022 at 10:12:30AM -0700, John Stultz wrote: > Does this preference come out of the too-many-options-in-gpg > antipattern? Or is there something else? There are numerous presentations and threads galore on why WireGuard doesn't do knobs. Not worth rehashing here; it's not

[PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Kalesh Singh
Systems that initiate frequent suspend/resume from userspace can make the kernel aware by enabling PM_USERSPACE_AUTOSLEEP config. This allows for certain sleep-sensitive code (wireguard/rng) to decide on what preparatory work should be performed (or not) in their pm_notification callbacks. This p

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Jason A. Donenfeld
Hi Kalesh, On Thu, Jun 30, 2022 at 07:12:29PM +, Kalesh Singh wrote: > Systems that initiate frequent suspend/resume from userspace > can make the kernel aware by enabling PM_USERSPACE_AUTOSLEEP > config. > > This allows for certain sleep-sensitive code (wireguard/rng) to > decide on what pre

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Kalesh Singh
On Thu, Jun 30, 2022 at 12:49 PM Jason A. Donenfeld wrote: > > Hi Kalesh, > > On Thu, Jun 30, 2022 at 07:12:29PM +, Kalesh Singh wrote: > > Systems that initiate frequent suspend/resume from userspace > > can make the kernel aware by enabling PM_USERSPACE_AUTOSLEEP > > config. > > > > This all

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Jason A. Donenfeld
On Thu, Jun 30, 2022 at 01:41:40PM -0700, Kalesh Singh wrote: > Our latest supported kernels in Android are based on 5.15 so the > config change isn't yet needed. Once there are newer versions with the > CONFIG_ANDROID removed I will add this to the defconfig. Okay. It might be still worth getting

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Kalesh Singh
On Thu, Jun 30, 2022 at 2:14 PM Jason A. Donenfeld wrote: > > On Thu, Jun 30, 2022 at 01:41:40PM -0700, Kalesh Singh wrote: > > Our latest supported kernels in Android are based on 5.15 so the > > config change isn't yet needed. Once there are newer versions with the > > CONFIG_ANDROID removed I w

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

2022-06-30 Thread Jason A. Donenfeld
Hi Kalesh, On Thu, Jun 30, 2022 at 03:02:46PM -0700, Kalesh Singh wrote: > I've uploaded the changes on android-mainline [1]. We'll submit there > once the upstream changes are finalized. > > [1] https://android-review.googlesource.com/c/kernel/common/+/2142693/1 Excellent. I think everything is