Fwd: WireGuard Mailling List

2023-07-19 Thread Dmitry Vyukov
Hi, I was asked to forward this to the list because the author has problems reaching it. It looks legit: -- Forwarded message - From: Marek Küthe Hello, the WireGuard logo is a Chinese dragon. Does he/she have a name? What could you call him/her? The background is that I want

Re: [syzbot] [wireguard?] KASAN: slab-use-after-free Write in enqueue_timer

2023-05-24 Thread Dmitry Vyukov
On Tue, 23 May 2023 at 19:07, 'Eric Dumazet' via syzkaller-bugs wrote: > > On Tue, May 23, 2023 at 7:05 PM Eric Dumazet wrote: > > > > On Tue, May 23, 2023 at 7:01 PM Jason A. Donenfeld wrote: > > > > > > On Tue, May 23, 2023 at 09:47:36AM -0700, Jakub Kicinski wrote: > > > > On Tue, 23 May

Re: [syzbot] BUG: MAX_LOCKDEP_KEYS too low! (2)

2022-11-08 Thread Dmitry Vyukov
On Tue, 8 Nov 2022 at 05:40, syzbot wrote: > > syzbot has found a reproducer for the following issue on: > > HEAD commit:3577a7611842 Merge branches 'for-next/acpi', 'for-next/kbu.. > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > for-kernelci > console

Re: [syzbot] BUG: MAX_LOCKDEP_KEYS too low! (2)

2021-05-21 Thread Dmitry Vyukov
On Thu, May 20, 2021 at 7:02 AM Tetsuo Handa wrote: > > On 2021/05/20 5:09, Dmitry Vyukov wrote: > > On Wed, May 19, 2021 at 9:58 PM Randy Dunlap wrote: > >> > >> On 5/19/21 12:48 PM, Dmitry Vyukov wrote: > >>> On Wed, May 19, 2021 at 7:35 P

Re: [syzbot] BUG: MAX_LOCKDEP_KEYS too low! (2)

2021-05-19 Thread Dmitry Vyukov
On Wed, May 19, 2021 at 9:58 PM Randy Dunlap wrote: > > On 5/19/21 12:48 PM, Dmitry Vyukov wrote: > > On Wed, May 19, 2021 at 7:35 PM syzbot > > wrote: > >> > >> Hello, > >> > >> syzbot found the following issue on: > >> > >

Re: [PATCH RFC v1] wireguard: queueing: get rid of per-peer ring buffers

2021-02-09 Thread Dmitry Vyukov
On Tue, Feb 9, 2021 at 4:44 PM Jason A. Donenfeld wrote: > > Hi Dmitry, > > Thanks for the review. > > On Tue, Feb 9, 2021 at 9:24 AM Dmitry Vyukov wrote: > > Strictly saying, 0.15% is for delaying the newly added item only. This > > is not a problem, we c

Re: [PATCH RFC v1] wireguard: queueing: get rid of per-peer ring buffers

2021-02-09 Thread Dmitry Vyukov
do a CAS loop on enqueued. Since any modifications to dequeued can only lead to reduction of size, we don't need to double check it before CAS, thus the CAS loop should provide a precise upper bound on size. Or, we could check, opportunistically increment, and then decrement if overflow, but that look

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-12 Thread Dmitry Vyukov
On Mon, Jan 11, 2021 at 7:15 PM Jeffrey Walton wrote: > > > > ... > > > > FTR, I've disabled the following UBSAN configs: > > > > UBSAN_MISC > > > > UBSAN_DIV_ZERO > > > > UBSAN_BOOL > > > > UBSAN_OBJECT_SIZE > > > > UBSAN_SIGNED_OVERFLOW > > > > UBSAN_UNSIGNED_OVERFLOW > > > > UBSAN_ENUM > > > >

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-11 Thread Dmitry Vyukov
On Mon, Jan 11, 2021 at 6:35 PM Jeffrey Walton wrote: > > On Mon, Jan 11, 2021 at 12:20 PM Dmitry Vyukov wrote: > > ... > > FTR, I've disabled the following UBSAN configs: > > UBSAN_MISC > > UBSAN_DIV_ZERO > > UBSAN_BOOL > > UBSAN_OBJECT_SIZE > > U

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-11 Thread Dmitry Vyukov
On Sat, Jan 9, 2021 at 10:46 AM Dmitry Vyukov wrote: > > On Fri, Jan 8, 2021 at 9:26 PM Kees Cook wrote: > >> On Thu, Jan 7, 2021 at 8:00 PM Jason A. Donenfeld wrote: > >> > > > > >> > > > Hi Dmitry, > >> > > > > &g

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-09 Thread Dmitry Vyukov
On Fri, Jan 8, 2021 at 9:26 PM Kees Cook wrote: >> On Thu, Jan 7, 2021 at 8:00 PM Jason A. Donenfeld wrote: >> > > > >> > > > Hi Dmitry, >> > > > >> > > > On Mon, Dec 21, 2020 at 10:14 AM Dmitry Vyukov >> &g

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-08 Thread Dmitry Vyukov
On Thu, Jan 7, 2021 at 8:06 PM Jeffrey Walton wrote: > > On Thu, Jan 7, 2021 at 2:03 PM Jason A. Donenfeld wrote: > > > > On Thu, Jan 7, 2021 at 1:22 PM Dmitry Vyukov wrote: > > > > > > On Mon, Dec 21, 2020 at 12:23

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-08 Thread Dmitry Vyukov
On Thu, Jan 7, 2021 at 8:00 PM Jason A. Donenfeld wrote: > > > > > > Hi Dmitry, > > > > > > On Mon, Dec 21, 2020 at 10:14 AM Dmitry Vyukov wrote: > > > > Hi Jason, > > > > > > > > Thanks for looking into this. > > &g

Re: UBSAN: object-size-mismatch in wg_xmit

2020-12-21 Thread Dmitry Vyukov
On Sun, Dec 20, 2020 at 10:11 PM Jason A. Donenfeld wrote: > Hmm, on first glance, I'm not sure I'm seeing the bug: > > On Sun, Dec 20, 2020 at 5:54 PM syzbot > wrote: > > UBSAN: object-size-mismatch in ./include/linux/skbuff.h:2021:28 > > member access within address 85889cc2 with

Re: syzkaller wireguard key situation [was: Re: [PATCH net-next v2] net: WireGuard secure network tunnel]

2020-02-20 Thread Dmitry Vyukov
On Thu, Feb 20, 2020 at 5:34 PM Jason A. Donenfeld wrote: > > Hi Dmitry, > > On Thu, Feb 20, 2020 at 5:14 PM Dmitry Vyukov wrote: > > I got some coverage in wg_netdevice_notification: > > https://imgur.com/a/1sJZKtp > > > > Or you mean the parts that are st

Re: syzkaller wireguard key situation [was: Re: [PATCH net-next v2] net: WireGuard secure network tunnel]

2020-02-20 Thread Dmitry Vyukov
On Wed, Feb 19, 2020 at 11:23 AM Jason A. Donenfeld wrote: > > On Tue, Feb 18, 2020 at 11:00 AM Dmitry Vyukov wrote: > > I've added descriptions for wireguard packets: > > https://github.com/google/syzkaller/commit/012fbc3229ebef871a201ea431b16610e6e0d345 > > It give

Re: syzkaller wireguard key situation [was: Re: [PATCH net-next v2] net: WireGuard secure network tunnel]

2020-02-18 Thread Dmitry Vyukov
On Mon, Feb 17, 2020 at 8:24 PM Dmitry Vyukov wrote: > > On Mon, Feb 17, 2020 at 4:42 PM Dmitry Vyukov wrote: > > > > > > > > Observation: > > > > > > > > It seems to be starting to synthesize packets sent to the wireguard > > >

Re: syzkaller wireguard key situation [was: Re: [PATCH net-next v2] net: WireGuard secure network tunnel]

2020-02-17 Thread Dmitry Vyukov
On Mon, Feb 17, 2020 at 4:42 PM Dmitry Vyukov wrote: > > > > > > Observation: > > > > > > It seems to be starting to synthesize packets sent to the wireguard > > > socket. These aren't the proper handshake packets generated internally > > > b

Re: syzkaller wireguard key situation [was: Re: [PATCH net-next v2] net: WireGuard secure network tunnel]

2020-02-17 Thread Dmitry Vyukov
On Mon, Feb 17, 2020 at 4:19 PM Dmitry Vyukov wrote: > > On Mon, Feb 17, 2020 at 12:44 PM Jason A. Donenfeld wrote: > > > > Observation: > > > > It seems to be starting to synthesize packets sent to the wireguard > > socket. These aren't the proper ha

Re: syzkaller wireguard key situation [was: Re: [PATCH net-next v2] net: WireGuard secure network tunnel]

2020-02-17 Thread Dmitry Vyukov
On Mon, Feb 17, 2020 at 12:44 PM Jason A. Donenfeld wrote: > > Observation: > > It seems to be starting to synthesize packets sent to the wireguard > socket. These aren't the proper handshake packets generated internally > by that triangle commit, but rather ones that syzkaller creates > itself.

Re: syzkaller wireguard key situation [was: Re: [PATCH net-next v2] net: WireGuard secure network tunnel]

2020-02-17 Thread Dmitry Vyukov
On Tue, Feb 4, 2020 at 10:39 PM Jason A. Donenfeld wrote: > > Hey Dmitry, > > I see you got wireguard's netlink stuff hooked up to syzkaller. > Excellent work, and thanks! It's already finding bugs. > > Right now it seems to know about 5 different keys you've come up with, > and not much in the