Re: [PATCH] wireguard: Fix leaking sockets in wg_socket_init error paths

Hi, The signed-off-by is missing and the subject does not match the format of any other wireguard commits. On Mon, Oct 23, 2023 at 03:06:09PM +0200, Daniel Gröber wrote: > This doesn't seem to be reachable normally, but while working on a patch "Normally" as in what? At all? Or? > for the

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

@lists.infradead.org > Cc: Arnd Bergmann > Cc: Jason A. Donenfeld > Cc: wireguard@lists.zx2c4.com > Cc: linux-a...@vger.kernel.org > Cc: linux-snps-...@lists.infradead.org > Cc: Vineet Gupta > Cc: Brian Cain > Cc: linux-hexa...@vger.kernel.org > Cc: Greg Ungerer >

Re: What's the wireguard-tools

Hi Hangbin, On Thu, Aug 10, 2023 at 11:51:35AM +0800, Hangbin Liu wrote: > Hi Jason, > > I'm maintaining the RHEL wireguard-tools rpm. Recently, There is a request to > convert the license tag in the spec file to SPDX format[1]. The current > License > tag in wireguard-tools spec file is GPLv2,

Re: WireGuard Mailling List

On 7/23/23, Wang Jian wrote: > Hi, > > I don't know the origin of the Wireguard logo, but it seems to be a 蛟 > (Jiao, pronounced j-ee-au), not a 龙 (Long) > > The differences between Long (know as Chinese dragon) and Jiao is > * Jiao has 2 small straight horns or no horn at all while Long has 2

Re: [syzbot] [wireguard?] [jfs?] KASAN: slab-use-after-free Read in wg_noise_keypair_get

Freed in: diUnmount+0xf3/0x100 fs/jfs/jfs_imap.c:195 jfs_umount+0x186/0x3a0 fs/jfs/jfs_umount.c:63 jfs_put_super+0x8a/0x190 fs/jfs/super.c:194 So maybe not a wg issue?

Re: Fwd: RCU stalls with wireguard over bonding over igb on Linux 6.3.0+

On Sun, Jul 02, 2023 at 03:46:38PM +0200, Jason A. Donenfeld wrote: > I've got an overdue patch that I still need to submit to netdev, which > I suspect might actually fix this. > > Can you let me know if > https://git.zx2c4.com/wireguard-linux/patch/?id=54d5e4329efe0d1dba8b4a587

Re: Fwd: RCU stalls with wireguard over bonding over igb on Linux 6.3.0+

I've got an overdue patch that I still need to submit to netdev, which I suspect might actually fix this. Can you let me know if https://git.zx2c4.com/wireguard-linux/patch/?id=54d5e4329efe0d1dba8b4a58720d29493926bed0 solves the problem? Jason

Re: [syzbot] [wireguard?] KASAN: slab-use-after-free Write in enqueue_timer

On Tue, May 23, 2023 at 07:16:20PM +0200, Jason A. Donenfeld wrote: > On Tue, May 23, 2023 at 06:47:41PM +0200, Jason A. Donenfeld wrote: > > On Tue, May 23, 2023 at 6:46 PM Jakub Kicinski wrote: > > > > > > On Tue, 23 May 2023 18:14:18 +0200 Jason A. Donen

Re: [syzbot] [wireguard?] KASAN: slab-use-after-free Write in enqueue_timer

On Tue, May 23, 2023 at 06:47:41PM +0200, Jason A. Donenfeld wrote: > On Tue, May 23, 2023 at 6:46 PM Jakub Kicinski wrote: > > > > On Tue, 23 May 2023 18:14:18 +0200 Jason A. Donenfeld wrote: > > > So, IOW, not a wireguard bug, right? > > > > What's slightly

Re: [syzbot] [wireguard?] KASAN: slab-use-after-free Write in enqueue_timer

On Tue, May 23, 2023 at 09:47:36AM -0700, Jakub Kicinski wrote: > On Tue, 23 May 2023 18:42:53 +0200 Jason A. Donenfeld wrote: > > > It should, no idea why it isn't. Looking thru the code now I don't see > > > any obvious gaps where timer object is on a list but not active :S

Re: [syzbot] [wireguard?] KASAN: slab-use-after-free Write in enqueue_timer

On Tue, May 23, 2023 at 6:46 PM Jakub Kicinski wrote: > > On Tue, 23 May 2023 18:14:18 +0200 Jason A. Donenfeld wrote: > > So, IOW, not a wireguard bug, right? > > What's slightly concerning is that there aren't any other timers > leading to > > KASAN: slab-use-after-

Re: [syzbot] [wireguard?] KASAN: slab-use-after-free Write in enqueue_timer

On Tue, May 23, 2023 at 6:41 PM Jakub Kicinski wrote: > > On Tue, 23 May 2023 18:12:32 +0200 Eric Dumazet wrote: > > > Your timer had the pleasure of getting queued _after_ a dead watchdog > > > timer, no? IOW it tries to update the ->next pointer of a queued > > > watchdog timer. We should

Re: [syzbot] [wireguard?] KASAN: slab-use-after-free Write in enqueue_timer

On Tue, May 23, 2023 at 09:05:12AM -0700, Jakub Kicinski wrote: > On Tue, 23 May 2023 17:46:20 +0200 Jason A. Donenfeld wrote: > > > Freed by task 41: > > > __kmem_cache_free+0x264/0x3c0 mm/slub.c:3799 > > > device_release+0x95/0x1c0 > > > ko

Re: [syzbot] [wireguard?] KASAN: slab-use-after-free Write in enqueue_timer

Hey Syzkaller & Netdev folks, I've been looking at this a bit and am slightly puzzled. At first I saw this: > enqueue_timer+0xad/0x560 kernel/time/timer.c:605 > internal_add_timer kernel/time/timer.c:634 [inline] > __mod_timer+0xa76/0xf40 kernel/time/timer.c:1131 > mod_peer_timer+0x158/0x220

Re: [PATCH] wg-quick: Allow setting iface VRF in PreUp hook

Applied, thanks.

Re: [bug] No keep-alives sent when private is set via PostUp

On Thu, May 18, 2023 at 3:17 AM Jason A. Donenfeld wrote: > Until this patch hits stable kernels, you can probably work around > this by changing your PostUp into a PreUp. I adjusted the man page > here: > > https://git.zx2c4.com/wireguard-tools/commit/?id=9d42bd1ab9d707f7a72162d36

Re: [bug] No keep-alives sent when private is set via PostUp

Hi Maxim, Thanks for the bug report! I think indeed you're right about this. Can you test if this commit fixes the issue for you? https://git.zx2c4.com/wireguard-linux/commit/?id=3ac1bf099766f1e9735883d5127148054cd5b30a It at least satisfies the test case I added. Until this patch hits stable

Re: APK outside of Play Store?

On Wed, Sep 21, 2022 at 04:09:56AM +, wiregu...@bulletin.elitemail.org wrote: > For users who prefer to avoid Play Store as a delivery channel, is > there an official pre-built APK available? Such users are typically > steered towards APKPure/APKMirror/F-Droid with questionabl > authenticity

Direct APKs for WireGuard Android are now available

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi folks, By popular demand, on , there's now a (somewhat small) link in the Android section called "Download APK File", for those who want to sideload the package or bundle it in an OS image or whatever else.

Re: Linux counter_validate() RFC6479 replay detection modifies bitmap before authentication?

On 4/20/23, Leon Woestenberg wrote: > Hello all, > > I am trying to understand a few details in WireGuard protocol, looking > at the Linux kernel WireGuard implementation if I am unsure about the > description from the paper. One question I have: > > Does counter_validate() in the receive path

Android Reproducible Builds & Signing Key Changes

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi folks, The WireGuard Android app can now be reproducibly built, so that its contents can be publicly verified. The F-Droid project now does this verification, by comparing their build of WireGuard to the build that the WireGuard project

Re: Nw Android version crashes on Android TV / Google TV

The fix has now been released by Google, so just update and the crash will go away.

Re: Possible regression between 5.18.2 and 6.2.1

Hi Dan, Hard to imagine that this is a WireGuard bug, but more likely something having to do with SNAT or something. What is the unallowed src IP when you get that error? Can you debug further? Maybe bisect a bit? Otherwise, not much I can do. The diff between those versions you listed is

Re: Nw Android version crashes on Android TV / Google TV

Or if you can't wait for the update approval, here's the Play Store-signed APK: https://data.zx2c4.com/wireguard-496-81ed97b6-5d27-466d-a966-f3c7b498ffdb-delete-me-in-two-weeks.apk

Re: Nw Android version crashes on Android TV / Google TV

Already fixed and just waiting on Google to approve the app: https://git.zx2c4.com/wireguard-android/commit/?id=b734f44200c40fb630fbc566dd245693145f93ec

[PATCH wireguard-go] conn: fix StdNetEndpoint data race by dynamically allocating endpoints

m. Reported-by: lsc Link: https://lore.kernel.org/wireguard/ac87f86f-6837-4e0e-ec34-1df35f525...@lv6.tw/ Fixes: 9e2f386 ("conn, device, tun: implement vectorized I/O on Linux") Cc: Josh Bleecher Snyder Reviewed-by: James Tucker Signed-off-by: Jordan Whited Signed-off-by: Jason A. Donenfe

Re: wireguard-go: data race introduced in recent commit 9e2f386

Thanks for the panic trace. That indeed looks like the same issue as the race. Jordan has a stop-gap patch prepared, which I'll send to the list. Jason

[PATCH android] ui: set selected tunnel after creating fragments

I'm not sure why that comment (Samuel's) was there saying it was necessary. Given it's been async for a long while, this wasn't guaranteed anyway. So let's get rid of it and see what happens. Screen rotation seems fine thus far. Cc: Samuel Holland Signed-off-by: Jason A. Donenfeld --- Samuel

Re: [PATCH 5/5] cpumask: fix comment of cpumask_xxx

On Mon, Mar 6, 2023 at 5:54 PM Yury Norov wrote: > > On Mon, Mar 06, 2023 at 05:44:41PM +0100, Jason A. Donenfeld wrote: > > On Mon, Mar 6, 2023 at 5:39 PM Yury Norov wrote: > > > > > > On Tue, Mar 07, 2023 at 12:06:51AM +0800, Vernon Yang wrote: > > > &g

Re: [PATCH 5/5] cpumask: fix comment of cpumask_xxx

On Mon, Mar 6, 2023 at 5:39 PM Yury Norov wrote: > > On Tue, Mar 07, 2023 at 12:06:51AM +0800, Vernon Yang wrote: > > After commit 596ff4a09b89 ("cpumask: re-introduce constant-sized cpumask > > optimizations"), the cpumask size is divided into three different case, > > so fix comment of

Re: Fw: [Bug 217054] New: wireguard - allowedips.c - warning: the frame size of 1032 bytes is larger than 1024 bytes

On Sat, Feb 18, 2023 at 09:50:36AM -0800, Stephen Hemminger wrote: > > > Begin forwarded message: > > Date: Sat, 18 Feb 2023 15:49:26 + > From: bugzilla-dae...@kernel.org > To: step...@networkplumber.org > Subject: [Bug 217054] New: wireguard - allowedips.c - warning: the frame size > of

Re: [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck'

No idea if this is something intended for me to apply or if it's an automated email. Fix the formatting, resend, and then maybe I'll apply it?

Re: Noise Protocol Question

On Sat, Feb 11, 2023 at 03:39:12PM +, z wrote: > TL;DR Why is wireguard go not calling isZero() on the output of the ECDH key > agreement every time? Good question. AFAICT, this was something I had noticed back when this code was in development, but then zero checking only got added to the

Re: [PATCH] wg: Fix show all endpoints output

Applied, thanks. https://git.zx2c4.com/wireguard-tools/commit/?id=b4f6b4f229d291daf7c35c6f1e7f4841cc6d69bc

Re: Allow client-side encrypted backups for Android app

I think I'd prefer to still keep this a bit more locked down. There is the "export tunnels as zip" feature (which requires an explicit authentication step each time), which you can use for backup/restore. Jason

Re: [PATCH] wg: Fix show all endpoints output

Thanks. Can you send this with a `Signed-off-by:` line like every commit in that repository does, please? Then I'll apply this. Jason

Re: [PATCH] handle a network adapter ending in a space character

Thanks. Can you send this with a `Signed-off-by:` line like every commit in that repository does, please? Then I'll apply this. Jason

Re: [PATCH] wg-tools: Fix too strict file permissions on resolv.conf

Thanks. Can you send this with a `Signed-off-by:` line like every commit in that repository does, please? Then I'll apply this. Jason

Re: [PATCH v2] wireguard (gcc13): move ULLs limits away from enum

I have this queued up already as: https://git.zx2c4.com/wireguard-linux/commit/?id=3d9d8bba03db21f3276324cdba43c82be5d60729 I liked this variant better. Jason

Re: Wireguard iOS crashes after upgrading to XCode 14

On Mon, Dec 5, 2022 at 6:15 PM Houman wrote: > > Hi Jason, > > I was wondering if there are still any plans to focus on the Apple > development and bring the repo more up-to-date, please. > > Since the latest major development on the Wireguard Linux repo seems > to have finished by 31st October,

Re: Wireguard on Asahi Debian

On Thu, Dec 01, 2022 at 01:24:07PM +0100, Daniel wrote: > Hi All, > > I installed Asahi/Debian Bookworm from > > https://git.zerfleddert.de/cgi-bin/gitweb.cgi/m1-debian/ > > and face a problem: installing wireguard shipped the Debian arm kernel > and I can't get wg to work. > > Is there a

Re: [PATCH] wireguard (gcc13): cast enum limits members to int in prints

Hi Jiri, On Mon, Oct 31, 2022 at 12:44:24PM +0100, Jiri Slaby (SUSE) wrote: > Since gcc13, each member of an enum has the same type as the enum [1]. And > that is inherited from its members. Provided "REKEY_AFTER_MESSAGES = 1ULL > << 60", the named type is unsigned long. > > This generates

Re: [PATCH] wg: freebsd: move if_wg path to reflect new in-tree location

https://git.zx2c4.com/wireguard-tools/commit/?id=7b2ae7aa2f52fbac65874a641cbfbb0182d0ba46 Applied, thanks! (Very excited about all this...) Jason

Re: APK outside of Play Store?

On Sun, Oct 02, 2022 at 03:03:51AM +, wiregu...@bulletin.elitemail.org wrote: > F-Droid builds on EOL Debian Stretch using an outdated toolchain and > dependencies is not the way. An official build on a supported non-EOL > OS signed by first-party development is. Is there actually something

Re: Iptables WireGuard obfuscation extension

Hey Wei, On Sat, Sep 10, 2022 at 06:34:42AM -0500, Wei Chen wrote: > Hi, > > Jason once suggested use a netfilter module for obfuscation[1]. Here is one. > > https://github.com/infinet/xt_wgobfs > > It uses SipHash 1-2 to generate pseudo-random numbers in a reproducible way. > Sender and

Re: MacOS app update needed

On Thu, Sep 22, 2022 at 03:26:11PM +0200, Bruno wrote: > We also had a constructive chat in November (with Diab Neiroukh) on this > list. You made an appreciated change, but the question remained opened. The change from that discussion is in 0.5.3:

Re: MacOS app update needed

On Wed, Sep 21, 2022 at 9:31 AM Simon Karberg wrote: > > Hi, > > I've been testing the Domain Search functionality on all 3 OS' > (Windows, Mac & Linux) and the setting: > > DNS=, > Is only being applied on Windows & Linux. > > Further testing on MacOS I've found that the homebrew installation

Re: MacOS app update needed

On Wed, Sep 21, 2022 at 10:22 AM Bruno wrote: > > Hi, > > Windows Client project don't feel alive either. Last commit has 6 months > and last release is 9 month old. > > Same, here https://git.zx2c4.com/wireguard-windows/log/ and here > https://github.com/WireGuard/wireguard-windows > > Version

Re: MacOS app update needed

On Thu, Sep 22, 2022 at 1:32 PM Harald Dunkel wrote: > Maybe Apple would include wireguard into MacOS' kernel as well, > if there is sufficient demand for this feature? Make I offered to do a kernel implementation for them, but they never got back to me.

Re: MacOS app update needed

On Wed, Sep 21, 2022 at 9:55 AM Houman wrote: > > Hi Simon, > > Not only that, even the repo > https://github.com/WireGuard/wireguard-apple hasn't been updated since > 27 Sep 2021. > There are a number of useful contributions in the form of pull > requests waiting there to be approved for over 8

Re: Wireguard iOS crashes after upgrading to XCode 14

On 9/22/22, Houman wrote: > Hi Andrej, > > It works, well done! > > A strange thing though, before your patch I was still able to connect > to the VPN server, if I changed the schema to Release instead of > Debug. Now with your patch it also works under Debug schema, which is > fantastic. > What

Re: [syzbot] linux-next test error: WARNING in set_peer

I think I'll open code it like below. I'll include this in my next push to net. >From 19fb26af00a8266df65b706dc02727c6a608b1b6 Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Wed, 14 Sep 2022 18:42:00 +0100 Subject: [PATCH] wireguard: netlink: avoid variable-sized memcp

Re: FreeBSD current socket-src changed. Wireguard not compiling.

On Sun, Sep 4, 2022 at 7:07 PM Jason A. Donenfeld wrote: > > Hi Ed, > > On Wed, Aug 31, 2022 at 8:18 PM Ed Maste wrote: > > > > On Mon, 29 Aug 2022 at 12:18, Jason A. Donenfeld wrote: > > > On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote: >

Re: FreeBSD current socket-src changed. Wireguard not compiling.

Hi Ed, On Wed, Aug 31, 2022 at 8:18 PM Ed Maste wrote: > > On Mon, 29 Aug 2022 at 12:18, Jason A. Donenfeld wrote: > > On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote: > > > Tonight after updating kernel freebsd current I got coredump with > > > w

Re: [PATCH net-next] genetlink: start to validate reserved header bytes

Hi Jakub, On Wed, Aug 24, 2022 at 05:18:30PM -0700, Jakub Kicinski wrote: > diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlink.c > index d0f3b6d7f408..0c0644e762e5 100644 > --- a/drivers/net/wireguard/netlink.c > +++ b/drivers/net/wireguard/netlink.c > @@ -621,6 +621,7

Re: FreeBSD current socket-src changed. Wireguard not compiling.

On Tue, Aug 23, 2022 at 12:26:21PM +0300, Michael Pro wrote: > Tonight after updating kernel freebsd current I got coredump with > wireguard enabled kernel module. > > As is > https://reviews.freebsd.org/D36232 > D36232 protosw: refactor protosw and domain static declaration and > load

Re: [PATCH wireguard-go] tun/netstack: bump to latest gvisor

Hi Shengjing, Thanks for the patch. I'll apply this. But one question: On Fri, Aug 19, 2022 at 01:27:28AM +0800, Shengjing Zhu wrote: > dev := { > + ep: channel.New(1024, uint32(mtu), ""), How did you come up with 1024 here? And more generally, how's performance

Re: Random arrays on kernel stack..

Hey Linus, On Thu, Jul 28, 2022 at 04:51:58PM -0700, Linus Torvalds wrote: > So I finally have an arm64 laptop that I'm playing with, and as a Some intrepid diving into Asahi world, eh? I admit that after playing with the M1 and benching/optimizing some code on it, I wasn't man enough to daily

Re: [PATCH] wireguard: selftests: update config fragments

Hi Lukas, Thanks for researching this! I'll apply this to my wireguard tree and send it up to netdev during my next push. https://git.zx2c4.com/wireguard-linux/commit/?id=6da997932c4d4cb41c4a35d5541d0e4e1154fdb7 Jason

Re: [PATCH] wireguard: Kconfig: select CRYPTO_CHACHA_S390

Hi Vlad, On Tue, Jul 05, 2022 at 02:07:40PM +0200, Vlad Dronov wrote: > Whoa, that's... funny. Honestly, I was always wondering why CRYPTO_CHACHA_S390 > and friends live in drivers/crypto/Kconfig. Now I know why. Well... now you know that somebody else thought it was strange too. But not quite

Re: [PATCH] wireguard: Kconfig: select CRYPTO_CHACHA_S390

On Tue, Jul 05, 2022 at 02:49:19AM +0200, Jason A. Donenfeld wrote: > Hi Vladis, > > On Mon, Jul 04, 2022 at 09:15:35PM +0200, Vladis Dronov wrote: > > Select the new implementation of CHACHA20 for S390 when available, > > it is faster than the generic software implementati

Re: [PATCH] wireguard: Kconfig: select CRYPTO_CHACHA_S390

Hi Vladis, On Mon, Jul 04, 2022 at 09:15:35PM +0200, Vladis Dronov wrote: > Select the new implementation of CHACHA20 for S390 when available, > it is faster than the generic software implementation. > > Reported-by: kernel test robot > Link: >

Re: [PATCH] remove CONFIG_ANDROID

Hi Jon, On Fri, Jul 01, 2022 at 02:22:38PM -0600, Jonathan Corbet wrote: > So please forgive the noise from the peanut gallery Yuh oh, I sure hope this isn't newsworthy for LWN. This has already consumed me for two days... > myself wondering...do you really need a knob for this? The kernel >

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

Hi Kalesh, On Thu, Jun 30, 2022 at 03:02:46PM -0700, Kalesh Singh wrote: > I've uploaded the changes on android-mainline [1]. We'll submit there > once the upstream changes are finalized. > > [1] https://android-review.googlesource.com/c/kernel/common/+/2142693/1 Excellent. I think everything

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

On Thu, Jun 30, 2022 at 01:41:40PM -0700, Kalesh Singh wrote: > Our latest supported kernels in Android are based on 5.15 so the > config change isn't yet needed. Once there are newer versions with the > CONFIG_ANDROID removed I will add this to the defconfig. Okay. It might be still worth

Re: [PATCH] pm/sleep: Add PM_USERSPACE_AUTOSLEEP Kconfig

/20220629150102.1582425-1-...@lst.de/ > > Suggested-by: Jason A. Donenfeld > Signed-off-by: Kalesh Singh Thanks, looks good to me. Do you have a corresponding Gerrit link to the change adding this to the base Android kernel config? If so, have my Ack: Acked-by: Jason A. Donenfeld Jason

Re: [PATCH] remove CONFIG_ANDROID

Hi John, On Thu, Jun 30, 2022 at 10:12:30AM -0700, John Stultz wrote: > Does this preference come out of the too-many-options-in-gpg > antipattern? Or is there something else? There are numerous presentations and threads galore on why WireGuard doesn't do knobs. Not worth rehashing here; it's

Re: CONFIG_ANDROID

On Thu, Jun 30, 2022 at 5:53 PM tlhackque wrote: > If you also want to make sure that the key isn't in memory longer than > that time (e.g. to avoid capture on a dump or device loss), you could > also set a timer (of the sort that wakes the CPU from sleep) that clears > the key at that time.

Re: CONFIG_ANDROID

On Thu, Jun 30, 2022 at 06:47:38AM -0400, tlhackque wrote: > FWIW: Having watched the discussion about CONFIG_ANDROID, it occurs to > me that there's an alternative for WireGuard that sidesteps the issue. > > From the last patcheset, it seems that the only use in WireGuard is to > avoid

Re: [PATCH] remove CONFIG_ANDROID

Hi Kalesh, On Wed, Jun 29, 2022 at 09:25:32PM -0700, Kalesh Singh wrote: > On Wed, Jun 29, 2022 at 5:30 PM Jason A. Donenfeld wrote: > > > > Hey again, > > > > On Thu, Jun 30, 2022 at 2:24 AM Jason A. Donenfeld wrote: > > > 1) Introduce a simple CONFIG_PM_C

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 06:44:14PM -0700, Joe Perches wrote: > On Thu, 2022-06-30 at 02:50 +0200, Jason A. Donenfeld wrote: > > On Wed, Jun 29, 2022 at 05:36:57PM -0700, Joe Perches wrote: > > > > > +static ssize_t pm_userspace_autosleeper_s

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 05:36:57PM -0700, Joe Perches wrote: > > > +static ssize_t pm_userspace_autosleeper_show(struct kobject *kobj, > > > + struct kobj_attribute *attr, char *buf) > > > +{ > > > + return sprintf(buf, "%d\n", pm_userspace_autosleeper_enabled);

Re: [PATCH] remove CONFIG_ANDROID

Hey again, On Thu, Jun 30, 2022 at 2:24 AM Jason A. Donenfeld wrote: > 1) Introduce a simple CONFIG_PM_CONTINUOUS_AUTOSLEEPING Kconfig thing >with lots of discouraging help text. > > 2) Go with the /sys/power tunable and bikeshed the naming of that a bit >to get

Re: [PATCH] remove CONFIG_ANDROID

Hi John, On Wed, Jun 29, 2022 at 04:52:05PM -0700, John Stultz wrote: > Jason: Thanks for raising this issue and sharing this patch to avoid > breakage! I really appreciate it. > > My only concern with this change introducting a userspace knob set at > runtime, vs a (hopefully more specific than

Re: [PATCH] remove CONFIG_ANDROID

Hi Kalesh, On Wed, Jun 29, 2022 at 03:26:33PM -0700, Kalesh Singh wrote: > Thanks for taking a look. I'm concerned holding the sys/power/state > open would have unintentional side effects. Adding the > /sys/power/userspace_autosuspender seems more appropriate. We don't > have a use case for the

Re: [PATCH] remove CONFIG_ANDROID

Hi Kalesh, On Wed, Jun 29, 2022 at 12:05:23PM -0700, Kalesh Singh wrote: > Thanks for raising this. > > Android no longer uses PM_AUTOSLEEP, is correct. libsuspend is > also now deprecated. Android autosuspend is initiatiated from the > userspace system suspend service [1]. > > A runtime config

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 07:35:45PM +0200, Christoph Hellwig wrote: > On Wed, Jun 29, 2022 at 07:30:35PM +0200, Jason A. Donenfeld wrote: > > Properly resolved by whom? It sounds like you're up for intentionally > > allowing a userspace regression, and also volunteering other pe

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 06:38:09PM +0200, Jason A. Donenfeld wrote: > On the technical topic, an Android developer friend following this > thread just pointed out to me that Android doesn't use PM_AUTOSLEEP and > just has userspace causing suspend frequently. So by his rough > est

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 07:19:36PM +0200, Greg Kroah-Hartman wrote: > I would be totally and completly amazed if there are any Android kernels > in real devices in the world that are not at the very least, based on > LTS releases. But maybe there is, this patch series isn't going to land > until

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 12:56:43PM -0400, Steven Rostedt wrote: > > And it will also "break" anyone else doing frequent suspends from > > userspace, as that behavior is still in no way related to > > CONFIG_ANDROID. > > Should there then be a CONFIG_FREQUENT_SUSPENDS ? That'd be fine by me. It

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 07:00:25PM +0200, Greg Kroah-Hartman wrote: > I think that by the time the next kernel release comes out, and > percolates to a real Android device, the years gone by will have caused > those who care about this to fix it. You assume that there aren't Android devices using

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 6:45 PM Christoph Hellwig wrote: > > On Wed, Jun 29, 2022 at 06:38:09PM +0200, Jason A. Donenfeld wrote: > > On the technical topic, an Android developer friend following this > > thread just pointed out to me that Android doesn't use PM_AUTOSLEE

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 06:37:01PM +0200, Christoph Hellwig wrote: > be a policy set somewhere either in the kernel or fed into the kernel > by userspace. Then we can key it off that, and I suspect it is > probably going to be a runtime variable and not a config option. Right, this would be a

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 06:30:07PM +0200, Christoph Hellwig wrote: > On Wed, Jun 29, 2022 at 06:25:32PM +0200, Jason A. Donenfeld wrote: > > Anyway, instead of the slow drip of "facts" and ≤three sentence emails, > > can you just write up a paragraph that indicates this is

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 06:15:27PM +0200, Christoph Hellwig wrote: > On Wed, Jun 29, 2022 at 06:13:05PM +0200, Jason A. Donenfeld wrote: > > Good! It sounds like you're starting to develop opinions on the matter. > > No, I provide facts. Lol. > Look at both the defini

Re: [PATCH] remove CONFIG_ANDROID

On Wed, Jun 29, 2022 at 06:10:20PM +0200, Christoph Hellwig wrote: > On Wed, Jun 29, 2022 at 06:09:18PM +0200, Jason A. Donenfeld wrote: > > CONFIG_ANDROID is used here for a reason. As somebody suggested in > > another thread of which you were a participant, it acts as a proxy fo

Re: [PATCH] remove CONFIG_ANDROID

Hi Christoph, On Wed, Jun 29, 2022 at 05:01:02PM +0200, Christoph Hellwig wrote: > diff --git a/drivers/char/random.c b/drivers/char/random.c > index e3dd1dd3dd226..f35ad1a9dff3e 100644 > --- a/drivers/char/random.c > +++ b/drivers/char/random.c > @@ -755,8 +755,7 @@ static int

Re: package from fedorainfracloud for centOS 8 does not build

On Wed, Jun 29, 2022 at 2:17 PM lejeczek wrote: > > Hi guys. > > In case somebody here looks after > 'copr:copr.fedorainfracloud.org:jdoss:wireguard' then > > wireguard-dkms-1.0.20220627-1.el8.noarch for 4.18.0-394.el8.x86_64 fails > to build > > many thanks, L.

Re: seems that https://www.wintun.net/ down?

Equinix Metal had a network connectivity incident and during the resolution apparently unplugged a server. Things are back up now. They told me the hardware I'm using is deprecated anyway, so I'll be migrating to a more reliable machine in the next few days. Jason

Re: CONFIG_ANDROID (was: rcu_sched detected expedited stalls in amdgpu after suspend)

Hi Alex, On Tue, Jun 28, 2022 at 11:02:40AM -0400, Alex Xu (Hello71) wrote: > WireGuard and random also use CONFIG_ANDROID in a similar "proxy" way as > rcu, there to see if suspends are "frequent". This seems dubious for the > same reasons. I'd be happy to take a patch in WireGuard and

The Future of RHEL7,8 Support in WireGuard

Hi folks, I'm confronted with a few hard facts, the first of which is good and exciting, and the rest are kind of disappointing: 1) RHEL9 has WireGuard baked into it by default, so there's no required compatibility backporting for it. If you use RHEL9, you can use WireGuard easily.

[ANNOUNCE] wireguard-linux-compat v1.0.20220627 released

, now backported. * compat: handle backported rng and blake2s Recent kernels did large backports of the RNG code and BLAKE2s, which the compat layer previously had various stubs for. Now the compat layer uses the properly backported code instead. This release contains commits from: Jason A.

Re: [PATCH] feat: add search to app list

Please resubmit this with a proper commit subject, commit message, and signed-off-by line.

Re: why not use ktime_get_clocktai_ts64

Hi Jacob, On Wed, Jun 15, 2022 at 06:48:08PM -0700, Jacob Lifshay wrote: > I was reading in noise.c and noticed you use ktime_get_real_ts64 and > do manual adjustments (the current code is broken if/when there's > another leap second) rather than using ktime_get_clocktai_ts64 which > already

Re: [PATCH] wg-quick: avoid traffics from momentarily leaking into the tunnel

On Fri, Jun 17, 2022 at 07:34:19PM +0800, Tom Yan wrote: > The wireguard route table ip rule should stay as a NOP until the > `suppress_prefixlength 0 table main` rule is in effect. Therefore, > add the wireguard default route to its route table after the latter > rule is added. > >

[ANNOUNCE] wireguard-freebsd snapshot v0.0.20220615 is available

() changes More fixes to the compat layer. * wg_noise: import hmac from crypto * crypto: inline blake2s convenience function A few crypto cleanups. This snapshot contains commits from: Jason A. Donenfeld, Joseph Mingrone, and Ed Maste. The source repository is available at

Re: [PATCH] compat: Update version to handle sbcreatecontrol() changes

Hi Joesph, On Tue, Jun 14, 2022 at 04:15:26PM -0300, Joseph Mingrone wrote: > The sockbuf changes to merge two versions of sbcreatecontrol() into one > occurred in b46667c63eb7 in the FreeBSD src repository. The value of > __FreeBSD_version at the time of that commit was 1400059, so check > for

[ANNOUNCE] wireguard-freebsd snapshot v0.0.20220614 is available

available * crypto: harmonize with compat and clean up Crypto from OCF and FreeBSD's library code will now be used when available. This snapshot contains commits from: John Baldwin and Jason A. Donenfeld. The source repository is available at the usual location: git clone https://git

[ANNOUNCE] wireguard-freebsd snapshot v0.0.20220610 is available

directory These allow building in different configurations. This snapshot contains commits from: John Baldwin and Jason A. Donenfeld. The source repository is available at the usual location: git clone https://git.zx2c4.com/wireguard-freebsd This snapshot is available in compressed tarball form

Re: [PATCH wireguard-go] tun: use ByteSliceToString from golang.org/x/sys/unix

Applied, thanks.

  1   2   3   4   5   6   7   8   9   10   >