Re: [PATCH net-next v2 03/10] tun: switch to net core provided statistics counters

2020-11-09 Thread Heiner Kallweit
On 06.11.2020 08:48, Heiner Kallweit wrote: > On 06.11.2020 02:14, Jakub Kicinski wrote: >> On Wed, 4 Nov 2020 15:25:24 +0100 Heiner Kallweit wrote: >>> @@ -1066,7 +1054,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, >>> struct net_device *dev) >>> return NETDEV_TX_OK; >>> >>>

Re: [PATCH net-next v2 03/10] tun: switch to net core provided statistics counters

2020-11-09 Thread Heiner Kallweit
On 06.11.2020 02:14, Jakub Kicinski wrote: > On Wed, 4 Nov 2020 15:25:24 +0100 Heiner Kallweit wrote: >> @@ -1066,7 +1054,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, >> struct net_device *dev) >> return NETDEV_TX_OK; >> >> drop: >> -

[PATCH net-next v2 03/10] tun: switch to net core provided statistics counters

2020-11-09 Thread Heiner Kallweit
Switch tun to the standard statistics pattern: - use netdev->stats for the less frequently accessed counters - use netdev->tstats for the frequently accessed per-cpu counters Signed-off-by: Heiner Kallweit --- drivers/net/tun.c | 127 +++--- 1 file

Re: [PATCH net-next v2 03/10] tun: switch to net core provided statistics counters

2020-11-06 Thread Jakub Kicinski
On Fri, 6 Nov 2020 09:27:45 +0100 Heiner Kallweit wrote: > On 06.11.2020 08:48, Heiner Kallweit wrote: > > On 06.11.2020 02:14, Jakub Kicinski wrote: > >> On Wed, 4 Nov 2020 15:25:24 +0100 Heiner Kallweit wrote: > >>> @@ -1066,7 +1054,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff > >>>

Re: [PATCH net-next v2 03/10] tun: switch to net core provided statistics counters

2020-11-05 Thread Jakub Kicinski
On Wed, 4 Nov 2020 15:25:24 +0100 Heiner Kallweit wrote: > @@ -1066,7 +1054,7 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, > struct net_device *dev) > return NETDEV_TX_OK; > > drop: > - this_cpu_inc(tun->pcpu_stats->tx_dropped); > + dev->stats.tx_dropped++; >