Re: [Wireshark-dev] Help understanding Epan's dissectors

2006-10-29 Thread Jaap Keuter
Hi, Good question. For the answer you have to search further up the call chain. Lets see: file.c:add_packet_to_packet_list() epan/epan.c:epan_dissect_run() epan/packet.c:dissect_packet() epan/dissectors/packet-frame.c:dissect_frame() So when reading packets from a capture file, metadata (like wta

[Wireshark-dev] Help understanding Epan's dissectors

2006-10-29 Thread angustia
Hello, I've been studying Wireshark's source code for a while, but there's something I still don't understand. It's specifically about the inner workings of Epan. How does one dissectors knows and decides which subdissector is the correct one? Such as, how does "frame" know which "wtap_enca

Re: [Wireshark-dev] Win32: I've Changed config.nmake from GTK2.6 to GTK2.8

2006-10-29 Thread Bill Meier
> > Remove all dirs from the libs-dir, remove the wireshark-gtk2 and rebuild > from scratch. Yep... "nmake ... clean-setup" followed by the usual solved the problem. Thanks :) Bill ___ Wireshark-dev mailing list Wireshark-dev@wireshark.

Re: [Wireshark-dev] Why do we have three different clean targets on Windows?!?

2006-10-29 Thread Guy Harris
Ulf Lamping wrote: > Hi List! > > Having three different clean targets in all the .nmake files doesn't > make any real sense and provides a permanent cause of trouble and confusion. > > The differences in: > > -clean > -maintainer-clean > -distclean > > ... sounds all very much over-engineered

[Wireshark-dev] Why do we have three different clean targets on Windows?!?

2006-10-29 Thread Ulf Lamping
Hi List! Having three different clean targets in all the .nmake files doesn't make any real sense and provides a permanent cause of trouble and confusion. The differences in: -clean -maintainer-clean -distclean ... sounds all very much over-engineered to me. To be honest I don't even know wha

Re: [Wireshark-dev] Win32: I've Changed config.nmake from GTK2.6 to GTK2.8

2006-10-29 Thread Ulf Lamping
Bill Meier wrote: > Is there some additional setup required ?? > (or something needs to be changed for the 'install-deps') ?? > ( or ??) > No, it's the update procedure required as explained in the Developer's Guide!!! Not your own custom update procedure which doesn't work(tm) :-( Your DLL's

Re: [Wireshark-dev] [patch] Dissect cisco mst bpdu's (Subject was: Info on mst bpdu's)

2006-10-29 Thread ronnie sahlberg
checked in On 10/29/06, Sake Blok <[EMAIL PROTECTED]> wrote: > Hi, > > The attached file is a patch to packet-bpdu.c so that Wireshark is > able to dissect the Cisco MST BPDU's that I encountered last week. > > Cheers, > > > Sake > > > On Sat, Oct 28, 2006 at 12:32:00AM +0200, Sake Blok wrote: >

Re: [Wireshark-dev] [Patch] Fix for bug #1163: "Dissector bug. ISO8073 COTP protocol."

2006-10-29 Thread ronnie sahlberg
checked in On 10/29/06, Stephen Fisher wrote: > > Attached is a patch to fix bug #1163: "Dissector bug. ISO8073 COTP > protocol." The SES dissector was incorrectly believing it had PDUs > within the COTP PDUs. I added an additional heuristic check to see if > the length of the SES PDU is 0, t

Re: [Wireshark-dev] Win32: I've Changed config.nmake from GTK2.6 to GTK2.8

2006-10-29 Thread Bill Meier
> Hi List! > > I've changed the default setting for the Win32 GTK version from 2.6 to > 2.8 in config.nmake. > OK: I need a hint ! I did the following: 1. svn update 2. "nmake ... setup libs" to update existing set of libraries (if required) The following were downloaded and unzipped

[Wireshark-dev] [Patch] Fix for bug #1163: "Dissector bug. ISO8073 COTP protocol."

2006-10-29 Thread Stephen Fisher
Attached is a patch to fix bug #1163: "Dissector bug. ISO8073 COTP protocol." The SES dissector was incorrectly believing it had PDUs within the COTP PDUs. I added an additional heuristic check to see if the length of the SES PDU is 0, then return false since it can't be zero length. Thank

[Wireshark-dev] [patch] Dissect cisco mst bpdu's (Subject was: Info on mst bpdu's)

2006-10-29 Thread Sake Blok
Hi, The attached file is a patch to packet-bpdu.c so that Wireshark is able to dissect the Cisco MST BPDU's that I encountered last week. Cheers, Sake On Sat, Oct 28, 2006 at 12:32:00AM +0200, Sake Blok wrote: > Hi, > > Yesterday I was troubleshooting a spanning-tree issue at a customer. > T

Re: [Wireshark-dev] Patch for epan/dissectors/packet-arp.c

2006-10-29 Thread Jaap Keuter
Hi, Checked in. Thanx, Jaap On Sun, 29 Oct 2006, Roger Gottsponer wrote: > Hi list! > > This is my first email to this list. So first of all, I would like > to thank everybody who contributed to this wonderful piece of software. > It greatly helps me in my daily work and without wireshark, > pr

Re: [Wireshark-dev] Win32: I've Changed config.nmake from GTK2.6 to GTK2.8

2006-10-29 Thread Jaap Keuter
Hi List, So this is a "Call to all developers": please review all open GTK related bug reports (found at http://bugs.wiresark.org) and update them according to your findings with GTK 2.8. Thanx, Jaap On Sun, 29 Oct 2006, Ulf Lamping wrote: > Hi List! > > I've changed the default setting for the

Re: [Wireshark-dev] Patch that fixes 3 typo's in the Development Guide

2006-10-29 Thread Ulf Lamping
Sake Blok wrote: > Hi, > > While I was reading the development guide I noticed a few typo's. > The attached patch fixes them (the patch is against revision 19724). > > checked in. Thanks, ULFL ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org

Re: [Wireshark-dev] GTK+ 2.8.x and fonts

2006-10-29 Thread Ulf Lamping
Gisle Vanem wrote: > Since installing GTK+ 2.8.6 on my system, the fonts in WireShark > has become increadibly small and ugly. Take a look at the attached > 'About' box. The same small font is also in the all the menus. > Does anybody else have this problem? > --gv Your GTK-Wimp installation seems

[Wireshark-dev] Patch for epan/dissectors/packet-arp.c

2006-10-29 Thread Roger Gottsponer
Hi list! This is my first email to this list. So first of all, I would like to thank everybody who contributed to this wonderful piece of software. It greatly helps me in my daily work and without wireshark, professional life would be much worse... During troubleshooting an ARP problem, I found

[Wireshark-dev] Win32: I've Changed config.nmake from GTK2.6 to GTK2.8

2006-10-29 Thread Ulf Lamping
Hi List! I've changed the default setting for the Win32 GTK version from 2.6 to 2.8 in config.nmake. As the branch to 0.99.4 was already done by Gerald, I thought it was the right time for this. I've done some small initial tests and the 2.8 version is looking good (although some known GTK bu

Re: [Wireshark-dev] [Patch] Disable UDP checksum preference

2006-10-29 Thread Jaap Keuter
Hi, Checked in with a split in the UDP and UDPlite preference. Thanx, Jaap On Sat, 28 Oct 2006, Stephen Fisher wrote: > Attached is a patch to allow the disabling of the UDP checksum > verification for cards that offload it and report it incorrectly. An > option is already available to disable

Re: [Wireshark-dev] Fetching of Structure from the tvb....

2006-10-29 Thread prashanth joshi
Hi, And one more thing when ever we need to alter the data we need to copy the data in to our memory right? So would it be safer to copy the data from tvb to the local memory ( ie stack memory ) always? I guess ethereal always has a copy of the local memory contents that we add to the display tre

[Wireshark-dev] Patch that fixes 3 typo's in the Development Guide

2006-10-29 Thread Sake Blok
Hi, While I was reading the development guide I noticed a few typo's. The attached patch fixes them (the patch is against revision 19724). Cheers, Sake docbook-patch.gz Description: application/gunzip ___ Wireshark-dev mailing list Wireshark-dev@wi