[Wireshark-dev] Protocol development

2006-12-13 Thread prashanth joshi
Hi all, We are required to develop a protocol on ethereal. The packets are sent to a particular ip address and the ethereal is supposed to capture packets from that ip address. Please any one tell me how to register our protocol for that ip address. Regards, Prashanth. -

Re: [Wireshark-dev] Protocol development

2006-12-13 Thread sebastien
Hi, You can't as you said "register a protocol for an IP address" ... but you can register a plugin which will dissect your protocol. If you only want the dissection for a particular IP address, wireshark allows you to create a filter (capture or display). for a plugin implementation in wireshark

[Wireshark-dev] Dificulties in dissecting some packets

2006-12-13 Thread taraniteja.vishwanatha
Hi , I have encountered some problems when dissecting the packets for a protocol.I am mentioning 3 different scenarios 1. In the below case , the octet is split into parts and each part viz x , y and z take different values. I am not able to understand how to go about it.

Re: [Wireshark-dev] Dificulties in dissecting some packets

2006-12-13 Thread sebastien
hi, may you format you mail in an other way, please? Selon [EMAIL PROTECTED]: > > Hi , > > I have encountered some problems when dissecting the packets for a > protocol.I am mentioning 3 different scenarios > > > > 1. > > In the below case , the octet is split into parts and each part viz x ,

Re: [Wireshark-dev] Protocol development

2006-12-13 Thread prashanth joshi
Hi our requirement is as follows: The packets are sent from the application to a particular multicast ip address. Now we want ethereal to capture these packets from the network. So as I have observed for the implemnation of a protocol, a dissector has to be registered with a port. But I re

Re: [Wireshark-dev] Protocol identification for msnms

2006-12-13 Thread Trivedi, Nirav
Thanks! If I wanted to look at other protocols and how the identification is made for each one, is there an easier way than to read through source code? Is the information published somewhere? -Nirav -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of ron

Re: [Wireshark-dev] Malformed packets in CORBA protocol plugin

2006-12-13 Thread Andy . Ling
Guy Harris <[EMAIL PROTECTED]> wrote on 12/12/2006 10:55:20: > I'd suggest moving the start_dissecting() calls into the routines that > process individual procedure requests and replies, and avoid generating > those calls if there are no items expected. > I've just started having a closer look

Re: [Wireshark-dev] Protocol development

2006-12-13 Thread Douglas Pratley
Unfortunately, I don't think Wireshark can't quite do what you want. I am assuming that you have the protocol stack: Ethernet -> maps to next layer by "Ethertype" field IP -> maps to next layer by "Protocol" field UDP -> maps to next layer by "Port" field As Sebastien said, the UDP dissector

Re: [Wireshark-dev] Protocol development

2006-12-13 Thread Anders Broman \(AL/EAB\)
Hi, The pacet capture is handled by libpcap or winpcap (or some other tool/program) depending on the platform used. In the case of Ethernet the capture is made by puting the Ethernet car in promiscuous mode which means that all packets on the network segment the card is on will be captured. Di

Re: [Wireshark-dev] Dificulties in dissecting some packets

2006-12-13 Thread Sebastien Tandel
hi, sorry for the previous mail, I was reading my mail with horde and the figures did not rendered the format correctly and now I'm seeing it in Thunderbird and it represents them correctly now ;) all is documented in the doc/README.developer case 1) with a structure "value_string" case 2) if yo

[Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)

2006-12-13 Thread Stig Bjørlykke
Hi, I have added a new dissector for DMP (STANAG 4406 Direct Message Profile) as defined in STANAG 4406 Annex E. The DMP protocol has no assigned UDP port number yet, so the default value in this dissector is 0 (I suppose this is som sort of "disabled"?) until we get this registered. T

Re: [Wireshark-dev] Dificulties in dissecting some packets

2006-12-13 Thread Anders Broman \(AL/EAB\)
Hi, In addition it looks like a telecom proto with a BCD coded number so it might allready be a dissector or a routine avalable. BR Anders From: [EMAIL PROTECTED] on behalf of Sebastien Tandel Sent: Wed 12/13/2006 5:30 PM To: Developer support list for Wireshar

Re: [Wireshark-dev] Malformed packets in CORBA protocol plugin

2006-12-13 Thread Andy . Ling
Guy Harris <[EMAIL PROTECTED]> wrote on 12/12/2006 10:55:20: > I'd suggest moving the start_dissecting() calls into the routines that > process individual procedure requests and replies, and avoid generating > those calls if there are no items expected. > I've looked at this a bit deeper now a

Re: [Wireshark-dev] Malformed packets in CORBA protocol plugin

2006-12-13 Thread Guy Harris
[EMAIL PROTECTED] wrote: > Can anyone see any problem with this? 1) as indicated in my earlier mail, it won't throw an exception if you have a bad packet that should have a request body but doesn't. 2) if you ignore that, it should be tvb_reported_length_remaining(), because tvb_length_remaini

[Wireshark-dev] a query

2006-12-13 Thread vanita disale
Hi all, We need to implement HSRPv2 protocol. Currently ethereal supports HSRPv1 ( packet-hsrp.c). The problem is HSRPv1 acts on a different multicast address and HSRPv2 acts on a different multicast address. Hence HSRPv2 can not be made a part of the packet-hsrp.c. So how to direct ethere

Re: [Wireshark-dev] a query

2006-12-13 Thread Guy Harris
vanita disale wrote: > We need to implement HSRPv2 protocol. > Currently ethereal supports HSRPv1 ( packet-hsrp.c). > The problem is HSRPv1 acts on a different multicast address and HSRPv2 > acts on a different multicast address. Hence HSRPv2 can not be made a > part of the packet-hsrp.c. Yes,

Re: [Wireshark-dev] [PATCH] stats_tree.c fixup preventing segfault

2006-12-13 Thread Stephen Fisher
On Tue, Dec 12, 2006 at 04:41:19AM +0100, Sebastien Tandel wrote: >here is a patch against svn rev20122 which prevents wireshark from > segfault when trying the stats module "packet length". the function > affected is get_range in epan/stats_tree.c which did not the correct > tests if you w

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-13 Thread Stephen Fisher
On Tue, Dec 12, 2006 at 05:06:49PM +0100, Sebastien Tandel wrote: > This patch should resolve the problem of the TCP seq number which > is not shown when dissecting an ICMP Unreachable packet. > It is related to the bug 595. Do you have a sample capture you can attach to bug 595 for us to

Re: [Wireshark-dev] Protocol identification for msnms

2006-12-13 Thread Stephen Fisher
On Wed, Dec 13, 2006 at 10:53:10AM -0500, Trivedi, Nirav wrote: > Thanks! If I wanted to look at other protocols and how the > identification is made for each one, is there an easier way than to > read through source code? Is the information published somewhere? Not that I know of; the source

Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)

2006-12-13 Thread Stephen Fisher
On Wed, Dec 13, 2006 at 05:49:58PM +0100, Stig Bj?rlykke wrote: > I have added a new dissector for DMP (STANAG 4406 Direct Message > Profile) as defined in STANAG 4406 Annex E. The DMP protocol has no > assigned UDP port number yet, so the default value in this dissector > is 0 (I suppose this

Re: [Wireshark-dev] [PATCH] stats_tree.c fixup preventing segfault

2006-12-13 Thread Sebastien Tandel
Hi Stephen, it's just after ... I leave the filter empty and click create stats :) see in the code plugins/pinfo_stats_tree.c line 97 : st_node_plen = stats_tree_create_range_node(st, st_str_plen, 0, "0-19","20-39","40-79","80-159","160-319","320-639","640-1279","1280-2559","2560-5119","5

Re: [Wireshark-dev] [PATCH] bugfix : ICMP unreachable and tcp seq not shown

2006-12-13 Thread Sebastien Tandel
Here is a little trace created with hping3 :) Stephen Fisher wrote: > On Tue, Dec 12, 2006 at 05:06:49PM +0100, Sebastien Tandel wrote: > > >> This patch should resolve the problem of the TCP seq number which >> is not shown when dissecting an ICMP Unreachable packet. >> > > >> I

Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)

2006-12-13 Thread Stig Bjørlykke
Den 13. des. 2006 kl. 21.24 skrev Stephen Fisher: > Please excuse my ignorance of this protocol, but is it different than > what packet-s4406.c dissects? Yes, this one is very different. This is a very compact format used for transmitting time-critical short X.400 messages (X.420 and STANAG

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-05

2006-12-13 Thread Stephen Fisher
On Wed, Dec 06, 2006 at 08:03:56AM -0800, Marc Petit-Huguenin wrote: > I initially tried to implement the new STUN (STUNv2) in the same > dissector, but at the end it was very messy. A little bit of history > can help to understand the situation: Thanks for the explaination. I have committed

Re: [Wireshark-dev] Malformed packets in CORBA protocol plugin

2006-12-13 Thread Andy . Ling
-Guy Harris <[EMAIL PROTECTED]> wrote: - >> Can anyone see any problem with this? > >1) as indicated in my earlier mail, it won't throw an exception if >you >have a bad packet that should have a request body but doesn't. > Surely it will still throw later on if a dissector tries to re

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-05

2006-12-13 Thread Stephen Fisher
On Wed, Dec 13, 2006 at 02:23:54PM -0800, Stephen Fisher wrote: > On Wed, Dec 06, 2006 at 08:03:56AM -0800, Marc Petit-Huguenin wrote: > > > I initially tried to implement the new STUN (STUNv2) in the same > > dissector, but at the end it was very messy. A little bit of > > history can help to

Re: [Wireshark-dev] [PATCH] draft-ietf-behave-rfc3489bis-05

2006-12-13 Thread Marc Petit-Huguenin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stephen Fisher wrote: > On Wed, Dec 13, 2006 at 02:23:54PM -0800, Stephen Fisher wrote: >> On Wed, Dec 06, 2006 at 08:03:56AM -0800, Marc Petit-Huguenin wrote: >> >>> I initially tried to implement the new STUN (STUNv2) in the same >>> dissector, but

Re: [Wireshark-dev] [PATCH][Update] stats_tree.c fixup preventing segfault

2006-12-13 Thread Sebastien Tandel
I don't see exactly what could have been changed between the both implementations in their doc but I may miss something http://developer.gnome.org/doc/API/2.0/glib/glib-String-Utility-Functions.html#g-strsplit http://developer.gnome.org/doc/API/glib/glib-string-utility-functions.html#G-STRSPLIT

Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)

2006-12-13 Thread Stephen Fisher
On Wed, Dec 13, 2006 at 05:49:58PM +0100, Stig Bj?rlykke wrote: > I have added a new dissector for DMP (STANAG 4406 Direct Message > Profile) as defined in STANAG 4406 Annex E. The DMP protocol has no > assigned UDP port number yet, so the default value in this dissector > is 0 (I suppose this

Re: [Wireshark-dev] [PATCH] New dissector: DMP (STANAG 4406 Direct Message Profile)

2006-12-13 Thread Stephen Fisher
On Wed, Dec 13, 2006 at 10:02:57PM +0100, Stig Bj?rlykke wrote: > Den 13. des. 2006 kl. 21.24 skrev Stephen Fisher: > > > Please excuse my ignorance of this protocol, but is it different > > than what packet-s4406.c dissects? > > Yes, this one is very different. This is a very compact format us

[Wireshark-dev] [PATCH] fixup memory leak

2006-12-13 Thread Sebastien Tandel
Hi, here is patch for a memory leak in packet-k12.c which allocates a hash table and may return without destroying it. Regards, Sebastien Tandel Index: epan/dissectors/packet-k12.c === --- epan/dissectors/packet-k12.c(ré

Re: [Wireshark-dev] [PATCH][Update] stats_tree.c fixup preventing segfault

2006-12-13 Thread Sebastien Tandel
Hi, reviewing the potential problems g_strsplit could cause in others parts of wireshark. I noticed that my patch was not completely safe. here is a patch which should be safe. (please also review) Regards, Sebastien Tandel Index: epan/stats_tree.c ===