On Sat, Mar 24, 2007 at 01:05:41AM +0100, Sebastien Tandel wrote:
> patch fixing warnings for the following dissectors :
> packet-3ga11.c
> packet-aim-buddylist.c
> packet-aim-chat.c
> packet-aim-messaging.c
> packet-aim-signon.c
> packet-ajp13.c
Committed as revision 2116
Peter Johansson wrote:
> Hi!
>
> Ulf Lamping wanted help with getting rid of compiler warnings and I
> agree. Its hard to see newly introduced warnings among all the other
> ones. Hence here is a list of patches to address some of them on a
> Windows build.
>
> Note though that for packet-sc
Graham Bloice wrote:
> When compiling with MSVC 6.0 and the platform SDK, there are failures
> due to the redefinition of sockaddr_storage in capture_wpcap_packet.c
> and gtk/capture_if_details_dlg.c.
>
> The definition is conditional on the version of MSVC used, whereas the
> actual definition dep
On Sat, Mar 24, 2007 at 02:33:34AM +0100, Ulf Lamping wrote:
> I'm getting the following error on MSVC 8 now:
>
> dissectors.lib(packet-dtls.obj) : error LNK2005:
> _ssl_version_short_names already defined in dissect
> ors.lib(packet-ssl.obj)
> dissectors.lib(packet-ssl-utils.obj) : error LNK2005
[EMAIL PROTECTED] wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21160
>
> User: sfisher
> Date: 2007/03/24 12:45 AM
>
> Log:
> Remove all warnings under Unix for the gtk/ directory.
>
> Directory: /trunk/epan/dissectors/
> ChangesPath Action
> +
patch fixing warnings for the following dissectors :
packet-3ga11.c
packet-aim-buddylist.c
packet-aim-chat.c
packet-aim-messaging.c
packet-aim-signon.c
packet-ajp13.c
3ga11-aim-ajp13-warnings-fix.diff.gz
Description: application/gzip
_
On Sat, Mar 24, 2007 at 12:22:39AM +0100, Sebastien Tandel wrote:
>fixes gcc warnings and get rid of declaration after statements
Committed as SVN revision 21159. Thanks for your help!
Steve
___
Wireshark-dev mailing list
Wireshark-dev@wireshark
Hi,
fixes gcc warnings and get rid of declaration after statements
Regards,
Sebastien Tandel
plugin-asn1.diff.gz
Description: application/gzip
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/w
> The only problem seems to be that it is a guchar and
> the 6th argument to proto_tree_add_string_format() expects a char.
> Which parameter do you mean putting strlen(octets) in?
>
Right. I don't know why I've seen it as the length parameter.
Regards,
Sebastien Tandel
__
On Fri, Mar 23, 2007 at 10:04:52PM +0100, Sebastien Tandel wrote:
> I can't really decide on 6 warnings similar. Take a look at one of
> them :
> The 6th parameters (octets) of proto_tree_add_string_format is the
> guchar array we have converted with showoctets. Is it correct? Don't
> we have
Hi,
1, can you move the hf and ett arrays as well as the
proto_register_... and proto_reg_handoff_... to the end of the file
instead of the begining to be more consistent with other dissectors.
2, remove the amqp_module variable since it is not yet used.
also remove the if(proto_amqp) { conditio
Hi,
I can't really decide on 6 warnings similar. Take a look at one of them :
guchar * octets;
const char * ename;
...
ename = showoctets(octets, len, (tag == BER_UNI_TAG_OCTETSTRING) ? 4 : 0);
...
proto_tree_add_string_format(pt, props.value_id, tvb, boffset,
Committed as SVN revision 21157. Thanks!
On Thu, Mar 22, 2007 at 06:24:17PM +0100, Sebastien Tandel wrote:
> what a shame, even the comment was copy pasted :-p
>
> patch with accurate comment and declaration.
>
>
> Regards,
> Sebastien Tandel
>
> Sebastien Tandel wrote:
> > copy paste hit aga
On Fri, Mar 23, 2007 at 11:09:51AM -0700, Stephen Fisher wrote:
> On Thu, Mar 22, 2007 at 08:53:25PM +0100, Sake Blok wrote:
>
> > Could the patches I submitted to bugzilla be reviewed? I think they
> > were overlooked because I did not put "[PATCH]" in the subject-lines
> > of the mails I sent
On Thu, Mar 22, 2007 at 04:31:23PM +0100, Sebastien Tandel wrote:
> stripped away some unused variables/parameters
> + in prefs.c
> suggestion of parentheses makes gcc happy
Committed as SVN revision 21156. Thanks!
Steve
___
Wireshark-dev mailin
There is a list at: http://wiki.wireshark.org/Tools, but don't ask me about
them (I've never used them myself) ...
Regards, ULFL
> -Ursprüngliche Nachricht-
> Von: Developer support list for Wireshark
> Gesendet: 23.03.07 19:25:47
> An: "Developer support list for Wireshark"
> Betreff
Then there are others in the list :
bad RVALS declaration
unused variables
strict aliasing warning fix
Regards,
Sebastien Tandel
Stephen Fisher wrote:
> On Fri, Mar 23, 2007 at 07:04:38PM +0100, Sebastien Tandel wrote:
>
>
>> I've posted a patch (subject : Plugins Warnings) for fix
Stephen Fisher wrote:
> On Fri, Mar 23, 2007 at 05:33:41PM +0100, Sebastien Tandel wrote:
>
>
>> First patch fixes warning of profinet and megaco plugins to compile
>> again with gcc-4.1.2.
>>
>
> Committed as SVN revision 21155. Thanks for your help!
>
>
>> asn1 plugin is generating w
On Fri, Mar 23, 2007 at 07:04:38PM +0100, Sebastien Tandel wrote:
> I've posted a patch (subject : Plugins Warnings) for fixing warnings
> in profinet and megaco. If you won't integrate it, please say it that
> I stop loosing my time.
I just committed it; your help is greatly appreciated!
Ste
On Fri, Mar 23, 2007 at 05:33:41PM +0100, Sebastien Tandel wrote:
> First patch fixes warning of profinet and megaco plugins to compile
> again with gcc-4.1.2.
Committed as SVN revision 21155. Thanks for your help!
> asn1 plugin is generating warnings. I'm correcting them now. I have
> nevert
Win32
On 3/23/07, Steven Le <[EMAIL PROTECTED]> wrote:
Are there packet generators around to test my codes?
Steven
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev
Are there packet generators around to test my codes?
Steven
___
Wireshark-dev mailing list
Wireshark-dev@wireshark.org
http://www.wireshark.org/mailman/listinfo/wireshark-dev
On Thu, Mar 22, 2007 at 08:53:25PM +0100, Sake Blok wrote:
> Could the patches I submitted to bugzilla be reviewed? I think they
> were overlooked because I did not put "[PATCH]" in the subject-lines
> of the mails I sent to this list.
>
> The patches are listed under the following bugs:
>
> *
On Fri, Mar 23, 2007 at 07:34:23AM +0100, Sake Blok wrote:
> It turns out that the recent hunt for warnings resulted also in a few
> casts in column-utils.c. I incorporated these casts in my patch so it
> should now be able to load the patch against the latest SVN (21147).
>
> Could you give it
I've posted a patch (subject : Plugins Warnings) for fixing warnings in
profinet and megaco.
If you won't integrate it, please say it that I stop loosing my time.
Regards,
Sebastien Tandel
Stephen Fisher wrote:
> On Fri, Mar 23, 2007 at 05:32:12PM +0100, Sebastien Tandel wrote:
>
>
>>Patch
On Fri, Mar 23, 2007 at 05:32:12PM +0100, Sebastien Tandel wrote:
>Patch for configure.in which disables by default the treatment of
> warnings as errors. It can be enabled with './configure
> --with-warnings-as-errors'. The macro will test first if GCC is
> present. If it's the case, HAVE_
Hi,
First patch fixes warning of profinet and megaco plugins to compile
again with gcc-4.1.2.
asn1 plugin is generating warnings. I'm correcting them now.
I have nevertheless a question. offset in asn1_close and asn1_open is
declared as int but never used as such in packet-asn1.c Could it be
chan
Hi,
Patch for configure.in which disables by default the treatment of
warnings as errors.
It can be enabled with './configure --with-warnings-as-errors'.
The macro will test first if GCC is present. If it's the case,
HAVE_WARNINGS_AS_ERRORS is defined. All the USING_GCC have been replaced
by H
On Thu, Mar 22, 2007 at 08:01:50PM -0700, Stephen Fisher wrote:
> On Thu, Mar 22, 2007 at 07:47:35PM -0700, Guy Harris wrote:
> The alternative is to compile with -std=c99 for the long long case, but
> do we really want to do that? I agree that -pedantic is a bit too much
> to tackle, at least f
When compiling with MSVC 6.0 and the platform SDK, there are failures
due to the redefinition of sockaddr_storage in capture_wpcap_packet.c
and gtk/capture_if_details_dlg.c.
The definition is conditional on the version of MSVC used, whereas the
actual definition depends on the version of winsock d
On Thu, Mar 22, 2007 at 04:08:36PM -0700, Stephen Fisher wrote:
>
> On Wed, Mar 21, 2007 at 05:46:50PM -0700, Stephen Fisher wrote:
> >
> > I've found a way around this issue and have introduced it into the
> > same places in my tree on Unix as Ulf has on Windows so far. It's a
> > variable se
Luis Ontanon wrote:
>Simple dissector:
> packet-udp.[ch] implements RFC 768
>
>Somewhat complex dissector:
> packet-sctp.[ch] implements RFC 2960 and others
>
>Very complex dissector:
> packet-xml.[ch] impelements (parts of) http://www.w3.org/XML/
>
>as a rule of thumb most dissectors can be f
32 matches
Mail list logo
