[Wireshark-dev] Dissector submitted

2008-07-07 Thread Martin Corraine (mcorrain)
Hello, I'm new to this so I want to make sure that I submitted my ged125 dissector properly. It is bug # 2692. Also, I will probably make changes to this dissector in the near future as Cisco uses this. I did fuzz test but there are a few parts that couldn't be well tested at this moment. Is ther

Re: [Wireshark-dev] assigning bugs

2008-07-07 Thread Jaap Keuter
Hi, There's no real assignment process. The default assignee (wireshark-bugs) is the mailinglist everyone can subscribe to to track bug changes. It's usually best to leave it that way so everyone stays informed. That doesn't mean you're not invited to submit patches ;) Thanx, Jaap Edward J. P

[Wireshark-dev] assigning bugs

2008-07-07 Thread Edward J. Paradise
How are bugs normally assigned? I just opened up 2690 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2690 ) which has an easy fix for packet-pppoe.c. I wouldn't mind fixing it myself as I would like to enhance the current support for rfc4938 and rfc4938bis to include filtering and inb

Re: [Wireshark-dev] Build-in

2008-07-07 Thread Jaap Keuter
Hi, If your dissector is a single dissector file, possibly with include file, it might be better to include in libwireshask. Therefore you'll need to move your dissector to epan/dissectors and add it's name to epan/dissectors/Makefile.common. Just like README.developers tells you. The extra st

[Wireshark-dev] Build-in

2008-07-07 Thread Martin Corraine (mcorrain)
Hello, I'm nearly ready to submit my first dissector. Currently, I have the dissector set up as a plug-in. However, after reading I've found out that the community usually prefers a build-in dissector. How do I go about making this change? ___ Wireshark

Re: [Wireshark-dev] [PATCH]: enhanced "what's past last mpls label?" heuristic

2008-07-07 Thread Jaap Keuter
Hi, Please read http://www.wireshark.org/docs/wsdg_html/#ChSrcSend about submitting patches for Wireshark. Just to make sure it doesn't get lost. Thanx, Jaap Francesco Fondelli wrote: > Hi all, > > Attached is a patch for: > > - PW Associated Channel Header dissection as per RFC 4385 > - PW M

Re: [Wireshark-dev] LLRP dissector support

2008-07-07 Thread Poduska, Matt
I've rewritten the guts of this dissector to remove all of the buffer portability abstraction. A new patch has been added to the bugzilla case. Please let me know if it's acceptable. Thanks, Matt Poduska -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jaa

Re: [Wireshark-dev] Teamspeak2 Dissector

2008-07-07 Thread Brooss
Just a friendly reminder that I have addressed the comments you made on the bug (2373) with a new patch and am waiting for more feedback. Thank you Brooss Jaap Keuter wrote: > Hi, > > You caught us in a busy time, working towards 1.0.0. I've looked at it and > added some comments. Lets keep wor

[Wireshark-dev] buildbot failure in Wireshark (release) on OSX-10.5-x86

2008-07-07 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-x86 on Wireshark (release). Full details are available at: http://buildbot.wireshark.org/release/builders/OSX-10.5-x86/builds/16 Buildbot URL: http://buildbot.wireshark.org/release/ Buildslave for this Build: osx-10.5-x86 Build Reason: Build

Re: [Wireshark-dev] malformed packet

2008-07-07 Thread Jeff Morriss
Martin Corraine (mcorrain) wrote: > Hello, > > If I check a packet's header and size and return 0 because it wasn't my > protocol (GED125), should I get the following message: "Malformed > Packet: GED125"? Probably not. Are you sure it's actually returning 0 for that packet? It sounds like

Re: [Wireshark-dev] col_set_str not working from plugin ?? bug 1967

2008-07-07 Thread Jeff Morriss
Gilles Dufour (gdufour) wrote: > Hi, > > I used to do this a few years ago, but I might be a bit rusty :) > > I have a plugin/dll dissector that I created and it works fine except I > never get the column text to be modified. > Whatever the column. > I tried many different commands (you will

[Wireshark-dev] malformed packet

2008-07-07 Thread Martin Corraine (mcorrain)
Hello, If I check a packet's header and size and return 0 because it wasn't my protocol (GED125), should I get the following message: "Malformed Packet: GED125"? Thanks, Martin ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org https://wiresha

[Wireshark-dev] col_set_str not working from plugin ?? bug 1967

2008-07-07 Thread Gilles Dufour (gdufour)
Hi, I used to do this a few years ago, but I might be a bit rusty :) I have a plugin/dll dissector that I created and it works fine except I never get the column text to be modified. Whatever the column. I tried many different commands (you will see it in the code below). Even tried to create m

[Wireshark-dev] [PATCH]: enhanced "what's past last mpls label?" heuristic

2008-07-07 Thread Francesco Fondelli
Hi all, Attached is a patch for: - PW Associated Channel Header dissection as per RFC 4385 - PW MPLS Control Word dissection as per RFC 4385 - mpls subdissector table indexed by label value - enhanced "what's past last mpls label?" heuristic - Ethernet PW (w/o CW) support as per RFC 4448 The new

Re: [Wireshark-dev] SSL decryption breaks after retransmission

2008-07-07 Thread Abhik Sarkar
No problems... thanks for the update, Sake! On Mon, Jul 7, 2008 at 5:20 PM, Sake Blok <[EMAIL PROTECTED]> wrote: > Abhik, > > I did take a look at it, but have not found the time yet to create > a proper fix. > > Cheers, > Sake > > > On Mon, Jul 07, 2008 at 04:03:28PM +0400, Abhik Sarkar wrote

Re: [Wireshark-dev] SSL decryption breaks after retransmission

2008-07-07 Thread Sake Blok
Abhik, I did take a look at it, but have not found the time yet to create a proper fix. Cheers, Sake On Mon, Jul 07, 2008 at 04:03:28PM +0400, Abhik Sarkar wrote: > Hi Sake, > > I was curious to know - Are you working on this? I just wanted to know > because some work I am doing depends (

Re: [Wireshark-dev] SSL decryption breaks after retransmission

2008-07-07 Thread Abhik Sarkar
Hi Sake, I was curious to know - Are you working on this? I just wanted to know because some work I am doing depends (slightly) on this and I will put comments in the code accordingly. Thanks! Abhik. On Thu, May 29, 2008 at 9:38 PM, Sake Blok <[EMAIL PROTECTED]> wrote: > On Thu, May 29, 2008 at