Re: [Wireshark-dev] [Wireshark-bugs] [Bug 4339] [PATCH] VNC dissector cleanups and minor changes

2010-01-10 Thread Bill Meier
bugzilla-dae...@wireshark.org wrote: I'm not sure what the consequence of the removal of the 2nd 'heur_dissector_add(tcp, test_vnc_protocol, proto_vnc);' line. I've added it in rev. 28394, can't see the logic why it was added twice (and why not remove the first call to it). If I understand

[Wireshark-dev] small patch for smtps on port 465

2010-01-10 Thread rmkml
Hi, First, Happy New Year for everyone ok I have created a small patch for packet-smtp.c dissector, redirect to ssl dissector for smtps (on port 465). tested on tshark v1.2.5 on linux i386. Regards Rmkml Crusoe-Researches.com--- epan/dissectors/packet-smtp.c.ori 2010-01-09 16:53:18.0

Re: [Wireshark-dev] small patch for smtps on port 465

2010-01-10 Thread Stephen Fisher
On Jan 9, 2010, at 8:46 AM, rmkml wrote: First, Happy New Year for everyone Happy new year. ok I have created a small patch for packet-smtp.c dissector, redirect to ssl dissector for smtps (on port 465). tested on tshark v1.2.5 on linux i386. Thanks for your work. Could you please file

Re: [Wireshark-dev] small patch for smtps on port 465

2010-01-10 Thread Stig Bjørlykke
On 9. jan. 2010, at 16.46, rmkml wrote: ok I have created a small patch for packet-smtp.c dissector, redirect to ssl dissector for smtps (on port 465). Committed revision 31482. -- Stig Bjørlykke ___ Sent via: