[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86

2010-02-03 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/1362 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-x86 Build Reason: Bui

Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-clnp.c packet-p_mul.c packet-tcp.c packet-x25.c

2010-02-03 Thread didier
Hi, Le mercredi 03 février 2010 à 09:45 +0100, Stig Bjørlykke a écrit : > On Wed, Feb 3, 2010 at 12:33 AM, Guy Harris wrote: > > NDS's "Reassembled length" field is in generated code; the generator is > > tools/ncp.py. I've updated that. > > We have some other dissectors with just "Reassemb

Re: [Wireshark-dev] preliminary code submission

2010-02-03 Thread Brian Oleksa
Jakub Yes...you are right. I am not using alot of those variables. I was mislead by what I was doing before I started to use the built in routines. :-) My code base keeps getting smaller and smaller. I do understand that code quality / readability is a key factor in this industry. I still n

Re: [Wireshark-dev] Bug 3871 (Please include source for User's Guide in distributed sources)

2010-02-03 Thread Jeff Morriss
Balint Reczey wrote: > Hi, > > I would like to bring some attention to the mentioned bug [1]. > > The problem has been reported as a wishlist item several times to the > Debian BTS. Probably other distributions would be happy, too, to be able > package the documentation for Wireshark in an easy

Re: [Wireshark-dev] preliminary code submission

2010-02-03 Thread Jakub Zawadzki
Hi, On Wed, Feb 03, 2010 at 01:05:32PM -0500, Brian Oleksa wrote: > Jakub > > Thanks for this feedback. It is always good to have an extra set of eyes :-) You missunderstood my comment about check_col() instead of: if (check_col(pinfo->cinfo, COL_PROTOCOL)) col_set_str(pinfo->cinfo,

Re: [Wireshark-dev] preliminary code submission

2010-02-03 Thread Brian Oleksa
Jakub Thanks for this feedback. It is always good to have an extra set of eyes :-) I need to fix my IDE so it will format correctly. This is probably why you see a problem with the indentation. I took care of the following...and attached the updated file: - C++ comments fixed to use /*.

Re: [Wireshark-dev] preliminary code submission

2010-02-03 Thread Jakub Zawadzki
Hi, On Wed, Feb 03, 2010 at 11:44:40AM -0500, Brian Oleksa wrote: > Again... any feedback is appreciated. - Inconsistent indentation (you use sometimes \t sometimes spaces) - C++ comments style. - using value_string struct is more proper way to map value with string than switch-es... - You have

[Wireshark-dev] preliminary code submission

2010-02-03 Thread Brian Oleksa
Wiresharkers I have been plugging away on bringing my wireshark dissector up to specs to adhere to the wireshark coding standards. I appreciate all the help that was given to me via this wireshark developers mailing list. I believe that I am up to par with the coding specs and would like to

Re: [Wireshark-dev] Capture filter syntax check - why no check before starting a session?

2010-02-03 Thread Jaap Keuter
Hi, I've been toying with the idea of adding a precompile option button to the capture dialog. When pressing that a popup would show you the BPF code (like tcpdump -d) and a result of processing the capture filter. Maybe you can file an enhancement bug? Thanks, Jaap Send from my iPhone On

Re: [Wireshark-dev] RTP-MIDI and AppleMIDI dissectors

2010-02-03 Thread Tobias Erichsen
Hi Steve, thanks to you and Jaap for the feedback. I have since downloaded the 1.3.3 version from the svn-server, reworked my code (only AppleMIDI so far), have created a patch/diff between my code and the 1.3.3 version of the svn and submitted this together with another capture-file as an enhanc

[Wireshark-dev] Capture filter syntax check - why no check before starting a session?

2010-02-03 Thread Robert Kochem
Hi Wireshark developers, I am currently fighting again with the capture filter syntax. I want to build a relatively complex filter which isn't that simple. My major problem while developing the capture filter is that there is the missing possibility to check the syntax of a filter. The only possi

Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-clnp.c packet-p_mul.c packet-tcp.c packet-x25.c

2010-02-03 Thread Stig Bjørlykke
On Wed, Feb 3, 2010 at 12:33 AM, Guy Harris wrote: > NDS's "Reassembled length" field is in generated code; the generator is > tools/ncp.py.  I've updated that. We have some other dissectors with just "Reassembled length", the plan was to match this with the name of the data source. > Shoul