Re: [Wireshark-dev] Time shift patch causes compile error

2011-08-14 Thread Stig Bjørlykke
On Sun, Aug 14, 2011 at 12:34 AM, Joerg Mayer wrote: > At least when compiling with UI_MANAGER set, I get the following compile > error: Should be fixed in revision 38523. Other issues with Time Shift should be put in bug 6179: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6179 -- Stig

Re: [Wireshark-dev] [Wireshark-commits] rev 38522: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-14 Thread Stig Bjørlykke
On Sun, Aug 14, 2011 at 1:34 AM, wrote: > Log: >  Don't map "no interfaces" to "none" and then back to an empty string; >  just map it to an empty string. Try opening Capture Options a second time, and "none" is back in the list. -- Stig Bjørlykke _

Re: [Wireshark-dev] [Wireshark-commits] rev 38522: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-14 Thread Michael Tüxen
On Aug 14, 2011, at 11:27 AM, Stig Bjørlykke wrote: > On Sun, Aug 14, 2011 at 1:34 AM, wrote: >> Log: >> Don't map "no interfaces" to "none" and then back to an empty string; >> just map it to an empty string. > > Try opening Capture Options a second time, and "none" is back in the list. Is t

Re: [Wireshark-dev] [Wireshark-commits] rev 38515: /trunk/gtk/ /trunk/gtk/: capture_dlg.c capture_if_dlg.c

2011-08-14 Thread Michael Tüxen
On Aug 14, 2011, at 2:04 AM, Guy Harris wrote: > > On Aug 13, 2011, at 1:50 PM, Michael Tüxen wrote: > >> On Aug 13, 2011, at 10:26 PM, Stig Bjørlykke wrote: >> >>> BTW, why do we build the same string ("%s\n>> size='small'>%s") 4 different places? >> Two for the initial setup of the interface

Re: [Wireshark-dev] [Wireshark-commits] rev 38522: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-14 Thread Stig Bjørlykke
On Sun, Aug 14, 2011 at 12:42 PM, Michael Tüxen wrote: > On Aug 14, 2011, at 11:27 AM, Stig Bjørlykke wrote: >> Try opening Capture Options a second time, and "none" is back in the list. > Is that still true in the current version? I can't reproduce that... Fixed with the addresses count change.

Re: [Wireshark-dev] [Wireshark-commits] rev 38522: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-14 Thread Michael Tüxen
On Aug 14, 2011, at 12:46 PM, Stig Bjørlykke wrote: > On Sun, Aug 14, 2011 at 12:42 PM, Michael Tüxen > wrote: >> On Aug 14, 2011, at 11:27 AM, Stig Bjørlykke wrote: >>> Try opening Capture Options a second time, and "none" is back in the list. >> Is that still true in the current version? I can'

[Wireshark-dev] Crash

2011-08-14 Thread Jonathan Camilleri
Wireshark crashed upon me, see attached. Rgds, -- Jonathan Camilleri Mobile (MT): 00356 7982 7113 E-mail: camilleri@gmail.com Please consider your environmental responsibility before printing this e-mail. I usually reply to e-mails within 2 business days. If it's urgent, give me a call. <

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-08-14 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows-7-x64 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/2722 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-

Re: [Wireshark-dev] Time shift patch causes compile error

2011-08-14 Thread Martin Kaiser
Hi Stig, all, Thus wrote Stig Bjørlykke (s...@bjorlykke.org): > Should be fixed in revision 38523. > Other issues with Time Shift should be put in bug 6179: > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6179 I get a warning (treated as an error) when I compile on Debian Lenny TShark 1.

Re: [Wireshark-dev] Time shift patch causes compile error

2011-08-14 Thread Martin Kaiser
Thus wrote Martin Kaiser (li...@kaiser.cx): > I get a warning (treated as an error) when I compile on Debian Lenny ups, that was missing, it's svn r38528 ___ Sent via:Wireshark-dev mailing list Archives:http://www.w

Re: [Wireshark-dev] Time shift patch causes compile error

2011-08-14 Thread Stig Bjørlykke
On Sun, Aug 14, 2011 at 3:11 PM, Martin Kaiser wrote: > If I enable your define for windows > > #define truncl(ld) floorl(ld) > > things work ok for me. Should that be enabled for older gccs as well or > are you aware of gcc settings that make it define truncl() in the standard > way? I don't kno

Re: [Wireshark-dev] Time shift patch causes compile error

2011-08-14 Thread Martin Kaiser
Thus wrote Stig Bjørlykke (s...@bjorlykke.org): > I don't know this code, or truncl() vs. floorl(), but maybe we just > should use floorl() on all platforms? > Then we at least get the same behavior. Haven't looked into that before things stopped compiling today ;-) gtk/time_shift_dlg.c is the o

Re: [Wireshark-dev] Time shift patch causes compile error

2011-08-14 Thread Stig Bjørlykke
On Sun, Aug 14, 2011 at 8:34 PM, Martin Kaiser wrote: > floorl() may be the better choice... I've fixed this in revision 38536. We should fix this anyway, to avoid using different functions on different platforms. -- Stig Bjørlykke __

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.6-x64

2011-08-14 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX-10.6-x64 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.6-x64/builds/3605 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.6-x64

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86

2011-08-14 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX-10.5-x86 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/4084 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-x86

[Wireshark-dev] buildbot failure in Wireshark (development) on Ubuntu-10.04-x64

2011-08-14 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Ubuntu-10.04-x64 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Ubuntu-10.04-x64/builds/2094 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: ubun

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-PowerPC

2011-08-14 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX-10.5-PowerPC while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-PowerPC/builds/3483 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-

Re: [Wireshark-dev] [Wireshark-commits] rev 37487: / /trunk/epan/dissectors/: Makefile.common packet-opensafety.c /trunk/epan/: CMakeLists.txt /trunk/: AUTHORS

2011-08-14 Thread Stig Bjørlykke
On Tue, May 31, 2011 at 9:31 PM, wrote: > Log: >  From Roland Knall: openSAFETY dissector. In packet-opensafety.c I find this code: /* pinfo is NULL only if dissect_opensafety_message is called from dissect_error cause */ if (pinfo) { col_set_str(pinfo->cinfo, COL_PROTOCOL, protocolName);