Re: [Wireshark-dev] [Wireshark-commits] rev 38522: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-15 Thread Stig Bjørlykke
On Sun, Aug 14, 2011 at 1:03 PM, Michael Tüxen michael.tue...@lurchi.franken.de wrote: * I get wrong link-layer for some of my remote (rpcap) devices.  This  used to work before. I'm still having issues with this one. The link-layer is now correct in the interfaces list, but the one listed is

[Wireshark-dev] Wireshark-commits: [Wireshark-commits] rev 38542: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gsm_a_rr.c

2011-08-15 Thread Jaap Keuter
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=38542 [1] User: etxrab Date: 2011/08/14 09:39 PM Log: From Jeremy Quirke: misdecoding 3G Neighbour Cell Information Element in SI2quater message due to a coding typo https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6237

Re: [Wireshark-dev] [Wireshark-commits] rev 38546: /trunk/gtk/ /trunk/gtk/: follow_stream.c

2011-08-15 Thread Stephen Fisher
This call: gtk_quit_add_destroy(gtk_main_level(), GTK_OBJECT(streamwindow)); Appears to tell GTK to destroy the object streamwindow if Wireshark is being closed entirely. This then calls the signal that was connected a few lines earlier: g_signal_connect(streamwindow, destroy,

Re: [Wireshark-dev] [Wireshark-commits] rev 38546: /trunk/gtk/ /trunk/gtk/: follow_stream.c

2011-08-15 Thread Bill Meier
On 8/15/2011 12:21 PM, Stephen Fisher wrote: This call: gtk_quit_add_destroy(gtk_main_level(), GTK_OBJECT(streamwindow)); Appears to tell GTK to destroy the object streamwindow if Wireshark is being closed entirely. This then calls the signal that was connected a few lines earlier:

Re: [Wireshark-dev] [Wireshark-commits] rev 38546: /trunk/gtk/ /trunk/gtk/: follow_stream.c

2011-08-15 Thread Guy Harris
On Aug 15, 2011, at 10:47 AM, Bill Meier wrote: Exiting Wireshark (with no gtk_quit_destroy()) in the follow_stream code left a file in the temp directory. Is there some reason why we don't delete the file when the {TCP,SSL} Stream window is destroyed? Presumably that window gets destroyed

Re: [Wireshark-dev] [Wireshark-commits] rev 38546: /trunk/gtk/ /trunk/gtk/: follow_stream.c

2011-08-15 Thread Bill Meier
On 8/15/2011 2:28 PM, Guy Harris wrote: On Aug 15, 2011, at 10:47 AM, Bill Meier wrote: Exiting Wireshark (with no gtk_quit_destroy()) in the follow_stream code left a file in the temp directory. Is there some reason why we don't delete the file when the {TCP,SSL} Stream window is

Re: [Wireshark-dev] [Wireshark-commits] rev 38546: /trunk/gtk/ /trunk/gtk/: follow_stream.c

2011-08-15 Thread Bill Meier
On 8/15/2011 2:54 PM, Bill Meier wrote: On 8/15/2011 2:28 PM, Guy Harris wrote: On Aug 15, 2011, at 10:47 AM, Bill Meier wrote: Exiting Wireshark (with no gtk_quit_destroy()) in the follow_stream code left a file in the temp directory. Is there some reason why we don't delete the file when

Re: [Wireshark-dev] [Wireshark-commits] rev 38546: /trunk/gtk/ /trunk/gtk/: follow_stream.c

2011-08-15 Thread Guy Harris
On Aug 15, 2011, at 11:54 AM, Bill Meier wrote: That's what I assumed expected, but it seems that the destroy callback for the window doesn't get called when the app exits since the file didn't get removed when I simply exited Wireshark by clicking the upper right corner of the main

Re: [Wireshark-dev] [Wireshark-commits] rev 38522: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-15 Thread Michael Tüxen
On Aug 15, 2011, at 9:20 AM, Stig Bjørlykke wrote: On Sun, Aug 14, 2011 at 1:03 PM, Michael Tüxen michael.tue...@lurchi.franken.de wrote: * I get wrong link-layer for some of my remote (rpcap) devices. This used to work before. I'm still having issues with this one. The link-layer is

Re: [Wireshark-dev] https access to anonsvn/viewvc?

2011-08-15 Thread Gerald Combs
On 8/9/11 10:38 AM, Jeff Morriss wrote: Hi Gerald, I accidentally ended up looking at anonsvn via https and I noticed that the format looks different. For example, compare: https://anonsvn.wireshark.org/viewvc?revision=38430view=revision to:

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.6-x64

2011-08-15 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX-10.6-x64 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.6-x64/builds/3616 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build:

[Wireshark-dev] Timeshift dialog default button: OK instead of Apply?

2011-08-15 Thread Stephen Fisher
I'm not sure what the best workflow for using the Edit - Time Shift dialog is, but it seems like once you type something in such as +1000 in the first shift all packets section, shouldn't pressing Return hit the OK button instead of Apply button? Or would the user want to keep using the

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86

2011-08-15 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder OSX-10.5-x86 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/4095 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build:

Re: [Wireshark-dev] Compiling Wireshark for Win32

2011-08-15 Thread Gerald Combs
On 8/12/11 1:25 AM, Helge Kruse wrote: @Gerald, the ZIP file with the PDBs are ~13 Megabyte in size. Would it be possible to add the import libraries to the archive in one of the next versions? The libwireshark.lib has only 266kByte while the PDB has 10MByte. I added libwireshark.lib,

Re: [Wireshark-dev] Compiling Wireshark for Win32

2011-08-15 Thread Gerald Combs
On 8/11/11 1:45 PM, Jeff Morriss wrote: That being, said, for the *NIX builds warnings as errors (-WX in the Windows case) are normally turned off for the releases. Gerald et al, is there any reason that's not done for the Windows builds? (-WX is set in trunk-1.2, trunk-1.4, trunk-1.6.)

Re: [Wireshark-dev] [Wireshark-commits] rev 38546: /trunk/gtk/ /trunk/gtk/: follow_stream.c

2011-08-15 Thread Guy Harris
On Aug 15, 2011, at 1:38 PM, Guy Harris wrote: If you close the current capture, or quit Wireshark, the window should be destroyed. Annoyingly, I couldn't find, at least in any of the official guidelines for any desktop environment I looked at (OS X, GNOME, KDE, Windows) any discussion of,

Re: [Wireshark-dev] [Wireshark-commits] rev 38546: /trunk/gtk/ /trunk/gtk/: follow_stream.c

2011-08-15 Thread Guy Harris
And then there's View Source in both Safari and Internet Explorer, where the page source window remains open even if you close the window with the page. So I'd say *don't* close the Follow Stream window if you close the capture file, but *do* catch whatever the appropriate signals are on the

Re: [Wireshark-dev] Time shift patch causes compile error

2011-08-15 Thread Dirk Jagdmann
I'm not sure if my system config or the code is at fault. truncl isn't defined anywhere in /usr/include/* except for C++ header files. Apparently, it's a gcc builtin function. I have no idea what parameters it expects. You're passing it long doubles, this is in line with the manpage. If I

Re: [Wireshark-dev] Compiling Wireshark for Win32

2011-08-15 Thread Helge Kruse
Am 16.08.2011 00:01, schrieb Gerald Combs: On 8/12/11 1:25 AM, Helge Kruse wrote: @Gerald, the ZIP file with the PDBs are ~13 Megabyte in size. Would it be possible to add the import libraries to the archive in one of the next versions? The libwireshark.lib has only 266kByte while the PDB has