Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Tony Trinh
On Fri, Oct 14, 2011 at 3:50 PM, Guy Harris wrote: > > On Oct 14, 2011, at 8:37 AM, Tony Trinh wrote: > > > Actually, the valid #define for Lua code throughout Wireshark is > HAVE_LUA_5_1 (not HAVE_LUA). HAVE_LUA works in Windows but not other OS's > (such as OSX). > > ...which probably means "su

Re: [Wireshark-dev] working with header data

2011-10-14 Thread Ed Beroset
Guy Harris wrote: On Oct 14, 2011, at 1:16 PM, Ed Beroset wrote: I did two earlier versions of the code that did something like that. One version used knowledge of what the tags are and recalculated the length based on the length of the tvb. The other one looked attempted to verify that the e

Re: [Wireshark-dev] working with header data

2011-10-14 Thread Guy Harris
On Oct 14, 2011, at 1:16 PM, Ed Beroset wrote: > I did two earlier versions of the code that did something like that. One > version used knowledge of what the tags are and recalculated the length based > on the length of the tvb. The other one looked attempted to verify that the > expected ta

Re: [Wireshark-dev] working with header data

2011-10-14 Thread Ed Beroset
Guy Harris wrote: On Oct 14, 2011, at 6:03 AM, Ed Beroset wrote: There is a portion of the code called canonify_unencrypted_header(). In order to cryptographically process the ASN.1 components of the header, the data must be canonified. To do this, the dissector must process the pieces of th

Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Guy Harris
On Oct 14, 2011, at 8:37 AM, Tony Trinh wrote: > Actually, the valid #define for Lua code throughout Wireshark is HAVE_LUA_5_1 > (not HAVE_LUA). HAVE_LUA works in Windows but not other OS's (such as OSX). ...which probably means "such as UN*Xes"; that sounds like a difference between using aut

Re: [Wireshark-dev] working with header data

2011-10-14 Thread Guy Harris
On Oct 14, 2011, at 6:03 AM, Ed Beroset wrote: > There is a portion of the code called canonify_unencrypted_header(). In > order to cryptographically process the ASN.1 components of the header, the > data must be canonified. To do this, the dissector must process the pieces > of the header i

Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Martin Mathieson
On Fri, Oct 14, 2011 at 4:37 PM, Tony Trinh wrote: > Hi Martin/Anders, > > Actually, the valid #define for Lua code throughout Wireshark is > HAVE_LUA_5_1 (not HAVE_LUA). HAVE_LUA works in Windows but not other OS's > (such as OSX). But I do like HAVE_LUA better than a version-specific name > bec

Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Tony Trinh
Hi Martin/Anders, Actually, the valid #define for Lua code throughout Wireshark is HAVE_LUA_5_1 (not HAVE_LUA). HAVE_LUA works in Windows but not other OS's (such as OSX). But I do like HAVE_LUA better than a version-specific name because I imagine these names will have to be updated upon switchin

[Wireshark-dev] working with header data

2011-10-14 Thread Ed Beroset
I've written a dissector for a protocol (ANSI C12.22) which employs cryptography for both assuring the integrity of the message (including the unencrypted header) and the confidentiality of the payload (by encrypting it). It uses what's called an AEAD (Authenticated Encryption with Associated

Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Anders Broman
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Martin Mathieson Sent: den 14 oktober 2011 14:37 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/

Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Martin Mathieson
On Fri, Oct 14, 2011 at 12:11 PM, Guy Harris wrote: > > On Oct 14, 2011, at 4:03 AM, mart...@wireshark.org wrote: > > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39422 > > > > User: martinm > > Date: 2011/10/14 04:03 AM > > > > Log: > > make_menu_items() isn't called withou

Re: [Wireshark-dev] [Wireshark-commits] rev 39422: /trunk/gtk/ /trunk/gtk/: main_menubar.c

2011-10-14 Thread Guy Harris
On Oct 14, 2011, at 4:03 AM, mart...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39422 > > User: martinm > Date: 2011/10/14 04:03 AM > > Log: > make_menu_items() isn't called without LUA support, so can't be static. Yes, it can; the only reason it co

Re: [Wireshark-dev] include "tvbuff.h" failed

2011-10-14 Thread Helge Kruse
Original-Nachricht > Datum: Wed, 12 Oct 2011 09:04:42 +0200 > Von: Marcel Haas > An: Developer support list for Wireshark > Betreff: Re: [Wireshark-dev] include "tvbuff.h" failed > > #ifdef HAVE_CONFIG_H > #include "config.h" > #endif You should remove the "#ifdef HAVE_CO

Re: [Wireshark-dev] compile warning/error on current svn (make_menu_actions)

2011-10-14 Thread Anders Broman
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Guy Harris Sent: den 14 oktober 2011 11:09 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] compile warning/error on current svn (make_menu_action

Re: [Wireshark-dev] compile warning/error on current svn (make_menu_actions)

2011-10-14 Thread Guy Harris
On Oct 14, 2011, at 1:46 AM, Martin Kaiser wrote: > Should we have #ifdef HAVE_LUA_5_1 around the function definition as > well? Speaking of that, why is this dependent on the Lua *version*? Do we not support adding menu items with earlier versions of Lua? _

[Wireshark-dev] compile warning/error on current svn (make_menu_actions)

2011-10-14 Thread Martin Kaiser
Dear all, compiling r39420 fails for me on redhat fc 15. main_menubar.c:3698:1: error: 'make_menu_actions' defined but not used [-Werror=unused-function] In main_menubar.c, the only place where make_menu_actions() is called is inside an #ifdef HAVE_LUA_5_1. Should we have #ifdef HAVE_LUA_5_1 ar

Re: [Wireshark-dev] complex problem

2011-10-14 Thread Marcel Haas
On Thu, 13 Oct 2011 09:03:38 -0400, Jeff Morriss wrote: Marcel Haas wrote: Hey, maybe the problem isnt so complex to solve but its complex for me to explain. :) I have written my own reassemble code and it seems to work. But i have one big problem. If i set the filter and click apply, it work