Re: [Wireshark-dev] Logical error in r37159

2012-02-09 Thread Joerg Mayer
On Thu, Feb 09, 2012 at 06:20:22PM -0500, Sean Bright wrote: > The logic, however, was not negated properly. The correct assertion should > be: > > g_assert(rtp_channels->stop || rtp_channels->pause); > > With the current code, the RTP player causes a crash for me when pressing the > 'Play

[Wireshark-dev] Logical error in r37159

2012-02-09 Thread Sean Bright
In r37159, the following change was made to ui/gtk/rtp_player.c: @@ -1654,9 +1636,7 @@ GtkWidget *dialog; /* we should never be here if we are in PLAY and !PAUSE */ - if(!rtp_channels->stop&& !rtp_channels->pause){ - exit(10); - } + g_assert(!rtp_

Re: [Wireshark-dev] 1.7.1 bug? tcp.flags == 0x8c2

2012-02-09 Thread Christopher Maynard
Lanell Allen writes: > [SYN, ECN, CWR] > > The "tcp.flags == 0x8c2" filter > crashes on v. 1.7. Stays "pink" with the error message "invalid > filter" / "too big", etc. > Works fine on 1.6.1 and 1.6.4Lanell Allen, WCNA Well first off, that filter is incorrect if you're trying to match packets w

[Wireshark-dev] 1.7.1 bug? tcp.flags == 0x8c2

2012-02-09 Thread Lanell Allen
[SYN, ECN, CWR] > > The "tcp.flags == 0x8c2" filter crashes on v. 1.7. Stays "pink" with the > error message "invalid filter" / "too big", etc. > Works fine on 1.6.1 and 1.6.4 > > Lanell Allen, WCNA ___ Sent via:Wiresha

Re: [Wireshark-dev] [Wireshark-commits] rev 40877: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dns.c

2012-02-09 Thread Jeff Morriss
Joerg Mayer wrote: On Wed, Feb 08, 2012 at 09:16:48AM -0500, Jeff Morriss wrote: Joerg Mayer wrote: [...] So more than half of all the stuff is added by using proto_tree_add_text. As long as the ratio is that way, people are likely to continue using it inside this dissector. Any volunteer(s) to