Re: [Wireshark-dev] Wireshark ABI compatibilty in release branches

2013-01-21 Thread Bálint Réczey
Hi, 2013/1/20 Jaap Keuter > On 01/18/2013 08:05 PM, Evan Huus wrote: > > On Fri, Jan 18, 2013 at 1:12 PM, Bálint Réczey > wrote: > >> Hi, > >> > >> I think we did a very good job in maintaining backward compatibility > >> in 1.6.x and 1.8.x releases [1]. > >> > >> In >1.6.1 there were no back

Re: [Wireshark-dev] PCAPng Name Resolution Blocks

2013-01-21 Thread Jeff Morriss
Jasper Bongertz wrote: Hi all, can anyone tell me when Wireshark/Dumpcap will actually write a Name Resolution Block to a pcapng file? I have a file written with an older dumpcap version (I guess it was pre 1.8) that contains a NRB but the latest 1.9 build doesn't seem to do that at all. I trie

Re: [Wireshark-dev] [Wireshark-commits] rev 47188: /trunk/ui/gtk/ /trunk/ui/gtk/: main.c

2013-01-21 Thread Graham Bloice
On 21 January 2013 17:27, Dirk Jagdmann wrote: > the logical and is the very same in both revisions. But what makes this > code > confusing is the use of "prefs.capture_device" in one place and then > "prefs_p->capture_device" in another. Maybe what you really want is > > if ((global_capture_opts

Re: [Wireshark-dev] [Wireshark-commits] rev 47188: /trunk/ui/gtk/ /trunk/ui/gtk/: main.c

2013-01-21 Thread Dirk Jagdmann
the logical and is the very same in both revisions. But what makes this code confusing is the use of "prefs.capture_device" in one place and then "prefs_p->capture_device" in another. Maybe what you really want is if ((global_capture_opts.num_selected == 0) && (prefs.capture_device != NULL) &&