Re: [Wireshark-dev] asn1 plugin

2013-10-21 Thread Anders Broman
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Ed Beroset Sent: den 19 oktober 2013 20:24 To: wireshark-dev@wireshark.org Subject: [Wireshark-dev] asn1 plugin Recently, while I was working on unit tests for oids.c

Re: [Wireshark-dev] asn1 plugin

2013-10-21 Thread Evan Huus
On Mon, Oct 21, 2013 at 8:41 AM, Anders Broman anders.bro...@ericsson.com wrote: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Ed Beroset Sent: den 19 oktober 2013 20:24 To: wireshark-dev@wireshark.org Subject:

[Wireshark-dev] FW: [Wireshark-commits] rev 52730: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-cdp.c

2013-10-21 Thread Anders Broman
Hi, Anders, this may be related to your recent TVB optimizations, since I don't think it happened before that? Did you change the behaviour of tvb_find_line_end or its callees at all? Not intentionally ;-) I just expanded some code inside the function and used tvb_pbrk_guint8_within_tvb()

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-10-21 Thread mmann78
These are independent of the bugs logged to Bugzilla, correct? -Original Message- From: Matthieu Patou m...@samba.org To: Joerg Mayer jma...@loplof.de Cc: Developer support list for Wireshark wireshark-dev@wireshark.org; Samba Technical samba-techni...@samba.org; Andrew Bartlett

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-10-21 Thread mmann78
Checked most of the patches into r52744 (http://anonsvn.wireshark.org/viewvc?view=revisionrevision=52744) Didn't integrate 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch 0016-Regenerate-the-dnserver.patch due to compile errors on Windows from applying the patch in bug 9301

[Wireshark-dev] Fwd: [Wireshark-commits] rev 52741: Add APIs for PIDL generated code to return the value of the integer that was dissected.

2013-10-21 Thread Anders Broman
Hi, Shouldn't something generic based on proto_tree_add_bits_ret_val() be used instead? Regards Anders Ursprungligt meddelande Ämne: [Wireshark-commits] rev 52741: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dcerpc-ndr.c packet-dcerpc.h Datum: Mon, 21 Oct

Re: [Wireshark-dev] [Wireshark-commits] rev 52701: /trunk/epan/ /trunk/epan/: oids_test.c

2013-10-21 Thread Joerg Mayer
On Sun, Oct 20, 2013 at 02:18:19AM +, eapa...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=52701 User: eapache Date: 2013/10/20 02:18 AM Log: Don't use g_assert_cmpint, it isn't happy on Windows. g_assert is nearly as good except it doesn't

Re: [Wireshark-dev] FW: [Wireshark-commits] rev 52730: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-cdp.c

2013-10-21 Thread Jakub Zawadzki
Hi, User: eapache Date: 2013/10/21 01:07 PM Log: Don't go into a loop if we find a zero-length line. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9312 Anders, this may be related to your recent TVB optimizations, since I don't think it happened before that? Did you

Re: [Wireshark-dev] [Wireshark-commits] rev 52701: /trunk/epan/ /trunk/epan/: oids_test.c

2013-10-21 Thread Ed Beroset
Joerg Mayer wrote: On Sun, Oct 20, 2013 at 02:18:19AM +, eapa...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=52701 User: eapache Date: 2013/10/20 02:18 AM Log: Don't use g_assert_cmpint, it isn't happy on Windows. g_assert is nearly as good

Re: [Wireshark-dev] [Wireshark-commits] rev 52701: /trunk/epan/ /trunk/epan/: oids_test.c

2013-10-21 Thread Evan Huus
On Oct 21, 2013, at 4:51 PM, Ed Beroset bero...@mindspring.com wrote: Joerg Mayer wrote: On Sun, Oct 20, 2013 at 02:18:19AM +, eapa...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=52701 User: eapache Date: 2013/10/20 02:18 AM Log: Don't use

[Wireshark-dev] Coverity warning in tshark.c

2013-10-21 Thread Joerg Mayer
Looks like coverity has a valid complaint: CID 1109702: Dereference after null check (FORWARD_NULL) /tshark.c: 2859 ( var_compare_op) 2856 /* If we're going to print packet information, or we're going to 2857 run a read filter, or we're going to process taps, set up to 2858

Re: [Wireshark-dev] Wireshark PIDL generated dissectors

2013-10-21 Thread Joerg Mayer
On Mon, Oct 21, 2013 at 03:48:35PM -0400, mman...@netscape.net wrote: Checked most of the patches into r52744 (http://anonsvn.wireshark.org/viewvc?view=revisionrevision=52744) Didn't integrate 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch

[Wireshark-dev] Minor Samba Licensing Question

2013-10-21 Thread Evan Huus
Hello Samba folks. I was poking through the recent changes being landed to PIDL in Wireshark (thank you for those!) and noticed that one of the files was being picked up as unlicensed by our buildbot. Specifically: 'epan/dissectors/pidl/idl_types.h' has non-whitelisted license 'UNKNOWN' A bit of

Re: [Wireshark-dev] Fwd: [Wireshark-commits] rev 52741: Add APIs for PIDL generated code to return the value of the integer that was dissected.

2013-10-21 Thread mmann78
These PIDL APIs do a wrapper of add integer to tree + add integer to column (info) data, not just a simple add integer to tree, return value -Original Message- From: Anders Broman a.bro...@bredband.net To: Developer support list for Wireshark wireshark-dev@wireshark.org Sent: Mon, Oct