On 06/18/14 10:14, Wireshark code review wrote:
URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=246fe2ca4c67d8c98caa84e2f57694f6322e2f96
Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark
Commits:
246fe2c by Dario Lombardo
Yeah, I figured backing it out would be easy enough but I wanted to
(re)start the conversation. I also wasn't sure if the question had been
discussed at Sharkfest (where a bunch of the core developers are now).
On 06/19/14 11:52, Dario Lombardo wrote:
I made the push before Evan's comment.
On Jun 19, 2014, at 11:26 AM, Wireshark code review
code-review-do-not-re...@wireshark.org wrote:
URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14824e6adf07a1c3cfb6537ce8723d873ecd0d0f
Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
On Thu, Jun 19, 2014 at 12:16 PM, Guy Harris g...@alum.mit.edu wrote:
On Jun 19, 2014, at 11:26 AM, Wireshark code review
code-review-do-not-re...@wireshark.org wrote:
URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=14824e6adf07a1c3cfb6537ce8723d873ecd0d0f
As a result of discussion at Sharkfest this week I've made the following
changes on bugs.wireshark.org:
- Added a WONTFIX resolution to Bugzilla.
- Split the Wireshark component into GTK+ UI and Qt UI.
This lets us categorize bugs more accurately and close out bugs that
won't be fixed given the
Le 19/06/2014 00:14, Pascal Quantin a écrit :
Indeed the sample code in README.dissector was not updated to make use
of the new style dissectors (while packet-PROTOABBREV.c sample code is
updated).
As Graham stated, the new style (indicating the number of bytes
consumed by the dissector)
Another possible improvement, rather than g_mallocing the elements in the
hash table, we could put them in the pinfo pool, which is always freed when
proto_tree_reset or proto_tree_free are called...
On Thu, Jun 19, 2014 at 4:33 PM, Wireshark code review
code-review-do-not-re...@wireshark.org
