Re: [Wireshark-dev] [Wireshark-announce] Wireshark 1.12.0rc3 is now available

2014-07-30 Thread Guy Harris
On Jul 30, 2014, at 2:35 PM, Gerald Combs wrote: > "git-export-release.sh" is missing: > - ./configure, install-sh, other Autotoolery > - Files generated using Bison/Flex > - help/faq.txt > - packaging/macosx/Info.plist > - plugins/*/plugin.c > - ui/*/*shark-tap-register.c Can that be rew

Re: [Wireshark-dev] [Wireshark-announce] Wireshark 1.12.0rc3 is now available

2014-07-30 Thread Gerald Combs
On 7/28/14 7:34 AM, Jeff Morriss wrote: > On 07/27/14 13:34, Bálint Réczey wrote: >> 2014-07-25 23:49 GMT+02:00 Jeff Morriss : >>> On 07/22/14 16:27, Wireshark announcements wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm proud to announce the release of Wireshark

Re: [Wireshark-dev] switching to proto_tree_add_subtree()

2014-07-30 Thread Jeff Morriss
On 07/30/14 14:02, darkjames...@darkjames.pl wrote: On Wed, Jul 30, 2014 at 11:23:55AM -0400, Jeff Morriss wrote: On 07/30/14 01:30, darkjames...@darkjames.pl wrote: On Tue, Jul 29, 2014 at 06:47:53PM -0400, Jeff Morriss wrote: Does this mean that this code in add_subtree_format() should be

Re: [Wireshark-dev] switching to proto_tree_add_subtree()

2014-07-30 Thread darkjames-ws
On Wed, Jul 30, 2014 at 11:23:55AM -0400, Jeff Morriss wrote: > On 07/30/14 01:30, darkjames...@darkjames.pl wrote: > >On Tue, Jul 29, 2014 at 06:47:53PM -0400, Jeff Morriss wrote: > >>Does this mean that this code in add_subtree_format() should be > >>setting *tree_item to 'tree' (instead of NULL

[Wireshark-dev] Compile error in tap-iousers.c

2014-07-30 Thread Joerg Mayer
[ 81%] Building C object CMakeFiles/tfshark.dir/ui/cli/tap-iousers.c.o /home/jmayer/work/wireshark/git/ui/cli/tap-iousers.c: In function ‘iousers_draw’: /home/jmayer/work/wireshark/git/ui/cli/tap-iousers.c:106:5: error: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘guint64’

Re: [Wireshark-dev] switching to proto_tree_add_subtree()

2014-07-30 Thread Jeff Morriss
On 07/30/14 01:30, darkjames...@darkjames.pl wrote: Hi, On Tue, Jul 29, 2014 at 06:47:53PM -0400, Jeff Morriss wrote: However, I don't quite understand why for tree!=NULL but not visible, proto_tree_add_text() returns tree. I can see this in the code, we call TRY_TO_FAKE_THIS_ITEM(), which retu

Re: [Wireshark-dev] Help Regarding AIRPDCAP_DEBUG_PRINT_LINE

2014-07-30 Thread Peter Wu
On Wednesday 30 July 2014 17:11:30 Ashok Kumar wrote: > I am interested in getting prints AIRPDCAP_DEBUG_PRINT_LINE. > Can anyone help me in enabling this prints and where we can see this print > outputs. $ grep -rwn AIRPDCAP_DEBUG_PRINT_LINE . ... epan/crypt/airpdcap_debug.h:44:#define AIRPDCAP_

Re: [Wireshark-dev] switching to proto_tree_add_subtree()

2014-07-30 Thread mmann78
proto_tree_add_subtree should be proto_tree_add_text + proto_item_add_subtree (where the return value of proto_tree_add_text is input to proto_item_add_subtree). When I originally created proto_tree_add_subtree, I thought it would be "more optimized" to include the function body of proto_tre

[Wireshark-dev] Help Regarding AIRPDCAP_DEBUG_PRINT_LINE

2014-07-30 Thread Ashok Kumar
Hi, I am interested in getting prints AIRPDCAP_DEBUG_PRINT_LINE. Can anyone help me in enabling this prints and where we can see this print outputs. is it possible to any other kinds of prints to airpdcap files and use it for debugging. Kindly let me know in case of any issues. Thanks and Regard