Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-23 Thread Thomas Wiens
On 22 August 2014 16:44, Bill Meier wrote: See my comment to you on the new patch https://code.wireshark.org/review/#/c/3794/ I've got a question to the Reply 'Done' Button in gerrit. Should I use it when I think I've fixed what's mentioned in the comment, or is/should it done by the one

Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-23 Thread mmann78
The Reply 'Done' Button can be used by the developer making the changes, but it doesn't have to be. There just needs to be some indication that it's been addressed (Reply Done or a comment posted after another patch is uploaded is fine) to make the next review go faster. In this particular

Re: [Wireshark-dev] Qt License Change

2014-08-23 Thread Joerg Mayer
On Thu, Aug 21, 2014 at 02:30:49PM +0100, Tyson Key wrote: I'm not a lawyer - but judging by that post, and the statements ...we are now adding LGPL v3 as a licensing option to Qt 5.4 in addition to LGPL v2.1, and All modules that existed in Qt 5.3 will still be available under LGPL v2.1. So