[Wireshark-dev] Expert "name" field in same name space as hf[] "abbrev" field ?

2014-08-25 Thread Bill Meier
Since both the ei_register_info "'name' field and the hf_register_info 'abbrev' field can be used as filters I expect that they effectively are in the same name space and thus there should not be a matching 'name'/'abbrev' between the ei[] entries and the hf[] entries in a dissector. Is this

Re: [Wireshark-dev] Adding trace to buildbot for fuzz testing

2014-08-25 Thread Bill Meier
On 8/25/2014 3:37 PM, Stalley, Sean wrote: Hello All, I have a trace that I would like to add to the buildbot for regression testing. I uploaded it here: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=13015&action=edit Is there a way I can add this trace to the list of traces that the b

[Wireshark-dev] Adding trace to buildbot for fuzz testing

2014-08-25 Thread Stalley, Sean
Hello All, I have a trace that I would like to add to the buildbot for regression testing. I uploaded it here: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=13015&action=edit Is there a way I can add this trace to the list of traces that the buildbot runs? Thanks, Sean

Re: [Wireshark-dev] Adding trace to buildbot for fuzz testing

2014-08-25 Thread Evan Huus
If things are working normally, it will get picked up automatically. On Mon, Aug 25, 2014 at 3:37 PM, Stalley, Sean wrote: > Hello All, > > I have a trace that I would like to add to the buildbot for regression > testing. I uploaded it here: > > https://bugs.wireshark.org/bugzilla/attachment.cgi?

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Graham Bloice
On 25 August 2014 20:03, Joerg Mayer wrote: > On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote: > > When reviewing some submissions on Gerrit, I've noted a few with trailing > > whitespace. The git pre-commit hook always warns me of this, so how are > > folks managing to do this? A

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Joerg Mayer
On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote: > When reviewing some submissions on Gerrit, I've noted a few with trailing > whitespace. The git pre-commit hook always warns me of this, so how are > folks managing to do this? Are they using clients that ignore the hook? How about

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Bill Meier
On 8/25/2014 1:48 PM, Alexis La Goutte wrote: Should we add some info then to the Dev Guide as to where to get the hook, It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup We keep running into this problem - should the wiki page and the dev guide be consolidated? a

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Alexis La Goutte
On Mon, Aug 25, 2014 at 7:32 PM, Evan Huus wrote: > On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice > wrote: >> On 25 August 2014 18:17, Graham Bloice wrote: >>> >>> On 25 August 2014 18:11, Juan Jose Martin Carrascosa >>> wrote: I think that you are talking about my just committed cha

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Evan Huus
On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice wrote: > On 25 August 2014 18:17, Graham Bloice wrote: >> >> On 25 August 2014 18:11, Juan Jose Martin Carrascosa >> wrote: >>> >>> I think that you are talking about my just committed changes. I just did >>> it and I just checked in the website tha

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Graham Bloice
On 25 August 2014 18:17, Graham Bloice wrote: > On 25 August 2014 18:11, Juan Jose Martin Carrascosa > wrote: > >> I think that you are talking about my just committed changes. I just did >> it and I just checked in the website that it has the whitespaces... >> >> As Evan said, I don't have it i

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Graham Bloice
On 25 August 2014 18:11, Juan Jose Martin Carrascosa wrote: > I think that you are talking about my just committed changes. I just did > it and I just checked in the website that it has the whitespaces... > > As Evan said, I don't have it installed by default and I wasn't really > aware of the pr

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Juan Jose Martin Carrascosa
I think that you are talking about my just committed changes. I just did it and I just checked in the website that it has the whitespaces... As Evan said, I don't have it installed by default and I wasn't really aware of the process (even reading the doc a couple of times). I am really sorry. I w

[Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Graham Bloice
When reviewing some submissions on Gerrit, I've noted a few with trailing whitespace. The git pre-commit hook always warns me of this, so how are folks managing to do this? Are they using clients that ignore the hook? -- Graham Bloice

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Evan Huus
Probably they are simply not installing the hook - none of our tooling sets it up by default that I'm aware of. On Mon, Aug 25, 2014 at 1:06 PM, Graham Bloice wrote: > When reviewing some submissions on Gerrit, I've noted a few with trailing > whitespace. The git pre-commit hook always warns me

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2014-08-25 Thread Martin Kaiser
sorry, my fault I merge two things in the wrong order master should build ok now Thus wrote buildbot-no-re...@wireshark.org (buildbot-no-re...@wireshark.org): > The Buildbot has detected a new failure on builder OSX 10.6 x64 while > building wireshark. > Full details are available at: > http:/

Re: [Wireshark-dev] Should labels in the tree view for the 802.11ad dissector additions conform to the spec?

2014-08-25 Thread Richard Sharpe
Oops, screen shot now attached ... On Mon, Aug 25, 2014 at 12:39 AM, Anders Broman wrote: > > > > > From: wireshark-dev-boun...@wireshark.org > [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Richard Sharpe > Sent: den 25 augusti 2014 00:06 > To: Developer support list for Wireshark > S

Re: [Wireshark-dev] Should labels in the tree view for the 802.11ad dissector additions conform to the spec?

2014-08-25 Thread Anders Broman
From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Richard Sharpe Sent: den 25 augusti 2014 00:06 To: Developer support list for Wireshark Subject: [Wireshark-dev] Should labels in the tree view for the 802.11ad dissector additions conform to the