Re: [Wireshark-dev] reassembly, addresses, hash calculation

2014-10-05 Thread Evan Huus
Those lines were added earlier this year by Guy Martin (who I've explicitly copied on this email). The justification in the commit message at the time was: If an mp2t packet contains one full subpacket and the fragment of another one, it happens that the first subpacket will set src or dst to an e

[Wireshark-dev] reassembly, addresses, hash calculation

2014-10-05 Thread Martin Kaiser
Hi, when I looked at bug 10505, I noticed the following code in packet-mp2t.c /* It's possible that a fragment in the same packet set an address already * This will change the hash value, we need to make sure it's NULL */ SET_ADDRESS_HF(&pinfo->src, AT_NONE, 0, NULL, 0); SET_ADD