Re: [Wireshark-dev] Code Contribution

2015-06-06 Thread Anil
Adam, I recently submitted some code to wireshark. I found that the process is simple. Can you share the link where you found the instructions? This is what I do (This may have some mistakes, but it worked). 1) git clone git clone https://code.wireshark.org/review/wireshark 2) Install

Re: [Wireshark-dev] Code Contribution

2015-06-06 Thread Alexis La Goutte
On Fri, Jun 5, 2015 at 10:09 PM, Adam Pridgen adam.prid...@thecoverofnight.com wrote: Hello, Hi Adam, I would like to make a minor code contribution that allows TLS1.1/1.2 traffic to be decrypted with a known PMS. I have read over the Gerritt submission process twice, and I am not sure

Re: [Wireshark-dev] Planning the next major release

2015-06-06 Thread Bálint Réczey
2015-06-06 11:23 GMT+02:00 Alexis La Goutte alexis.lagou...@gmail.com: Hi, On Fri, Jun 5, 2015 at 3:39 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi, 2015-06-04 23:58 GMT+02:00 Gerald Combs ger...@wireshark.org: We often make major releases in June, just before Sharkfest. That

Re: [Wireshark-dev] Planning the next major release

2015-06-06 Thread Alexis La Goutte
Hi, On Fri, Jun 5, 2015 at 3:39 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi, 2015-06-04 23:58 GMT+02:00 Gerald Combs ger...@wireshark.org: We often make major releases in June, just before Sharkfest. That probably won't happen this year. A major release now would mean either

Re: [Wireshark-dev] Code Contribution

2015-06-06 Thread Adam Pridgen
Anil, Thanks for the break down. One final question, how do I set up an account to submit code.wireshark.com, or do I even need too? Thanks, -- Adam On Sat, Jun 6, 2015 at 3:10 AM, Anil anilkumar...@gmail.com wrote: Adam, I recently submitted some code to wireshark. I found that the

Re: [Wireshark-dev] [Wireshark-commits] master b5b3a6b: ISAKMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

2015-06-06 Thread Pascal Quantin
Hi Martin, 2015-06-06 16:59 GMT+02:00 Martin Mathieson martin.r.mathie...@googlemail.com: This is only a dead store if HAVE_LIBGCRYPT is not defined... Fixed in gbe701f6. Pascal. Martin On Sat, Jun 6, 2015 at 12:52 PM, Wireshark code review code-review-do-not-re...@wireshark.org

Re: [Wireshark-dev] [Wireshark-commits] master b5b3a6b: ISAKMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

2015-06-06 Thread Martin Mathieson
This is only a dead store if HAVE_LIBGCRYPT is not defined... Martin On Sat, Jun 6, 2015 at 12:52 PM, Wireshark code review code-review-do-not-re...@wireshark.org wrote: URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5b3a6b9af2c8f72342cac51207346011148404d

Re: [Wireshark-dev] Code Contribution

2015-06-06 Thread Gerald Combs
Short answer: Go to https://code.wireshark.org/review/login/ and log in using your Google, GitHub, or an OpenID account. The long answer involves OpenID, OAuth, a group in very large company deprecating one of its authentication services, a different group in *that same very large company*

Re: [Wireshark-dev] Code Contribution

2015-06-06 Thread Adam Pridgen
Gotcha. I think I have all the info to do the commit now. I appreciate the guidance everyone. -- Adam On Sat, Jun 6, 2015 at 11:17 AM, Gerald Combs ger...@wireshark.org wrote: Short answer: Go to https://code.wireshark.org/review/login/ and log in using your Google, GitHub, or an OpenID