Re: [Wireshark-dev] overriding built-in dissector

2015-11-30 Thread Roland Knall
As far as I know, overriding a default dissector is not possible, or more precise not necessarily very easy. But what you could do is, to implement a generic heuristic entry point in the dis dissector, which then in turn you could use to let your custom plugin take over the dissection from the dis

[Wireshark-dev] overriding built-in dissector

2015-11-30 Thread Alan Partis
I need some direction from some folks smarter than me: I need to understand, and possibly make some customizations to, the DIS dissector (packet-dis.c). I understand that I can make those changes and run the full wireshark build, but that can be a very laborious and time-consuming task. Conseque

Re: [Wireshark-dev] wiretap - using as a library rather than coupled with Wireshark?

2015-11-30 Thread Richard Kinder
Hi Guy, Tim, Thanks for this input. I think modification of editpcap is the best path forward for this problem. The files I'm looking at converting are indeed Airopeek, so I'll need to add support for translation of the peek* metadata to radiotap. Any pointers as to where to start, architectur

[Wireshark-dev] Clang Code Analysis buildbot upgrade

2015-11-30 Thread Gerald Combs
I managed to get clang / llvm 3.7 installed on the Code Analysis builder. It's not yet compiling cleanly due to unused-arguments, no-parentheses-equality, shorten-64-to-32, self-assign, and other errors but it should hopefully be building soon. This also means that we should be able to add ASAN che

Re: [Wireshark-dev] Moving codecs to libwireshark or libwsutil?

2015-11-30 Thread Guy Harris
On Nov 30, 2015, at 11:07 AM, Pascal Quantin wrote: > Yes I should have been clearer in my initial description. > My suggestion with an extra parameter giving the hash table address is also > working fine, so I do not have a strong feeling either way (the changed > parameter is faster to do

Re: [Wireshark-dev] Moving codecs to libwireshark or libwsutil?

2015-11-30 Thread Pascal Quantin
Le 30 nov. 2015 8:01 PM, "Guy Harris" a écrit : > > > On Nov 30, 2015, at 6:40 AM, Pascal Quantin wrote: > > > Should we move codecs functions to one of the existing libraries? Or add it to its own? > > They already *are* in their own library, but it's a static library, not a dynamic library; per

Re: [Wireshark-dev] Moving codecs to libwireshark or libwsutil?

2015-11-30 Thread Guy Harris
On Nov 30, 2015, at 6:40 AM, Pascal Quantin wrote: > Should we move codecs functions to one of the existing libraries? Or add it > to its own? They already *are* in their own library, but it's a static library, not a dynamic library; perhaps we should just make libcodec a dynamic library, and

Re: [Wireshark-dev] Moving codecs to libwireshark or libwsutil?

2015-11-30 Thread Pascal Quantin
2015-11-30 15:40 GMT+01:00 Pascal Quantin : > Hi all, > > I tried to create a codecs plugin for Windows, but the plugin registration > fails. > > As reported previously on this list ( > https://www.wireshark.org/lists/wireshark-dev/201409/msg00043.html), this > because the plugin itself ends with

[Wireshark-dev] Moving codecs to libwireshark or libwsutil?

2015-11-30 Thread Pascal Quantin
Hi all, I tried to create a codecs plugin for Windows, but the plugin registration fails. As reported previously on this list ( https://www.wireshark.org/lists/wireshark-dev/201409/msg00043.html), this because the plugin itself ends with its own copy of register_codec function instead of using on

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Dario Lombardo
On Mon, Nov 30, 2015 at 12:11 PM, Graham Bloice wrote: > Unfortunately I've never run git over http(s), so have no advice to > offer. I suggest you continue without the luxury of git-review for the > moment. > > A quick hack for pushing to gerrit without git-review is to add this to .gitconfig

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Alexis La Goutte
if you go on Projets => General => Wireshark You have the list of URL (SSH / HTTPS) and it is : git clone https://usern...@code.wireshark.org/review/wireshark for http(s) Regards, On Mon, Nov 30, 2015 at 12:11 PM, Graham Bloice wrote: > > > On 30 November 2015 at 10:58, Paul Offord > wrote:

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Graham Bloice
On 30 November 2015 at 10:58, Paul Offord wrote: > Hi Graham, > > > > OK – I’ve tried all of the changes below but still no joy. So, how do I > do this with HTTPS connections instead? I’ve tried: > > > > C:\Development\Wireshark>git remote set-url origin > https://code.wireshark.org/USERNAME/wi

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Paul Offord
Hi Graham, OK – I’ve tried all of the changes below but still no joy. So, how do I do this with HTTPS connections instead? I’ve tried: C:\Development\Wireshark>git remote set-url origin https://code.wireshark.org/USERNAME/wireshark but that doesn’t work. If I try this URL through a browser

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Graham Bloice
On 30 November 2015 at 09:04, Paul Offord wrote: > Just to complete the story so far. SSH appears to be set up correctly. I > get this: > > > > C:\Development\Wireshark>ssh -p 29418 usern...@code.wireshark.org > > Enter passphrase for key '/home/my_userid/.ssh/id_rsa': > > > > Welcome

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Anders Broman
Hi, Have you tried GIT GUI that worked better for me…You need your HTTP password from “settings” on gerrit. Regards Anders From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Paul Offord Sent: den 30 november 2015 10:04 To: Developer support list f

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Paul Offord
Just to complete the story so far. SSH appears to be set up correctly. I get this: C:\Development\Wireshark>ssh -p 29418 usern...@code.wireshark.org Enter passphrase for key '/home/my_userid/.ssh/id_rsa': Welcome to Gerrit Code Review Hi Paul Offord, you have successfully

Re: [Wireshark-dev] Setting up git for gerrit

2015-11-30 Thread Paul Offord
Hi Graham, That may explain why I am having a frustrating time with this. I’ve spent about 6 hours so far trying to push a fix to gerrit – I had all but given up. In answer to your questions: ·git --version is git version 2.6.2.windows.1 ·git-review --version is git-review v