Re: [Wireshark-dev] Question on payload reassembly

2016-07-28 Thread John Dunlop
Thanks Roland/Jeff for the responses, much appreciated. So spent a bit of time debugging this and it looks like we fail sometimes to return a valid frag_msg from a call to fragment_add_seq_check() when more_frags is set to false. In the case this happens I am currently failing to see much diff

Re: [Wireshark-dev] Question on payload reassembly

2016-07-28 Thread Roland Knall
Hi Just a short question, does your sequence counter repeat? If so, this can be an issue. Also, for the openSAFETY dissector it only worked properly, after I implemented fragment_add_seq_offset, so it will allways count internally beginning with 0. You can see that in line 1272 of packet-opensafet

Re: [Wireshark-dev] Question on payload reassembly

2016-07-28 Thread Jeff Morriss
On Thu, Jul 28, 2016 at 8:35 AM, John Dunlop wrote: > Hi, > > > > Hope someone can help me with a question of payload reassembly. > > > > First up, I have been trawling the e-mail archives to find an equivalent > answer and was wondering if there is a better way of searching the e-mail > archives

[Wireshark-dev] Question on payload reassembly

2016-07-28 Thread John Dunlop
Hi, Hope someone can help me with a question of payload reassembly. First up, I have been trawling the e-mail archives to find an equivalent answer and was wondering if there is a better way of searching the e-mail archives than opening up each individual month/year? Now my actual question is