Re: [Wireshark-dev] Where to put my wiretap plugin?

2018-01-19 Thread Jaap Keuter
On 19-01-18 04:46, João Valverde wrote: > If the plugin is loaded I don't see how the build system could have any > influence either. Hi João, That was what puzzled met too... I started to dig down further and found that indeed the plugin was loaded (obviously) and they are called to register the

Re: [Wireshark-dev] Question about git style

2018-01-19 Thread Dario Lombardo
OK On Thu, Jan 18, 2018 at 7:09 PM, Jaap Keuter wrote: > On 07-01-18 22:36, Dario Lombardo wrote: > > If I'm not mistaken, that is not requested. A draft change in gerrit is > a change > > sent to the special branch refs/drafts/master. This is a real draft, that > > differs from a regular change

Re: [Wireshark-dev] Adding support for a new PCAP-NG block

2018-01-19 Thread Guy Harris
On Jan 17, 2018, at 4:47 AM, Paul Offord wrote: > I want to make a start on the plan below. Last night I took a look at the > relevant code. > > I started by adding support for TSDBs into the function pcapng_open(…) in > pcapng.c The *first* thing to do is to start by either 1) get

Re: [Wireshark-dev] Adding support for a new PCAP-NG block

2018-01-19 Thread Guy Harris
On Jan 19, 2018, at 12:24 AM, Guy Harris wrote: > On Jan 17, 2018, at 4:47 AM, Paul Offord wrote: > >> I want to make a start on the plan below. Last night I took a look at the >> relevant code. >> >> I started by adding support for TSDBs into the function pcapng_open(…) in >> pcapng.c > >

Re: [Wireshark-dev] Where to put my wiretap plugin?

2018-01-19 Thread João Valverde
Right, well done on the analysis. The make-plugin-reg.py script wants to be passed "plugin_wtap" for wiretap. On 19-01-2018 08:02, Jaap Keuter wrote: On 19-01-18 04:46, João Valverde wrote: If the plugin is loaded I don't see how the build system could have any influence either. Hi João, Th

Re: [Wireshark-dev] Where to put my wiretap plugin?

2018-01-19 Thread Jaap Keuter
Hi, I’m working on a solution, basically moving the plugin.c rule in an intermediate Makefile.am.inc in plugins/epan, plugins/wiretap, plugins/codecs. When it works I’ll push it as a separate change. Thanks, Jaap > On 19 Jan 2018, at 12:10, João Valverde > wrote: > > Right, well done on th

[Wireshark-dev] Outstanding changes I would like to get in ...

2018-01-19 Thread Richard Sharpe
Hi folks, I have the 802.11ax stuff that would be good to get into 2.5.x, however, there is a plugfest of sorts going on next week where there should be lots of feedback. I have some changes to the radiotap HE info to reduce confusioin, but those can go in as updates. I also have some cleanup st

Re: [Wireshark-dev] Outstanding changes I would like to get in ...

2018-01-19 Thread Alexis La Goutte
Hi Richard, the 2.5.0 is dev release (pre-beta or RC...) it will be possible to merge enhance and fix for final release (2.6) on May/June. Cheers On Fri, Jan 19, 2018 at 7:18 PM, Richard Sharpe wrote: > Hi folks, > > I have the 802.11ax stuff that would be good to get into 2.5.x, > however, th