[Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning

2018-02-02 Thread Gerald Combs
I think we've fixed the major issues identified by Stig, Jim, and others so I'd like to release 2.5.0 on February 6. This would let us release 2.6.0 this spring, followed by 3.0.0 in the fall: March: Create master-2.6 after one or two 2.5.x releases. April: Release 2.6.0, probably after

Re: [Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()

2018-02-02 Thread Roland Knall
Would it make sense to either expand README.developer or add a README.threading, detailing the new startup procedure? Otherwise we might run into issues later where users might face those exact issues. On Fri, Feb 2, 2018 at 7:33 PM, Gerald Combs wrote: > That's correct --

Re: [Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()

2018-02-02 Thread Gerald Combs
That's correct -- the main and RecentFileStatus threads could operate on the filename at the same time. I think the data race is harmless in this case, but it's easy enough to create a local copy of the filename. Fix inbound at https://code.wireshark.org/review/#/c/25572. On 2/2/18 8:08 AM,

Re: [Wireshark-dev] Luacov with Wireshark Lua dissector plugin

2018-02-02 Thread Peter Wu
On Thu, Feb 01, 2018 at 04:14:33PM +0530, Shakthi Kannan wrote: > But, the plugin fails to load with the message > "~/.luarocks/share/lua/5.1/luacov/hook.lua:26:attempt to index global > 'debug' (a function value)". I had filed a query to Luacov at: > >

[Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()

2018-02-02 Thread Stig Bjørlykke
When running with ThreadSanitizer I constantly get this race condition report from a QString in RecentFileStatus. Anyone else seen this? I can't figure out the issue... == WARNING: ThreadSanitizer: data race (pid=41949) Read of size 8 at 0x7b0c000c0dd0 by thread T18: * #0

[Wireshark-dev] Broken build on osx

2018-02-02 Thread Dario Lombardo
Hi Few commits ago (I guess from 142c035), my osx build stopped working on travis. Details: https://travis-ci.org/crondaemon/wireshark/builds with this error: /Users/travis/build/crondaemon/wireshark/ui/qt/about_dialog.cpp:358:43: error: use of undeclared identifier 'wslua_plugin_type_name'