Re: [Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()

2018-02-03 Thread Gerald Combs
On 2/3/18 3:23 AM, Stig Bjørlykke wrote: > On Fri, Feb 2, 2018 at 7:33 PM, Gerald Combs wrote: >> That's correct -- the main and RecentFileStatus threads could operate on the >> filename at the same time. I think the data race is harmless in this case, >> but it's easy enough to create a local c

Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning

2018-02-03 Thread Roland Knall
yes, those should be fixed before a 2.6 release. For 2.5 I think it could be ok. cheers Roland On Sat, Feb 3, 2018 at 12:52 PM, Jakub Zawadzki wrote: > Hello, > > W dniu 2018-02-02 23:45, Gerald Combs napisał(a): > >> I think we've fixed the major issues identified by Stig, Jim, and >> others s

Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning

2018-02-03 Thread Jakub Zawadzki
Hello, W dniu 2018-02-02 23:45, Gerald Combs napisał(a): I think we've fixed the major issues identified by Stig, Jim, and others so I'd like to release 2.5.0 on February 6. In oss-fuzz queue currently there are few crashes, and one inifite loop. Should it be a blocker for a release? Regards,

Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning

2018-02-03 Thread Stig Bjørlykke
On Fri, Feb 2, 2018 at 11:45 PM, Gerald Combs wrote: > I think we've fixed the major issues identified by Stig, Jim, and others so > I'd like to release 2.5.0 on February 6. Maybe not a show stopper the release, but selecting a byte in the ByteView does not expand the corresponding tree item as

Re: [Wireshark-dev] ThreadSanitizer issue in RecentFileStatus()

2018-02-03 Thread Stig Bjørlykke
On Fri, Feb 2, 2018 at 7:33 PM, Gerald Combs wrote: > That's correct -- the main and RecentFileStatus threads could operate on the > filename at the same time. I think the data race is harmless in this case, > but it's easy enough to create a local copy of the filename. Fix inbound at > https:/

Re: [Wireshark-dev] copy from the packet pane broken?

2018-02-03 Thread Anders Broman
Den 3 feb. 2018 10:47 skrev "Roland Knall" : On Sat, Feb 3, 2018 at 10:41 AM, Anders Broman wrote: > > > Den 3 feb. 2018 10:36 fm skrev "Roland Knall" : > > Hi > > Copy works from the "Packets Detail" pane as well as the "Packets List" on > the latest master. Tried various copy functions. > >

Re: [Wireshark-dev] copy from the packet pane broken?

2018-02-03 Thread Roland Knall
On Sat, Feb 3, 2018 at 10:41 AM, Anders Broman wrote: > > > Den 3 feb. 2018 10:36 fm skrev "Roland Knall" : > > Hi > > Copy works from the "Packets Detail" pane as well as the "Packets List" on > the latest master. Tried various copy functions. > > What does not seem to work on my mac build is th

Re: [Wireshark-dev] copy from the packet pane broken?

2018-02-03 Thread Anders Broman
Den 3 feb. 2018 10:36 fm skrev "Roland Knall" : Hi Copy works from the "Packets Detail" pane as well as the "Packets List" on the latest master. Tried various copy functions. What does not seem to work on my mac build is the submenu indicator for the copy submenu. But this might be a Qt issue, n

Re: [Wireshark-dev] copy from the packet pane broken?

2018-02-03 Thread Roland Knall
Hi Copy works from the "Packets Detail" pane as well as the "Packets List" on the latest master. Tried various copy functions. What does not seem to work on my mac build is the submenu indicator for the copy submenu. But this might be a Qt issue, not a WS one, we register the submenu correctly.

[Wireshark-dev] copy from the packet pane broken?

2018-02-03 Thread Anders Broman
Hi, I think the copy function may be broken. No possibility to check today. Regards Anders ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wiresha