Re: [Wireshark-dev] error during DMG creation under macOS 10.13.2

2018-02-19 Thread Guy Harris
On Jan 19, 2018, at 11:31 PM, Peter Meiser wrote: > I try to compile Wireshark under macOS 10.13.2. I installed the needed > libraries and tools via brew (see the list and versions below). > > "make" runs fine, "make dmg_package" shows the an error inbetween so that the > some libs the wrong r

Re: [Wireshark-dev] IEEE802.11 Block Ack esoterica question

2018-02-19 Thread Richard Sharpe
On Mon, Feb 19, 2018 at 1:52 PM, Simon Barber via Wireshark-dev wrote: > Looks OK to me - I'd want to see it as a separate change though. Hmmm, I could extract that as a separate change ... and then use it in the 802.11ax changes. Not sure if it is worth the effort. I will probably change things

Re: [Wireshark-dev] IEEE802.11 Block Ack esoterica question

2018-02-19 Thread Simon Barber via Wireshark-dev
Looks OK to me - I'd want to see it as a separate change though. On Mon, Feb 19, 2018 at 12:39 PM, Richard Sharpe < realrichardsha...@gmail.com> wrote: > On Mon, Feb 19, 2018 at 12:33 PM, Simon Barber via Wireshark-dev > wrote: > > Can you post the code to gerrit (mark as WIP) so we can see exac

Re: [Wireshark-dev] IEEE802.11 Block Ack esoterica question

2018-02-19 Thread Richard Sharpe
On Mon, Feb 19, 2018 at 12:33 PM, Simon Barber via Wireshark-dev wrote: > Can you post the code to gerrit (mark as WIP) so we can see exactly what > you've done? Well, it's already there ... have a bug fix though because I got a capture with block acks (but not HE block acks ...) It is, of cours

Re: [Wireshark-dev] IEEE802.11 Block Ack esoterica question

2018-02-19 Thread Simon Barber via Wireshark-dev
Can you post the code to gerrit (mark as WIP) so we can see exactly what you've done? Simon On Mon, Feb 19, 2018 at 12:13 PM, Richard Sharpe < realrichardsha...@gmail.com> wrote: > Hi folks, > > In handling 802.11ax Trigger requests I have refactored the handling > of block acks. > > In doing so

[Wireshark-dev] IEEE802.11 Block Ack esoterica question

2018-02-19 Thread Richard Sharpe
Hi folks, In handling 802.11ax Trigger requests I have refactored the handling of block acks. In doing so I have eliminated the distinction between Block Ack Requests and Block Acks in the search filters. They used to be things like 'wlan.bar.blah-blah' and 'wlan.ba.blah-blah'. They are all no

Re: [Wireshark-dev] error during DMG creation under macOS 10.13.2

2018-02-19 Thread Peter Meiser
Hi, I still need your help as I can't fix this issue by myself. Thanks, Peter Am 20.01.2018 um 08:31 schrieb Peter Meiser: > Hi, > > I try to compile Wireshark under macOS 10.13.2. I installed the needed > libraries and tools via brew (see the list and versions below). > > "make" runs fine, "

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Pascal Quantin
2018-02-19 15:26 GMT+01:00 Dario Lombardo : > > > On Mon, Feb 19, 2018 at 3:13 PM, Pascal Quantin > wrote: > >> >> As indicated by Alexis, Anders and Graham, CMake should already have >> created a target. >> Fox example on my Linux machine, in the build tree, I can go to >> epan\dissectors\asn1\h

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Dario Lombardo
On Mon, Feb 19, 2018 at 3:13 PM, Pascal Quantin wrote: > > As indicated by Alexis, Anders and Graham, CMake should already have > created a target. > Fox example on my Linux machine, in the build tree, I can go to > epan\dissectors\asn1\h248 folder and I have a Makefile that, when executed, > wil

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Graham Bloice
On 19 February 2018 at 14:04, Dario Lombardo wrote: > That's what I needed. I was close to it, but I didn't get the right > starting point for regenerating. > What's missing IMHO is a cmake target for that. Maybe I will take some > time to add one (many, actually). > Thanks Darien. > > There is a

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Pascal Quantin
Hi Dario, 2018-02-19 15:04 GMT+01:00 Dario Lombardo : > That's what I needed. I was close to it, but I didn't get the right > starting point for regenerating. > What's missing IMHO is a cmake target for that. Maybe I will take some > time to add one (many, actually). > Thanks Darien. > As indica

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Dario Lombardo
That's what I needed. I was close to it, but I didn't get the right starting point for regenerating. What's missing IMHO is a cmake target for that. Maybe I will take some time to add one (many, actually). Thanks Darien. On Mon, Feb 19, 2018 at 2:41 PM, Darien Spencer wrote: > Hi > I've done th

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Graham Bloice
On 19 February 2018 at 13:35, Anders Broman wrote: > Hi, > > With h248 as example > > On Windows, you need to go to the epan\dissectors\asn\h248 folder in your > buils dir and run: > msbuild /m /p:Configuration=RelWithDebInfo generate_dissector-h248.vcxproj > > Regards > > Anders > No need to ch

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Darien Spencer
HiĀ  I've done this several times and the way I do it is: 1. Look for the final dissector file, should be under epan/dissector/packet-xxx.c (in this case packet-snmp.c) 2. Copy the build command for asn2wrs as seen in the 4th line. In this case it looks like this: asn2wrs.py -b -p snmp -c ./snmp

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Anders Broman
Hi, With h248 as example On Windows, you need to go to the epan\dissectors\asn\h248 folder in your buils dir and run: msbuild /m /p:Configuration=RelWithDebInfo generate_dissector-h248.vcxproj Regards Anders From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Alexis La

Re: [Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Alexis La Goutte
use make on asn1 folder ? On Mon, Feb 19, 2018 at 1:55 PM, Dario Lombardo wrote: > Hi > I've modified epan/dissectors/asn1/snmp/packet-snmp-template.c and I want > to regenerate the corresponding dissector. > I've found the cmake target epan/dissectors/asn1/snmp/generate_dissector-snmp, > but bu

[Wireshark-dev] Regenerate asn dissector

2018-02-19 Thread Dario Lombardo
Hi I've modified epan/dissectors/asn1/snmp/packet-snmp-template.c and I want to regenerate the corresponding dissector. I've found the cmake target epan/dissectors/asn1/snmp/generate_dissector-snmp, but building it doesn't regenerate the dissector. What's the missing step? Thanks. Dario. __