Re: [Wireshark-dev] Unittesting the Qt UI

2019-08-05 Thread Gerald Combs
To get up and running quickly you should be able to add something like the following to the case_unittests class in suite_unittests.py: def test_unit_qt_test(self, program, base_env): '''qt_test''' self.assertRun(program('name_of_test_program'), env=base_env) You can then

Re: [Wireshark-dev] (34169) Pre-commit check failing incorrectly?

2019-08-05 Thread Guy Harris
On Aug 5, 2019, at 2:37 PM, Dario Lombardo wrote: > On Mon, Aug 5, 2019 at 11:20 PM Guy Harris wrote: > >> On Aug 5, 2019, at 1:02 PM, Dario Lombardo wrote: >> >>> The message is telling you that ENC_BIG_ENDIAN has been used on a FT_UINT8 >>> fiield, >> >> If that's what it's telling you,

Re: [Wireshark-dev] (34169) Pre-commit check failing incorrectly?

2019-08-05 Thread Guy Harris
On Aug 5, 2019, at 1:02 PM, Dario Lombardo wrote: > The message is telling you that ENC_BIG_ENDIAN has been used on a FT_UINT8 > fiield, If that's what it's telling you, it's lying - the line in question is adding hf_cdp_data, which is an FT_BYTES field.

Re: [Wireshark-dev] (34169) Pre-commit check failing incorrectly?

2019-08-05 Thread Dario Lombardo
The message is telling you that ENC_BIG_ENDIAN has been used on a FT_UINT8 fiield, that is 1 byte long, then no point is setting the endianess. From a quick look of the dissector I can tell that hf_cdp_data has been used with variable lengths. What's its len? If it's a variable len field ("data"

[Wireshark-dev] (34169) Pre-commit check failing incorrectly?

2019-08-05 Thread Oliver Brown
Re: https://code.wireshark.org/review/c/34169/ I've simply expanding definitions for existing flags in CDP packets, specifically for four additional CDP capabilities, yet the Ubuntu pre-commit check is failing due to code that shouldn't have anything to do with changes I made.

[Wireshark-dev] Unittesting the Qt UI

2019-08-05 Thread Roland Knall
Hi I am currently building unittests to ensure, that the ProfileModel implementation does not change functionality. Also, in the future, I want to implement coverage to help further sanitize code. I am at loss though on how to integrate my tests in our test framework. Currently I've created a