Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread João Valverde
On 29/12/19 21:16, João Valverde wrote: On 29/12/19 20:46, Roland Knall wrote: The way here would be to push your patch to gerrit. iLBC seems to be distributed (at least the codec as part of the WebRTC project) with a BSD-Style license, so integration should be doable. Please also check, b

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread João Valverde
On 29/12/19 20:46, Roland Knall wrote: The way here would be to push your patch to gerrit. iLBC seems to be distributed (at least the codec as part of the WebRTC project) with a BSD-Style license, so integration should be doable. Please also check, beside tools/debian-setup.sh there are scrip

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread Roland Knall
The way here would be to push your patch to gerrit. iLBC seems to be distributed (at least the codec as part of the WebRTC project) with a BSD-Style license, so integration should be doable. Please also check, beside tools/debian-setup.sh there are scripts in there for other Linux distributions as

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread João Valverde
On 29/12/19 13:46, Jiří Novák wrote: Hi, For Ubuntu there is tools/debian-setup.sh that installs optional packages (as this). I suggest you to test your change at least on this platform since it's the most common. OK. I will try. Did you make your change compilable without that library? Yo

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread João Valverde
On 29/12/19 13:46, Jiří Novák wrote: Hi, For Ubuntu there is tools/debian-setup.sh that installs optional packages (as this). I suggest you to test your change at least on this platform since it's the most common. OK. I will try. Did you make your change compilable without that library? Yo

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread Pascal Quantin
Hi Jiri, Le dim. 29 déc. 2019 à 14:47, Jiří Novák a écrit : > Hi, > > > For Ubuntu there is tools/debian-setup.sh that installs optional > > packages (as this). > > I suggest you to test your change at least on this platform since it's > > the most common. > > OK. I will try. > > > Did you make

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread Jiří Novák
Hi, > For Ubuntu there is tools/debian-setup.sh that installs optional > packages (as this). > I suggest you to test your change at least on this platform since it's > the most common. OK. I will try. > Did you make your change compilable without that library? You need some > preprocessor ifdefs