Re: [Wireshark-dev] Build failure (kerberos)

2020-03-23 Thread Martin Mathieson via Wireshark-dev
This works for me (when I cherry-pick all 3 of your changes). Martin On Mon, Mar 23, 2020 at 9:43 AM Dario Lombardo wrote: > Ok, this seems to work. I'm pushing the fix. > > On Mon, Mar 23, 2020 at 9:29 AM Pascal Quantin > wrote: > >> >> >> Le lun. 23 mars 2020 à 09:17, Dario Lombardo a écrit

Re: [Wireshark-dev] Build failure (kerberos)

2020-03-23 Thread Dario Lombardo
Ok, this seems to work. I'm pushing the fix. On Mon, Mar 23, 2020 at 9:29 AM Pascal Quantin wrote: > > > Le lun. 23 mars 2020 à 09:17, Dario Lombardo a écrit : > >> >> >> On Sun, Mar 22, 2020 at 6:15 PM Dario Lombardo wrote: >> >>> Ok, thanks. >>> >>> On Sun, Mar 22, 2020 at 9:48 AM Martin

Re: [Wireshark-dev] Build failure (kerberos)

2020-03-23 Thread Pascal Quantin
Le lun. 23 mars 2020 à 09:17, Dario Lombardo a écrit : > > > On Sun, Mar 22, 2020 at 6:15 PM Dario Lombardo wrote: > >> Ok, thanks. >> >> On Sun, Mar 22, 2020 at 9:48 AM Martin Mathieson < >> martin.r.mathie...@googlemail.com> wrote: >> >>> > ./asn1/kerberos/packet-kerberos-template.c: In

Re: [Wireshark-dev] Build failure (kerberos)

2020-03-23 Thread Dario Lombardo
On Sun, Mar 22, 2020 at 6:15 PM Dario Lombardo wrote: > Ok, thanks. > > On Sun, Mar 22, 2020 at 9:48 AM Martin Mathieson < > martin.r.mathie...@googlemail.com> wrote: > >> ./asn1/kerberos/packet-kerberos-template.c: In function ‘dissect_krb5_PAC_CREDENTIAL_INFO’:

Re: [Wireshark-dev] Dissectors with the same abbreviation

2020-03-23 Thread Tomasz Moń
On Fri, Mar 20, 2020 at 4:19 PM Pascal Quantin wrote: > Le ven. 20 mars 2020 à 16:10, Tomasz Moń a écrit : >> What abbreviation should Picture Transfer Protocol dissector use? > iso_ptp maybe? Initially I was thinking about just "iso15740", but this suggestion makes me think "ptp_iso15740"