Re: [Wireshark-dev] Filtering on a field when there is more than one such field in a Wi-Fi packet

2020-08-13 Thread Jaap Keuter
Hi Richard, The display filter engine has no concept of individual instances of a field, either it’s there in a packet or not and its value is used in the expression. Where it is in the packet and in what relation to other fields in a display filter expression is of no concern of the display fi

Re: [Wireshark-dev] [Wireshark-users] The Wireshark wiki has a new home

2020-08-13 Thread Gerald Combs
On 8/12/20 12:17 PM, Gerald Combs wrote: > * Create a separate, public wiki-only gitlab.com/wireshark/wireshark-wiki > project, and grant Developer permissions to anyone that wants to contribute. > > * Create a separate, possibly-private wiki-only > gitlab.com/wireshark/wireshark-wiki-backend p

[Wireshark-dev] Filtering on a field when there is more than one such field in a Wi-Fi packet

2020-08-13 Thread Richard Sharpe
Hi folks, I faced an interesting problem recently. I was typing to find a particular tagged item with a tag length greater than a specific size. This presented a problem because many Wi-Fi packets have tagged fields and a search filter like wlan.tag.number == X and wlan.tag.length >= some-value

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

2020-08-13 Thread Guy Harris
On Aug 13, 2020, at 5:27 AM, Jaap Keuter wrote: > On 13 Aug 2020, at 09:37, Guy Harris wrote: > >> On Aug 13, 2020, at 12:24 AM, Jaap Keuter wrote: >> >>> For now(*) this is done as per >>> https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message >> >> He's tal

Re: [Wireshark-dev] tshark --export-objects : -2 assumed or required for two-pass ?

2020-08-13 Thread Mikael Kanstrup
On Tue, Aug 11, 2020, 06:08 chuck c wrote: > There seems to be an extra call to dissect_dcm_tag() in Wireshark before > sop_class_uid and sop_instance_uid are needed in > dcm_export_create_object(). > > In tshark they are null so fail the test of containing data and > boilerplate values are put i

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

2020-08-13 Thread Jaap Keuter
> On 13 Aug 2020, at 09:37, Guy Harris wrote: > > On Aug 13, 2020, at 12:24 AM, Jaap Keuter wrote: > >> For now(*) this is done as per >> https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message > > He's talking about comments in Gerrit, such as "this change bro

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

2020-08-13 Thread Guy Harris
On Aug 12, 2020, at 11:05 AM, chuck c wrote: > What is protocol to tie a bug entry > (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16771) > to a Gerrit change (https://code.wireshark.org/review/#/c/31973/)? One way to do it would be to file the bug and then make a post-commit comment in

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

2020-08-13 Thread Guy Harris
On Aug 13, 2020, at 12:24 AM, Jaap Keuter wrote: > For now(*) this is done as per > https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message He's talking about comments in Gerrit, such as "this change broke XXX"; he's not talking about commit messages in Git.

Re: [Wireshark-dev] Protocol to tie Bugzilla entry to Gerrit change

2020-08-13 Thread Jaap Keuter
Hi, For now(*) this is done as per https://wiki.wireshark.org/Development/SubmittingPatches#Writing_a_Good_Commit_Message (*) there’s a Big Move coming to a GitLab instance, this will Change Everything(tm