Re: [Wireshark-dev] Dissector functions and variables that could be static

2021-01-24 Thread Martin Mathieson via Wireshark-dev
On Sun, Jan 24, 2021 at 8:27 PM Jirka Novak wrote: > Hi, > > I checked the code I know: > > > epan/dissectors/packet-rtp-events.c (01a0 D> > rtp_event_type_values_ext) is not referred to so could be static? (in> > header) > It is used in UI, outside of dissectors. Therefore it

Re: [Wireshark-dev] Dissector functions and variables that could be static

2021-01-24 Thread Jirka Novak
Hi, I checked the code I know: > epan/dissectors/packet-rtp-events.c (01a0 D> > rtp_event_type_values_ext) is not referred to so could be static? (in> header) It is used in UI, outside of dissectors. Therefore it should be exported. > epan/dissectors/packet-rtp.c

Re: [Wireshark-dev] Dissector functions and variables that could be static

2021-01-24 Thread Martin Mathieson via Wireshark-dev
Hi Moshe, It would be possible. I would still like to hear from people if they think it is worth doing, and we would need to clear the current cases (perhaps with a list of agreed exemptions, like the PDCP key-setting functions I mentioned). I will likely start picking off issues when I have